Commit Graph

309 Commits

Author SHA1 Message Date
Scott Wheeler
711132c89f Fix RVA setting / parsing. Patch from Stephen Booth.
BUG:107025



git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@689477 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-07-18 11:36:26 +00:00
Martin Aumüller
12dcb75582 set correct install_name for os x
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@683171 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-07-04 10:12:22 +00:00
Scott Wheeler
b5a9b00003 Remove empty Xiph comments. Patch from Stephan Booth.
BUG:145532
CCMAIL:taglib-devel@kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@672863 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-06-08 11:02:49 +00:00
Michael Pyne
cc00badd70 Fix another MSVC 2007 STL bug (our bug, not theirs) by not resizing a buffer in
writeBlock.  It was possible to resize it to 0 and although it would not be written to
again, the address would be taken of the buffer and MSVC 2007's STL implementation is
strict and will not allow the address of an empty buffer to be taken.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@672039 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-06-06 03:56:38 +00:00
Dirk Mueller
26751ba95b the usual daily unbreak compilation
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@670244 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-05-31 20:51:55 +00:00
Michael Pyne
e08587db9a Don't allow address of zero-length array to be taken to prevent run-time errors with
strict STL implementations.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@668610 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-05-26 23:03:17 +00:00
Dirk Mueller
91046cf73f the usual "daily unbreak compilation"
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@661112 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-05-04 16:15:11 +00:00
Christian Ehrlicher
6e5ab96a4d win32 compile / warnings--
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@658841 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-04-28 16:31:29 +00:00
Christian Ehrlicher
1d52e6f67c win32 compile / warnings--
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@658838 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-04-28 16:17:30 +00:00
Stephan Kulow
3ae55e0864 don't dereference d twice (CID 3444)
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@652702 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-04-11 20:35:37 +00:00
Stephan Kulow
f37023791f don't deref d twice (CID 3445)
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@652701 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-04-11 20:34:57 +00:00
Scott Wheeler
1fb31274e5 Check for CBR Info headers also.
BUG:141681


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@649037 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-04-01 22:22:53 +00:00
Scott Wheeler
39f8acfdf0 SVN_SILENT too many emacs modes...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@649036 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-04-01 22:21:44 +00:00
Scott Wheeler
fecad172f3 Strip nulls from the end of ID3v2 text fields.
Simplified version of the patch from Xavier Duret.

BUG:141680


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@649032 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-04-01 22:08:44 +00:00
Scott Wheeler
88668d9fd0 Add a comment about valid encoding types for ID3v2 tags.
CCBUG:135122


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@649003 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-04-01 21:07:08 +00:00
Scott Wheeler
76304a1356 Switch to using a list of genres and checking for membership in there to avoid repeated values.
Based on a patch from Xavier Duret.

BUG:141679


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@648998 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-04-01 20:54:13 +00:00
Scott Wheeler
3e36746dbb SVN_SILENT grr, accidentally inserted tabs
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@648997 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-04-01 20:49:15 +00:00
Scott Wheeler
784d7cd1e0 Strip whitespaces from the end of ID3v1 fields on the way into TagLib.
BUG:141678


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@648986 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-04-01 20:31:03 +00:00
Scott Wheeler
cce96cfec9 Delete APE tag.
BUG:141682


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@648984 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-04-01 20:25:54 +00:00
Scott Wheeler
1d3518d1ad Fix signature.
BUG:143103


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@645468 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-03-22 17:30:29 +00:00
Scott Wheeler
9f1db4aac9 SVN_SILENT tabs -> spaces
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@637415 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-02-26 11:40:05 +00:00
Scott Wheeler
7ab48e1ab7 SVN_SILENT whoops, those were tabs
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@634206 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-02-16 16:15:55 +00:00
Scott Wheeler
19680eb91f Delete d-pointer.
CCBUG:141682


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@634161 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-02-16 14:29:40 +00:00
Scott Wheeler
776bb45f7f SVN_SILENT whoops
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@633141 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-02-13 10:19:20 +00:00
Scott Wheeler
63ace4995c Read the frame data length as a synch-safe int. (Mostly only relevant to
compressed frames)


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@633140 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-02-13 10:18:30 +00:00
Scott Wheeler
89b1e54ae0 Don't try to parse invalid frames.
BUG:137635


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@633133 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-02-13 09:55:56 +00:00
Scott Wheeler
4382e84e9e Add another sanity check -- don't let invalid frames try to allocate anything
larger than the tag size.

BUG:140515


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@633123 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-02-13 09:26:31 +00:00
Scott Wheeler
3218095aca Fix the byte ordering for UTF16BE
BUG:135121


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@633110 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-02-13 08:40:58 +00:00
Scott Wheeler
320b76d95a Rework the read-only check so that it gets along better with networked file systems.
CCMAIL:apoikos@gmail.com


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@633092 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-02-13 07:21:45 +00:00
Scott Wheeler
2e8c6ea0f4 Actually overwrite the value, as documented.
BUG:141496


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@633078 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-02-13 05:43:10 +00:00
Scott Wheeler
2aa4195807 correct docs
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@620852 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-01-07 15:33:21 +00:00
Scott Wheeler
a3d8b6be8b Revert this as this change isn't BC
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@620850 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-01-07 15:31:01 +00:00
Brad Hards
b9c7c6ae5f A few spelling fixes, identified using krazy.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@618883 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-01-02 11:54:03 +00:00
Jeff Mitchell
5760457f5f Remove check as condition will always be true (checked in the if condition, above).
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@615877 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-12-23 01:34:01 +00:00
Laurent Montel
df614076d8 Fix warning
Fix create HAVE_ZLIB variable


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@611286 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-12-07 14:13:46 +00:00
André Wöbbeking
2697c96ff7 -pedantic
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@608497 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-11-27 18:17:05 +00:00
André Wöbbeking
dc41f3f718 copied gcc compile flags from FindKDE4Internal.cmake
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@608496 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-11-27 18:15:11 +00:00
Laurent Montel
80e20afd7e Fix compile under windows
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@603814 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-11-10 10:43:59 +00:00
Scott Wheeler
b0addb15e1 Uhh, no. Once again, TagLib is not part of KDE and is still used by a lot more things
than JuK, most of which still use Qt 3.  If you want to fix the defines to check for the version
that's fine.  I'm not too worried about it since the code still works with Qt 4.

CCMAIL:Tim Beaulen <tbscope@gmail.com>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@595794 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-10-15 17:24:13 +00:00
Tim Beaulen
de56f6850d replace uft8() with toUtf8() to silence warnings in Juk.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@595632 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-10-15 08:04:12 +00:00
Scott Wheeler
7892e7c9df Don't dereference the iterator before checking its validity.
CCMAIL:taglib-devel@kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@594940 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-10-12 21:11:48 +00:00
David Faure
245a8af778 fix make install - I guess examples shouldn't actually be installed
(I see that Makefile.am required "make examples" explicitly)


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@594795 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-10-12 10:50:45 +00:00
Scott Wheeler
4d26775702 SVN_SILENT spacing
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@593781 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-10-09 02:51:52 +00:00
Brad Hards
4edbc93494 Change the taglib build system to use relative include paths.
This allows you to build taglib either as part of kdesupport
(i.e. with a source directory of kdesupport/) or by itself
(i.e. with a source directory of kdesupport/taglib/).


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@593544 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-10-08 06:28:19 +00:00
Scott Wheeler
5703a3619b Don't try to erase a key that isn't there.
BUG:134726


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@593479 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-10-07 22:29:06 +00:00
Scott Wheeler
22a2d44a80 Make the Xing header publically accessible.
WISH:133757


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@593475 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-10-07 22:17:07 +00:00
Brad Hards
8898a90936 Compile fix, correcting the include paths.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@593292 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-10-07 11:45:35 +00:00
Laurent Montel
6cc6f7f1cf Fix install files
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@592630 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-10-05 08:03:42 +00:00
Laurent Montel
9dd4bf063e Add support for examples
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@592362 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-10-04 15:21:01 +00:00
Laurent Montel
619b1eaf54 Add tests directory into build
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@592361 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-10-04 15:12:47 +00:00