Michael Helmling
6e3391a846
Add a test to show a problem with properties() and duplication.
2012-12-10 21:22:11 +01:00
Michael Helmling
c0ca5c97d5
Fix issue #88 by changing the behavior of setProperties().
...
For file types that support multiple tag standards (for example, FLAC
files can have ID3v1, ID3v2, and Vorbis comments) setProperties is now
called for all existing tags instead of only for the most recommended
one.
This fixes the problem that under some circumstances it was not possible
to delete a value using setProperties() because upon save() the call to
Tag::duplicate recovered that value from the ID3v1 tag.
2012-12-10 20:56:16 +01:00
Michael Helmling
d5cf6d72e2
Merge remote-tracking branch 'official/master'
2012-12-10 19:55:29 +01:00
Michael Helmling
9eb0f2941f
Add a test case for the return value of setProperties()
2012-12-10 19:55:23 +01:00
naota
3fa295d99d
Include sys/stat.h to define S_* properly
...
Without including sys/stat.h, this file failed to build on FreeBSD with the following error.
In file included from /var/tmp/portage/media-libs/taglib-1.8/work/taglib-1.8/tests/test_trueaudio.cpp:5:0:
/var/tmp/portage/media-libs/taglib-1.8/work/taglib-1.8/tests/utils.h: In function 'std::string copyFile(const string&, const string&)':
/var/tmp/portage/media-libs/taglib-1.8/work/taglib-1.8/tests/utils.h:36:62: error: 'S_IRUSR' was not declared in this scope
/var/tmp/portage/media-libs/taglib-1.8/work/taglib-1.8/tests/utils.h:36:72: error: 'S_IWUSR' was not declared in this scope
In file included from /var/tmp/portage/media-libs/taglib-1.8/work/taglib-1.8/tests/test_mpeg.cpp:6:0:
/var/tmp/portage/media-libs/taglib-1.8/work/taglib-1.8/tests/utils.h: In function 'std::string copyFile(const string&, const string&)':
/var/tmp/portage/media-libs/taglib-1.8/work/taglib-1.8/tests/utils.h:36:62: error: 'S_IRUSR' was not declared in this scope
/var/tmp/portage/media-libs/taglib-1.8/work/taglib-1.8/tests/utils.h:36:72: error: 'S_IWUSR' was not declared in this scope
gmake[2]: *** [tests/CMakeFiles/test_runner.dir/test_mpeg.cpp.o] Error 1
2012-11-28 07:54:08 +09:00
Lukáš Lalinský
812f63502b
Implement the PropertyMap interface for WMA
2012-11-23 09:32:00 +01:00
Lukáš Lalinský
353eb9f00f
Implement the PropertyMap interface for MP4
2012-11-22 10:40:22 +01:00
Lukáš Lalinský
1b813d9d6c
Document sort names
2012-11-21 17:26:17 +01:00
Lukáš Lalinský
c5dade5ee7
Use names that are consistent with Vorbis Comments
2012-11-21 17:24:32 +01:00
Lukáš Lalinský
e75d6f616c
Add support for reading MusicBrainz IDs from ID3v2 tags to PropertyMap
2012-11-21 17:21:30 +01:00
Lukáš Lalinský
15b601f053
Use PropertyMap in tagreader
2012-11-21 14:40:26 +01:00
Lukáš Lalinský
45317ef7f2
Revert "Fix opening of read-only files on Windows"
...
This reverts commit ade8dc1a218e43c3909c4eede58f4e28e09da73a.
2012-11-20 18:34:51 +01:00
Lukáš Lalinský
3da792152a
Merge pull request #85 from TsudaKageyu/fix-readonly
...
Fix reading read-only files in Win32
2012-11-20 09:23:16 -08:00
Tsuda Kageyu
3f6da779d2
Fix compilation in non-Win32
2012-11-20 22:46:03 +09:00
Tsuda Kageyu
57b8ae6e1c
Fix reading read-only files in Win32
2012-11-20 22:20:34 +09:00
Lukáš Lalinský
ade8dc1a21
Fix opening of read-only files on Windows
...
The CreateFile* functions return INVALID_HANDLE_VALUE on error, not NULL.
http://article.gmane.org/gmane.comp.kde.devel.taglib/2346
2012-11-20 14:15:16 +01:00
Lukáš Lalinský
c6f7ad3e83
Revert "Add a tool to inspect audio files, only MP4 is implemented for now"
...
This reverts commit 45b0279b411958d8fcc1428dc38084f351ae4b80.
2012-11-12 16:14:32 +01:00
Lukáš Lalinský
dbe6be778b
Build also examples
2012-11-11 16:44:01 +01:00
Lukáš Lalinský
45b0279b41
Add a tool to inspect audio files, only MP4 is implemented for now
2012-11-11 16:43:36 +01:00
Lukáš Lalinský
3a5aeb4573
Parse covr atoms with type 0 (fixes issue #84 )
2012-11-11 16:04:08 +01:00
Lukáš Lalinský
72745846f4
Update NEWS
2012-11-11 14:49:31 +01:00
Lukáš Lalinský
9e788bb8c2
Fix tests when compiled with clang on Linux
2012-11-11 14:26:10 +01:00
Lukáš Lalinský
56fbe7e14d
Make travis run tests also with clang
2012-11-10 20:51:17 +01:00
Lukáš Lalinský
44155f6771
Merge pull request #79 from gonemad/master
...
Check if file is open before reading tags
2012-11-04 01:27:43 -07:00
Lukáš Lalinský
341711c04b
Merge pull request #83 from jmarshallnz/more_itunes_hacks
...
A small fix, and some additional iTunes hacks (v2.2 frames in v2.3 tag)
2012-11-04 01:26:26 -07:00
Jonathan Marshall
be6187e893
adds new iTunes hack for v2.2 frames stored in a v2.3 tag (iTunes v8.1.1.10 for example)
2012-11-04 19:54:28 +13:00
Jonathan Marshall
c42bdeab43
fixes noop frame id size check in ID3v2::FrameFactory::createFrame
2012-11-04 19:52:10 +13:00
gonemad
7d7c58cb8e
Merge branch 'master' of https://github.com/taglib/taglib
2012-10-18 20:17:35 -04:00
Lukáš Lalinský
044da877e6
Make sure we build the tests
2012-10-13 13:38:35 +02:00
Lukáš Lalinský
2d7686b5fa
Actually run the tests
2012-10-13 13:36:33 +02:00
Lukáš Lalinský
074f6db6d8
Needs sudo
2012-10-13 13:34:44 +02:00
Lukáš Lalinský
7a884af0ef
Experimenting with Travis CI
2012-10-13 13:33:36 +02:00
Lukáš Lalinský
e568e1019d
Remove useless debug print
2012-10-13 09:11:20 +02:00
Lukáš Lalinský
ca543039a5
Include Opus in docs
2012-10-13 09:06:09 +02:00
Lukáš Lalinský
5e7b1da632
Add support for Ogg Opus
2012-10-13 08:55:23 +02:00
gonemad
6b9ef6421f
Fixed indents
2012-10-11 22:10:19 -04:00
gonemad
d15c8453ac
Added check if file is open before attempting to read tags
2012-10-11 21:20:03 -04:00
Lukáš Lalinský
1e660dda71
Partial changelog for 1.9
2012-10-10 17:09:03 +02:00
Lukáš Lalinský
2a77afc593
Merge remote-tracking branch 'nightingale/master'
2012-10-10 16:45:36 +02:00
Tsuda Kageyu
a9df3e48f7
Fix a bug in updating MP4 tags
2012-10-10 21:17:05 +09:00
rsjtdrjgfuzkfg
c8994ede3f
Restrict url frame generation to W??? Frames to prevent known non-text non-url frameIDs to be handled as url when containing only one String. No longer describe the default comment as "COMMENT".
2012-10-08 20:19:12 +02:00
Lukáš Lalinský
7e255733e0
Merge remote-tracking branch 'TsudaKageyu/id3v1-genrenumber'
2012-10-08 13:23:17 +02:00
Julien Ramseier
72f9a96cce
Fix missing CppUnit include directive
2012-10-07 15:41:40 +02:00
Stephen F. Booth
1308ff6479
Merge pull request #73 from ArnaudBienner/master
...
Corrupted FLAC files scan can result in heavy CPU consumption: fix
2012-10-07 05:29:02 -07:00
Arnaud Bienner
b7a15092d8
Faster FLAC::FilePrivate destructor
2012-10-07 03:07:53 +02:00
Arnaud Bienner
ad9ffc62e6
Consider FLAC file as being invalid if a 0 length block is found
2012-10-07 03:04:02 +02:00
Tsuda Kageyu
46e613dcca
Add reading/writing ID3v1 genre in number
2012-10-04 19:23:10 +09:00
Urs Fleisch
2d7414733e
Crash when saving xm files ( fixes #68 )
2012-09-30 15:42:16 +02:00
Lukáš Lalinský
9f597bab1b
Change some variables to follow the TagLib naming convention
2012-09-30 10:50:19 +02:00
Lukáš Lalinský
321b9b5a8b
Merge remote-tracking branch 'TsudaKageyu/filestream'
2012-09-30 10:43:58 +02:00