that takes a maximum number of values. This should probably be used more widely in
places where the max is known ahead of time for this to be a more useful fix than nailing
just this special case. Anyway, fixes the bug.
BUG:103622
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438030 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
should be functional enough to hold over to the next binary
incompatible change and has a minimum of differences to the previous
API.
I did a slightly nasty hack so that the API docs will see just methods
with an optional argument, but those are actually two separate methods
(for BC).
Brian, please feel free to take a look at this prior to 1.4 going out.
BUG:107025
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437115 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
to working. The more complicated fix for #107025 will
follow shortly.
BUG:95545
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437091 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
UnknownFrame and set the flag to discard it on write.
As a special bonus this meant implementing the discard-on-tag-alter
flag.
BUG:100515
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415248 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
is if a bogus frame is hit it may try to parse it as an UnknownFrame rather
than just discarding it.
CCMAIL:Espen Tveit <espen.tveit@gmail.com>
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@355686 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
I missed that. I'll come up with something -- probably a functor or similar
to work around this at some point.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336480 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
back the compressed/encrypted data as a string.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@335256 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
causing the bytes to not get lined up properly in the newly written tag and
then they weren't read back properly.
CCMAIL:82898-done@bugs.kde.org
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@332788 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
libid3tag:
*) Handle the case of there being an extended header where the first byte
is zero (this was running into a check to see if the padding had been
reached)
*) Add support for reading ID3v2::Frame::Header flags. Previously this
was not implemented, but was needed to...
*) Properly adjust the reading position for the existance of a data length
indicator at the beginning of frames
Things now seem to work with the test files that I have here. Since this
is the only other ID3v2.4 implmentation that I know of "in the wild" it's
nice that they now play nice together. libid3tag uses many more of the
unique ID3v2.4 features than TagLib does.
CCMAIL:82867-done@bugs.kde.org
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@332778 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
*) Note that adding and removing frames from the ID3v2::Tag will invalidate
iterators on the frame list
*) Correct the number of genres -- it should be 148 instead of 147. You
can all have your Synthpop genre back now. :-)
CCMAIL:Gary Peck <gbpeck@sbcglobal.net>
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@318067 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
will automatically fix these files on the next write. (At the moment other
taggers will not be able to read the date written by TagLib in the ID3v2 tag.
In most cases they'll fall back to the ID3v1 tag, which is fine, but still
kind of nasty.) Thanks to Teemu Tervo for catching this.
CCMAIL:82038-done@bugs.kde.org
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@314024 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
docs aren't there yet and this is completely untested, but that will follow
as soon as I find a file actually tagged with one of these. :-)
CCMAIL:Jorn Baayen <jbaayen@gnome.org>
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306706 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
example to the examples dir later today showing how to use this.
CCMAIL:Matthias Welwarsky <matze@stud.fbi.fh-darmstadt.de>
CCMAIL:Jorn Baayen <jbaayen@gnome.org>
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306452 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
Basically they fall into the categories:
- Don't convert things before you need to
- When you do, use more effecient copy constructors / assignment operators
(i.e. when copying prefer memcpy to a for loop and when that's not possible
use an iterator instead of operator[])
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@301896 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
when this used to have a default argument).
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@296374 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
replaced in 1999, but apparently iTunes still uses it.
This gets the frame parsing code to support 2.2 and required deprecating
a couple of methods so that an ID3v2 version could be passed along.
There still needs to be a translation table added to handle converting
ID3v2.2 frame names to their ID3v2.4 equivalents, but that can come later.
For now the framelister program from the examples dir is able to read all
of the text frames.
CCMAIL:Keith Brady <keith@funnelboy.org>
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@289567 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
