Commit Graph

2529 Commits

Author SHA1 Message Date
Scott Wheeler
d8fc67ac67 Return a bool indicating if the save was successful as in File::save()
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@332349 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-24 17:30:54 +00:00
Scott Wheeler
ab51136a54 Off by one -- make tagreader work with mpc files.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@331318 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-20 22:50:30 +00:00
Scott Wheeler
fd09b23aa0 Add MPC to the C bindings.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@331317 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-20 22:46:38 +00:00
Scott Wheeler
28738debc1 A few more nitpicks.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@331315 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-20 22:40:57 +00:00
Scott Wheeler
382f8194c1 standard style nitpicks and make it build with gcc 2.95
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@331313 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-20 22:30:00 +00:00
Allan Sandfeld Jensen
2fd6401354 Improve behavoir:
* use setValid(false) to indicate broken files
* avoid reading over file-end in case of truncated files
* subtract size of ID3v1 from streamSize
* skip known ID3v2 tag when scanning for first FLAC-frame
CCMAIL: 83924-done@bugs.kde.org
CCMAIL: 85356@bugs.kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@330951 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-19 17:22:32 +00:00
Allan Sandfeld Jensen
f650edc81d Correct includes so they work when included with path,
like: #include <taglib/mpcfile.h>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@330329 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-17 16:04:50 +00:00
Allan Sandfeld Jensen
ba10ce016f Also update taglib-config
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@330302 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-17 14:19:48 +00:00
Allan Sandfeld Jensen
837872a113 Fix a bit of bitrot
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@330300 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-17 14:17:09 +00:00
Allan Sandfeld Jensen
cda53a3db4 Add support for reading musepack(mpc)-files and parsing APE-tags(v1 and v2).
Bumb version to have something to check for in JuK and kfile_mpc


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@330294 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-17 13:39:27 +00:00
Allan Sandfeld Jensen
425d793752 Compile
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@329093 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-14 11:33:46 +00:00
Allan Sandfeld Jensen
05221f8206 Add find and erase semantics like those in tlist.h
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@328830 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-13 18:28:50 +00:00
Waldo Bastian
6879050c54 Valgrind says home-brew strdup() is broken
Fixes saving of MP3 meta-info from properties dialog


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@328336 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-12 16:07:27 +00:00
Scott Wheeler
9a365f9e7e Fix spelling.
CCMAIL:83908-done@bugs.kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@323801 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-06-26 14:26:36 +00:00
Scott Wheeler
8de9b1f26a Don't try to read the properties from the bytevector if it's smaller than
the required size; in this case empty.  Also some minor nitpicks along the
way.

CCMAIL:83898-done@bugs.kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@323360 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-06-24 15:48:58 +00:00
Scott Wheeler
5b0c38eee9 CVS_SILENT add a note in the docs about strip() behavior
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@323204 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-06-23 22:39:39 +00:00
Scott Wheeler
430e20f191 Another nice patch from Teemu Tervo. This deletes the tags from memory
when they're stripped from the file.

CCMAIL:83424-done@bugs.kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@323203 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-06-23 22:38:21 +00:00
Scott Wheeler
737be443d6 Update the C bindings to reflect the earlier change in the return type
for saving files.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@323195 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-06-23 21:52:27 +00:00
Scott Wheeler
0d04000f74 oops -- forgot FLAC -- return bool for the FLAC::File::save() too to provide
some information on if the save was successful.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@323170 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-06-23 18:45:26 +00:00
Scott Wheeler
8bdecaf320 CVS_SILENT forgot to save this file before the last commit -- doc update
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@323166 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-06-23 18:37:00 +00:00
Scott Wheeler
420541441c Switch the return type of File::save() from void to bool to provide a little
bit of feedback on whether or not the safe operation worked.

CCMAIL:83882@bugs.kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@323165 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-06-23 18:35:52 +00:00
Scott Wheeler
5f2e59150c Ah, this one's easy -- though an odd corer case; there's a Xing header here
but no MPEG frames.  This was triggering a divide by zero.

CCMAIL:83210-done@bugs.kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@321447 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-06-17 15:33:53 +00:00
Scott Wheeler
2817d4e507 initialize variable
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@320862 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-06-15 10:13:05 +00:00
Scott Wheeler
b9de676bc0 Parse ID3v2.4 genres as a list of fields rather than a text string with the
ID3v1 genre in parenthesis.

CCMAIL:82554-done@bugs.kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@319086 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-06-09 14:57:30 +00:00
Scott Wheeler
b69dd382c6 Add iterators and operator[] to the string class.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@319064 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-06-09 13:33:05 +00:00
Scott Wheeler
0c6be64f8a Two issues pointed out by Gary Peck:
*) Note that adding and removing frames from the ID3v2::Tag will invalidate
   iterators on the frame list
*) Correct the number of genres -- it should be 148 instead of 147.  You
   can all have your Synthpop genre back now.  :-)

CCMAIL:Gary Peck <gbpeck@sbcglobal.net>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@318067 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-06-06 00:10:58 +00:00
Scott Wheeler
05e484830c Don't die on invalid input.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@315934 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-05-29 20:12:36 +00:00
Scott Wheeler
9320aa0bbc Oops. Pretty significant type in the frame name for recording date. This
will automatically fix these files on the next write.  (At the moment other
taggers will not be able to read the date written by TagLib in the ID3v2 tag.
In most cases they'll fall back to the ID3v1 tag, which is fine, but still
kind of nasty.)  Thanks to Teemu Tervo for catching this.

CCMAIL:82038-done@bugs.kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@314024 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-05-24 07:37:41 +00:00
Scott Wheeler
3ca114a4ee Add a short description
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@310851 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-05-13 00:09:41 +00:00
Scott Wheeler
b29a821ed4 documentation fixes
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@310850 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-05-13 00:08:00 +00:00
Scott Wheeler
1770ffd35a Add a frameList() overload that accepts a frame ID as a shortcut to the
frameListMap().


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@310849 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-05-13 00:07:30 +00:00
Scott Wheeler
b9c9fd6c8d Added an example on how to read additional frames.
CCMAIL:Volker Wegert <mail@volker-wegert.de>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@309882 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-05-10 01:07:58 +00:00
Scott Wheeler
efd221e9b4 doxygen fix
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@309855 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-05-09 20:44:52 +00:00
Scott Wheeler
1be868b5b7 CVS_SILENT docs fix
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@309805 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-05-09 17:54:40 +00:00
Scott Wheeler
f9ca8cd69b Just a little hack to make the Vorbis classes appear in the Ogg namespace
in the API docs and a tyepdef to make this work (since this is how things
will be in the next BIC version).


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@309150 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-05-06 16:59:13 +00:00
Scott Wheeler
6a2cdbcc45 A small regression -- when assigning a ByteVector to a String make sure to
not include the trailing null characters.  (This was introduced after the
last release.)


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@309070 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-05-06 12:36:31 +00:00
Scott Wheeler
ceb989f170 Don't append a framing bit when writing Xiph comments to FLAC files since this
renders them unplayable with some players.  Thanks to Jason Lee for tracking
this down!

CCMAIL:75880-done@bugs.kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@308437 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-05-04 01:47:01 +00:00
Scott Wheeler
5895810131 Add docs.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306915 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-28 00:58:46 +00:00
Scott Wheeler
9e15659dbf Oops, the implementation of this constructor was missing.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306914 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-28 00:23:52 +00:00
Scott Wheeler
5091aa0b0c Add native support for the RVA2 (relative volume adjustment) frame. The
docs aren't there yet and this is completely untested, but that will follow
as soon as I find a file actually tagged with one of these.  :-)

CCMAIL:Jorn Baayen <jbaayen@gnome.org>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306706 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-27 02:01:27 +00:00
Scott Wheeler
de4bd42ef0 Add new type and templatize the "fromNumber" conversion.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306704 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-27 01:29:22 +00:00
Scott Wheeler
cf6506668d Oops. Make the docs accurate.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306703 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-27 01:21:30 +00:00
Scott Wheeler
237ea76ef6 Make this check current with the bytevector code.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306700 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-27 01:09:48 +00:00
Scott Wheeler
33bc1a1533 Changed my mind on the last one -- use explicit types rather than trying
to figure things out.  This also allows the number conversion to be
templatized.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306699 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-27 01:09:31 +00:00
Scott Wheeler
cfbc564bb6 Add a check for the toInt() stuff.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306691 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-26 23:05:36 +00:00
Scott Wheeler
31b46c03ac Add a toInt() method that correctly adjusts for the signedness bit even on
different variable sized byte vectors.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306690 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-26 23:00:21 +00:00
Scott Wheeler
8c2b1138ea Add direct support APIC (attached picture) frames. I'll probably add an
example to the examples dir later today showing how to use this.

CCMAIL:Matthias Welwarsky <matze@stud.fbi.fh-darmstadt.de>
CCMAIL:Jorn Baayen <jbaayen@gnome.org>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306452 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-26 08:49:02 +00:00
Scott Wheeler
940ac2cc3d Minor fix for getting the frame header size correct for unknown frames in
ID3v2.2 tags.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306417 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-26 01:18:37 +00:00
Scott Wheeler
4879eb8e6e CVS_SILENT make some stuff as deprecated
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@302723 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-10 23:28:54 +00:00
Scott Wheeler
6a1c3618ec Sadly reserve() just changes the capacity, not the actual size of the vector
so this didn't update the internal size of the std::vector...


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@302668 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-10 18:39:17 +00:00