34da0c0dab
Update signature and docs
...
Specifically this allows the frame to be constructed and then to have
the children and embedded frames set later.
2015-05-18 18:19:43 +02:00
7316cd331d
Remove the null termination stuff from the ToC frames too
2015-05-18 18:17:10 +02:00
3a977c55c4
We've moved away from including the null byte in the returned value
...
This does change previous behavior, but the previous behavior was
particularly stupid and inconsistent with everything else in TagLib.
It should be possible to mitigate this by putting the same safety
guards in the TableOfContents
2015-05-18 17:29:52 +02:00
a094ce7dd2
Don't underflow if there are no embedded frames
...
Closes #513
2015-05-18 17:11:18 +02:00
941efcba18
This isn't tracked as part of the elementID anymore
2015-05-18 16:53:12 +02:00
ffb543acbb
Split chapter data and embedded frame data
...
This will allow us to test parsing them separately
2015-05-18 16:45:57 +02:00
fc24b3d22b
Don't require users to include a padding byte explicitly
...
This makes it where the natural construction can be used of something
like:
new ChapterFrame("ID", ... )
Closes #514
2015-05-18 16:41:30 +02:00
a9e064c58e
Also test second constructor
2015-05-18 16:30:37 +02:00
1a5d89d29e
Update signature and docs to be more in-line with TagLib's style
2015-05-18 16:00:47 +02:00
650b581f9e
Merge pull request #544 from TsudaKageyu/advance
...
Use std::advance rather than a loop and increment.
2015-05-18 15:09:28 +02:00
0739dd232a
It doesn't make sense to set the factory after construction
...
Closes #259
2015-05-18 14:21:55 +02:00
41a250a15d
Make this macro work with current Qt versions
...
Closes #499
2015-05-18 12:42:24 +02:00
8da0013482
Add a test to check if an empty ID3v2 frame is really skipped.
2015-05-18 19:03:20 +09:00
0288059495
Add astylerc
2015-05-18 11:31:55 +02:00
6e40361c0e
Use std::advance rather than a loop and increment.
2015-05-18 09:31:43 +09:00
c2570fe115
Merge pull request #521 from TsudaKageyu/gcc-warning
...
Fix a GCC/Clang warning about singed/unsigned comparison.
2015-05-17 10:06:10 -07:00
bd91da55ba
Merge pull request #542 from TsudaKageyu/comment-typos
...
Fix some typos in comment.
2015-05-17 10:05:43 -07:00
3a3a6a6fda
Fix some typos in comment.
2015-05-18 00:31:46 +09:00
64c43b0d3f
Merge pull request #535 from FestusHagen/fh1.m_UintAmbiguity
...
Silenced uint ambiguity error.
2015-05-16 17:03:53 -07:00
db2dfa9515
Merge pull request #538 from gogglesmm/optimize-mid-to-uint
...
bytevector.mid(pos,4).toUInt() => bytevector.toUInt(pos)
2015-05-15 20:06:24 -07:00
0069debf0c
Merge pull request #536 from FestusHagen/fh1.m_CMakeSubProjectFix
...
Fix for using Taglib as a CMake sub directory project.
2015-05-15 19:48:43 -07:00
69563d83a0
Merge pull request #533 from TsudaKageyu/bytevector-resize
...
Fix the wrong padding of ByteVector::resize().
2015-05-15 19:43:38 -07:00
60775306ea
Fix code styling
2015-05-15 21:39:34 -05:00
4f77420248
replace use of bytevector.mid(pos,4).toUInt() with more optimized bytevector.toUInt(pos)
2015-05-15 21:25:44 -05:00
b021ed44e9
Revert the last two commits.
...
But leave the tests unchanged, and add some comments.
2015-05-16 11:16:00 +09:00
1f99c93a61
Reduce redundant memset when resizing ByteVector.
2015-05-16 03:46:34 +09:00
a924ca0db7
Expand the internal buffer of ByteVector only if really needed.
...
Add tests for all execution paths of ByteVector::resize().
2015-05-14 11:20:35 +09:00
e43c1a3c09
Fix for using Taglib as a CMake sub directory project.
2015-05-09 20:29:52 -04:00
1e9529380d
Silenced uint ambiguity error.
2015-05-09 14:19:33 -04:00
ff8443f33a
Fix the wrong padding of ByteVector::resize().
...
The expanded area will be filled with garbage instead of correct padding in some corner cases.
2015-05-02 02:43:08 +09:00
62ab41fa07
Merge pull request #532 from TsudaKageyu/bytevector-detach-test
...
A little robuster tests for ByteVector iterators after detaching.
2015-04-29 10:14:16 -07:00
00e3504264
A little robuster tests for ByteVector iterators after detaching.
2015-04-29 17:15:13 +09:00
852da79899
Merge pull request #531 from TsudaKageyu/bytevector-detach
...
Fix ByteVector to return correct iterators after detached.
2015-04-28 20:34:53 -07:00
ab047f6054
Fix ByteVector to return correct iterators after detached.
2015-04-29 10:28:08 +09:00
5bad35c4cb
Merge pull request #527 from TsudaKageyu/wma-guid
...
Fix saving WMA files with some GUID fields.
2015-04-28 10:42:06 -07:00
8d708c03e1
Store any GUID fields in Metadata Library Object.
2015-04-28 16:40:24 +09:00
f9a0b50830
Fix saving WMA files with some GUID fields.
2015-04-28 12:06:24 +09:00
8491266b12
Fix a GCC/Clang warning about singed/unsigned comparison.
2015-04-17 09:38:21 +09:00
066b5aa57e
Merge pull request #492 from TsudaKageyu/duplicate-id3v2-aiff-wav
...
Check AIFF/WAV files for duplicate tags.
2015-03-25 08:16:41 -04:00
5f0a7da481
Take into account the frame header version when skipping an empty frame.
2015-03-24 10:41:39 +09:00
d33d684fab
Discard empty ID3v2 frames instead of adding a dummy null byte.
2015-03-24 10:31:52 +09:00
4c4be0a263
Add a dummy byte to an empty ID3v2 frame to stick to the ID3v2 spec.
2015-03-22 22:14:21 +09:00
f476cf2b45
Merge pull request #511 from TsudaKageyu/tag-prop
...
Fix a bug that Tag::setProperties() clears the date instead of the track number
2015-03-20 10:28:20 +01:00
68c0b0591b
Fix a bug that Tag::setProperties() clears the date instead of the track number.
2015-03-20 13:33:13 +09:00
8fccaf30d2
Merge pull request #479 from TsudaKageyu/fuzzed-mp4
...
Fix an infinite loop when parsing MP4 files.
2015-02-18 08:15:50 -05:00
b69973bcf2
Fix infinite loops when parsing MP4 files.
2015-02-18 11:33:10 +09:00
30eac7569f
Check AIFF/WAV files for duplicate tags.
...
AIFF/WAV files can have duplicate tags and it leads to memory leak.
2015-02-18 11:31:55 +09:00
f6081ed32e
Merge pull request #505 from TsudaKageyu/fuzzed-ape-tests
...
Separate the tests for fuzzed APE files.
2015-02-17 09:22:35 +01:00
0839a23902
Separate the tests for fuzzed APE files.
2015-02-17 12:36:57 +09:00
f35a279dd1
Merge pull request #496 from TsudaKageyu/fuzzed-mpc
...
Some fixes for fuzzed MPC files.
2015-02-16 19:26:57 +01:00
