Commit Graph

2566 Commits

Author SHA1 Message Date
Allan Sandfeld Jensen
907c0fddb0 After making a simple enough test-case for Scott I was able to find the bug
myself.

Beware of the presedence of & !!

CCMAIL:wheeler@kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@301024 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-03 16:20:11 +00:00
Scott Wheeler
1b28af00a2 Add a constructor that takes an ID3v2::FrameFactory.
CCMAIL:Jonathan Giannuzzi <psyduck@altern.org>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@299846 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-03-30 13:50:26 +00:00
Scott Wheeler
067dc81f93 CVS_SILENT another nitpick
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@299843 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-03-30 13:45:24 +00:00
Scott Wheeler
f78cee2f24 I like it more like this...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@299835 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-03-30 13:12:18 +00:00
Scott Wheeler
d0d82ec6ea The explicit is silly here since it takes two arguments (it's leftover from
when this used to have a default argument).


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@296374 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-03-16 18:51:16 +00:00
Frerich Raabe
2ac52bceee - ByteVector::operator> seemed flawed to me
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@294934 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-03-10 13:06:14 +00:00
Scott Wheeler
d6aeb26c98 Use memcmp() and memcpy() where appropriate rather than slower loop based
methods.  Here this improves tag reading speed by about 50%.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@293774 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-03-05 15:59:00 +00:00
Scott Wheeler
8cd5093faa Hmm, not good -- missing "ref" here so that the reference count wasn't
being incremented on copy.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@292618 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-02-29 20:02:18 +00:00
Scott Wheeler
9a63f34627 Fix String::data() for UTF16 -- there was a missing break in the case
statement, so both the UTF16 and the UTF16BE versions were being executed.

CCMAIL:Ilya Konstantinov <future@shiny.co.il>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@290210 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-02-22 12:51:32 +00:00
Scott Wheeler
b23b37eb73 Oops, forgot a break...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@289657 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-02-20 11:42:14 +00:00
Scott Wheeler
e86abce07c Added a translation table between ID3v2.2 frame names and ID3v2.4. TagLib
now supports ID3v2.2 through ID3v2.4.

CCMAIL:Keith Brady <keith@funnelboy.org>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@289656 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-02-20 11:40:44 +00:00
Scott Wheeler
c22ee9d712 CVS_SILENT oops -- didn't mean to check this in
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@289568 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-02-20 01:42:10 +00:00
Scott Wheeler
619ef906cd Mostly get ID3v2.2 working. Sure, it's a standard from 1998 that was
replaced in 1999, but apparently iTunes still uses it.

This gets the frame parsing code to support 2.2 and required deprecating
a couple of methods so that an ID3v2 version could be passed along.

There still needs to be a translation table added to handle converting
ID3v2.2 frame names to their ID3v2.4 equivalents, but that can come later.
For now the framelister program from the examples dir is able to read all
of the text frames.

CCMAIL:Keith Brady <keith@funnelboy.org>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@289567 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-02-20 01:41:25 +00:00
Scott Wheeler
d21fa22260 Add a couple of testcases that point out UTF16 bugs.
CCMAIL:Ilya Konstantinov <future@shiny.co.il>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@288628 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-02-17 02:56:10 +00:00
Scott Wheeler
bfd0be4c7d Fixed problem with TagLib reading 1 byte fields in ID3v2 tags.
CCMAIL:Stefan Gehn <sgehn@gmx.net>
CCMAIL:Keith Brady <keith@funnelboy.org>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@288618 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-02-17 02:11:05 +00:00
Scott Wheeler
7fe6647435 This commit was manufactured by cvs2svn to accommodate
a server-side copy/move.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@288617 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-02-17 02:11:05 +00:00