mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2026-08-27 12:47:01 -04:00
Code Issues Packages Projects Releases Wiki Activity

Speex: do not convert out of range properties to int

Browse Source 
Same shape as Vorbis. The length comes from the difference between two
64 bit granule positions over a sample rate read from the Speex header,
so a file can declare 2^62 samples at 1 Hz. The millisecond length is
then ~4.6e21 and the conversion to int is undefined:

  taglib/ogg/speex/speexproperties.cpp:165:39: runtime error: 4.61169e+21
  is outside the range of representable values of type 'int'

The bitrate on the next line is reachable the other way round, with one
sample at a high declared rate making the divisor tiny:

  taglib/ogg/speex/speexproperties.cpp:166:39: runtime error: 3.61877e+13
  is outside the range of representable values of type 'int'

Leave the field at its default rather than converting.

Two reports before the change, none after. The 23 FLAC, APE, Ogg
Vorbis, Opus and Speex files in tests/data report identical channels,
sample rate, bitrate and length before and after, and the suite runs
576 tests either way.

Assisted-By: Claude Code (Claude Opus 5)
This commit is contained in:
manuaudio
2026-08-15 18:18:23 +02:00
committed by Urs Fleisch
parent 83e5427fe0
commit c3d4eef597
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
taglib/ogg/speex/speexproperties.cpp
+14 -2
View File
@@ -29,6 +29,8 @@
#include "speexproperties.h"
#include <limits>
#include "tstring.h"
#include "tdebug.h"
#include "oggpageheader.h"
@@ -162,8 +164,18 @@ void Speex::Properties::read(File *file)
for (unsigned int i = 0; i < 2; ++i) {
fileLengthWithoutOverhead -= file->packet(i).size();
}
d->length = static_cast<int>(length + 0.5);
d->bitrate = static_cast<int>(static_cast<double>(fileLengthWithoutOverhead) * 8.0 / length + 0.5);
// The granule positions are 64 bit and the sample rate is read from the
// file, so the millisecond length can land outside int, and a short
// stream at a high rate does the same to the bitrate. Converting a
// double the destination type cannot represent is undefined, so leave
// the field at its default instead.
if(length > 0.0 && length < static_cast<double>(std::numeric_limits<int>::max())) {
d->length = static_cast<int>(length + 0.5);
const double bitrate = static_cast<double>(fileLengthWithoutOverhead) * 8.0 / length;
if(bitrate >= 0.0 && bitrate < static_cast<double>(std::numeric_limits<int>::max()))
d->bitrate = static_cast<int>(bitrate + 0.5);
}
}
}
else {