mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-05-27 21:20:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

simplify boolean expressions (#1130)

Browse Source 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2023-09-06 12:16:59 -07:00 committed by GitHub
parent 54f84cc924
commit 912897cd35
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
taglib/mp4/mp4tag.cpp
View File

@ -231,7 +231,7 @@ MP4::Tag::parseBool(const MP4::Atom *atom)
{
ByteVectorList data = parseData(atom);
if(!data.isEmpty()) {
bool value = data[0].size() ? data[0][0] != '\0' : false;
bool value = !data[0].isEmpty() && data[0][0] != '\0';
addItem(atom->name, value);
}
}

2
taglib/ogg/oggpage.cpp
View File

@ -309,7 +309,7 @@ List<Ogg::Page *> Ogg::Page::paginate(const ByteVectorList &packets,
streamSerialNumber,
pageIndex,
continued,
lastSplit && (lastPacketInList ? lastPacketCompleted : true),
lastSplit && (!lastPacketInList || lastPacketCompleted),
lastSplit && (containsLastPacket && lastPacketInList)));
pageIndex++;
continued = true;

4
taglib/tag.cpp
View File

@ -63,9 +63,9 @@ PropertyMap Tag::properties() const
map["COMMENT"].append(comment());
if(!(genre().isEmpty()))
map["GENRE"].append(genre());
if(!(year() == 0))
if(year() != 0)
map["DATE"].append(String::number(year()));
if(!(track() == 0))
if(track() != 0)
map["TRACKNUMBER"].append(String::number(track()));
return map;
}