mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2026-08-27 12:47:01 -04:00
Code Issues Packages Projects Releases Wiki Activity

MPC: guard SV7 property conversions (#1423)

Browse Source 
SV7 derives the audio length and bitrate from file-controlled frame
counts and stream length. A crafted stream can make the derived bitrate
exceed the int property range, so converting it is undefined.
Guard the SV7 conversions, and account for rounding when checking the
existing SV8 conversions.
This commit is contained in:
Acts1631
2026-08-18 06:59:51 +02:00
committed by GitHub
parent 8a78c5e5bd
commit 7f2964ab8b
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
taglib/mpc/mpcproperties.cpp
+12 -5
View File
@@ -245,11 +245,13 @@ void MPC::Properties::readSV8(File *file, offset_t streamLength)
// undefined. Leave the fields at their defaults rather than converting.
const auto length = static_cast<double>(frameCount) * 1000.0 / d->sampleRate;
if(length > 0.0 && length < static_cast<double>(std::numeric_limits<int>::max())) {
if(length > 0.0 &&
length + 0.5 <= static_cast<double>(std::numeric_limits<int>::max())) {
d->length = static_cast<int>(length + 0.5);
const double bitrate = static_cast<double>(streamLength) * 8.0 / length;
if(bitrate >= 0.0 && bitrate < static_cast<double>(std::numeric_limits<int>::max()))
if(bitrate >= 0.0 &&
bitrate + 0.5 <= static_cast<double>(std::numeric_limits<int>::max()))
d->bitrate = static_cast<int>(bitrate + 0.5);
}
}
@@ -350,9 +352,14 @@ void MPC::Properties::readSV7(const ByteVector &data, offset_t streamLength)
if(d->sampleFrames > 0 && d->sampleRate > 0) {
const auto length = static_cast<double>(d->sampleFrames) * 1000.0 / d->sampleRate;
d->length = static_cast<int>(length + 0.5);
if(length + 0.5 <= static_cast<double>(std::numeric_limits<int>::max())) {
d->length = static_cast<int>(length + 0.5);
if(d->bitrate == 0)
d->bitrate = static_cast<int>(static_cast<double>(streamLength) * 8.0 / length + 0.5);
if(d->bitrate == 0) {
const double bitrate = static_cast<double>(streamLength) * 8.0 / length;
if(bitrate + 0.5 <= static_cast<double>(std::numeric_limits<int>::max()))
d->bitrate = static_cast<int>(bitrate + 0.5);
}
}
}
}