mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2026-04-12 17:09:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix/shorten rice golomb k bounds (#1335)

Browse Source 
* Shorten: Reject out-of-range k in getRiceGolombCode

k values outside [0, 31] cause undefined behavior: a left shift by 32
on int32_t (UB in C++) when bitsAvailable reaches 32 after a buffer
refill. Guard against this at the top of getRiceGolombCode and return
false (invalid file) for any k outside the valid range.

* Shorten: Reject out-of-range k in getRiceGolombCode

k values outside [0, 31] cause undefined behavior: a left shift by 32
on int32_t (UB in C++) when bitsAvailable reaches 32 after a buffer
refill. Guard against this at the top of getRiceGolombCode and return
false (invalid file) for any k outside the valid range.
This commit is contained in:
Ryan Francesconi
2026-04-09 13:03:36 -07:00
committed by GitHub
parent 4da5ac2de4
commit 13751f5a6b
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
taglib/shorten/shortenfile.cpp
View File

@ -104,6 +104,11 @@ namespace {
bool VariableLengthInput::getRiceGolombCode(int32_t &i32, int32_t k)
{
// k must be in [0, 31]: values outside this range would cause shift-by-32
// (UB for int32_t) or negative shifts, and are invalid for this format.
if(k < 0 || k > 31)
return false;
static constexpr uint32_t sMaskTable[] = {
0x0,
0x1, 0x3, 0x7, 0xf,