mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-05-27 21:20:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove the body of deprecated function Ogg::Page::getCopyWithNewPageSequenceNumber().

Browse Source
This commit is contained in:
Tsuda Kageyu 2016-01-28 12:00:27 +09:00
parent fe92f3dffe
commit 0b62ba1530
3 changed files with 5 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
NEWS
View File

@ -29,6 +29,7 @@
* Marked ByteVector::null and ByteVector::isNull() deprecated.
* Marked String::null and ByteVector::isNull() deprecated.
* Marked XiphComment::removeField() deprecated.
* Marked Ogg::Page::getCopyWithNewPageSequenceNumber() deprecated. It returns null.
* Marked custom integer types deprecated.
* Many smaller bug fixes and performance improvements.

23
taglib/ogg/oggpage.cpp
View File

@ -269,27 +269,10 @@ List<Ogg::Page *> Ogg::Page::paginate(const ByteVectorList &packets,
return l;
}
Ogg::Page* Ogg::Page::getCopyWithNewPageSequenceNumber(int sequenceNumber)
Ogg::Page* Ogg::Page::getCopyWithNewPageSequenceNumber(int /*sequenceNumber*/)
{
Page *pResultPage = NULL;
// TODO: a copy constructor would be helpful
if(d->file == 0) {
pResultPage = new Page(
d->packets,
d->header.streamSerialNumber(),
sequenceNumber,
d->header.firstPacketContinued(),
d->header.lastPacketCompleted(),
d->header.lastPageOfStream());
}
else
{
pResultPage = new Page(d->file, d->fileOffset);
pResultPage->d->header.setPageSequenceNumber(sequenceNumber);
}
return pResultPage;
debug("Ogg::Page::getCopyWithNewPageSequenceNumber() -- This function is obsolete. Returning null.");
return 0;
}
////////////////////////////////////////////////////////////////////////////////

2
taglib/ogg/oggpage.h
View File

@ -91,7 +91,7 @@ namespace TagLib {
* \see header()
* \see PageHeader::setPageSequenceNumber()
*
* \deprecated
* \deprecated Always returns null.
*/
Page* getCopyWithNewPageSequenceNumber(int sequenceNumber);