mirror/sointu
1
0
Fork 0
mirror of https://github.com/vsariola/sointu.git synced 2025-05-28 03:10:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(tracker): ReadInstrument forgot to close the file

Browse Source
This commit is contained in:
5684185+vsariola@users.noreply.github.com 2025-01-25 22:18:28 +02:00
parent dd7b5ddc84
commit 5ee7e44ed7
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -45,6 +45,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
be computed every draw. ([#176][i176]) be computed every draw. ([#176][i176])
### Fixed ### Fixed
- Loading instrument forgot to close the file (in model.ReadInstrument)
- We try to honor the MIDI event time stamps, so that the timing between MIDI - We try to honor the MIDI event time stamps, so that the timing between MIDI
events (as reported to us by RTMIDI) will be correct. events (as reported to us by RTMIDI) will be correct.
- When unmarshaling the recovery file, the unit parameter maps were "merged" - When unmarshaling the recovery file, the unit parameter maps were "merged"

1
tracker/files.go
View File

@ -136,6 +136,7 @@ func (m *Model) LoadInstrument(r io.ReadCloser) bool {
if err != nil { if err != nil {
return false return false
} }
r.Close() // if we can't close the file, it's not a big deal, so ignore the error
var instrument sointu.Instrument var instrument sointu.Instrument
var errJSON, errYaml, err4ki, err4kp error var errJSON, errYaml, err4ki, err4kp error
var patch sointu.Patch var patch sointu.Patch