mirror of
				https://github.com/vsariola/sointu.git
				synced 2025-11-04 00:45:35 -05:00 
			
		
		
		
	fix(tracker): ReadInstrument forgot to close the file
This commit is contained in:
		
						parent
						
							dd7b5ddc84
						
					
				
				
					commit
					5ee7e44ed7
				
			@ -45,6 +45,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 | 
			
		||||
  be computed every draw. ([#176][i176])
 | 
			
		||||
 | 
			
		||||
### Fixed
 | 
			
		||||
- Loading instrument forgot to close the file (in model.ReadInstrument)
 | 
			
		||||
- We try to honor the MIDI event time stamps, so that the timing between MIDI
 | 
			
		||||
  events (as reported to us by RTMIDI) will be correct.
 | 
			
		||||
- When unmarshaling the recovery file, the unit parameter maps were "merged"
 | 
			
		||||
 | 
			
		||||
@ -136,6 +136,7 @@ func (m *Model) LoadInstrument(r io.ReadCloser) bool {
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		return false
 | 
			
		||||
	}
 | 
			
		||||
	r.Close() // if we can't close the file, it's not a big deal, so ignore the error
 | 
			
		||||
	var instrument sointu.Instrument
 | 
			
		||||
	var errJSON, errYaml, err4ki, err4kp error
 | 
			
		||||
	var patch sointu.Patch
 | 
			
		||||
 | 
			
		||||
		Reference in New Issue
	
	Block a user