mirror/kissfft
1
0
Fork 0
mirror of https://github.com/mborgerding/kissfft.git synced 2026-08-30 22:07:01 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix high severity Coverity finding:

Browse Source 
CWE-119 (Out-of-bounds access)
(https://cwe.mitre.org/data/definitions/119.html)
This commit is contained in:
Erno Kilpelainen
2026-06-05 10:44:56 +00:00
parent 4c5d176b0d
commit ab79e61148
1 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/kiss_fastfir.c
+21 -2
View File
@@ -466,12 +466,31 @@ int main(int argc,char**argv)
exit(1); exit(1);
} }
fseek(filtfile,0,SEEK_END); fseek(filtfile,0,SEEK_END);
nh = ftell(filtfile) / sizeof(kffsamp_t); {
long filt_bytes = ftell(filtfile);
if (filt_bytes < 0) {
fprintf(stderr,"could not determine filter file size\n");
exit(1);
}
if ((size_t)filt_bytes < sizeof(kffsamp_t)) {
fprintf(stderr,"filter file too small\n");
exit(1);
}
nh = (size_t)filt_bytes / sizeof(kffsamp_t);
}
if (verbose) fprintf(stderr,"%d samples in FIR filter\n",(int)nh); if (verbose) fprintf(stderr,"%d samples in FIR filter\n",(int)nh);
h = (kffsamp_t*)malloc(sizeof(kffsamp_t)*nh); h = (kffsamp_t*)malloc(sizeof(kffsamp_t)*nh);
if (h == NULL) {
fprintf(stderr,"failed to allocate filter coefficients\n");
exit(1);
}
fseek(filtfile,0,SEEK_SET); fseek(filtfile,0,SEEK_SET);
if (fread(h,sizeof(kffsamp_t),nh,filtfile) != nh) if (fread(h,sizeof(kffsamp_t),nh,filtfile) != nh)
fprintf(stderr,"short read on filter file\n"); {
fprintf(stderr,"short read on filter file\n");
free(h);
exit(1);
}
fclose(filtfile); fclose(filtfile);