From ab79e611488514e6212488288672001138126a42 Mon Sep 17 00:00:00 2001
From: Erno Kilpelainen <erno.kilpelainen@kone.com>
Date: Fri, 5 Jun 2026 10:44:56 +0000
Subject: [PATCH] Fix high severity Coverity finding: CWE-119 (Out-of-bounds
 access) (https://cwe.mitre.org/data/definitions/119.html)

---
 tools/kiss_fastfir.c | 23 +++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

diff --git a/tools/kiss_fastfir.c b/tools/kiss_fastfir.c
index e066328..b7499ec 100644
--- a/tools/kiss_fastfir.c
+++ b/tools/kiss_fastfir.c
@@ -466,12 +466,31 @@ int main(int argc,char**argv)
         exit(1);
     }
     fseek(filtfile,0,SEEK_END);
-    nh = ftell(filtfile) / sizeof(kffsamp_t);
+    {
+        long filt_bytes = ftell(filtfile);
+        if (filt_bytes < 0) {
+            fprintf(stderr,"could not determine filter file size\n");
+            exit(1);
+        }
+        if ((size_t)filt_bytes < sizeof(kffsamp_t)) {
+            fprintf(stderr,"filter file too small\n");
+            exit(1);
+        }
+        nh = (size_t)filt_bytes / sizeof(kffsamp_t);
+    }
     if (verbose) fprintf(stderr,"%d samples in FIR filter\n",(int)nh);
     h = (kffsamp_t*)malloc(sizeof(kffsamp_t)*nh);
+    if (h == NULL) {
+        fprintf(stderr,"failed to allocate filter coefficients\n");
+        exit(1);
+    }
     fseek(filtfile,0,SEEK_SET);
     if (fread(h,sizeof(kffsamp_t),nh,filtfile) != nh)
-        fprintf(stderr,"short read on filter file\n");
+        {
+            fprintf(stderr,"short read on filter file\n");
+            free(h);
+            exit(1);
+        }
 
     fclose(filtfile);