Compare commits

...

4 Commits

Author SHA1 Message Date
52c7839741 Initialize variable to silence warning [-Wsometimes-uninitialized]
It's uninitialized if the else {} is hit.
2015-05-02 23:32:24 +01:00
3dadfa564d Upgrade ECM and KF5 version requirements for 5.10.0 release. 2015-05-01 15:17:27 +00:00
0414b32297 Upgrade ECM and KF5 version requirements for 5.9.0 release. 2015-04-04 11:48:54 +00:00
55af097749 Don't warn the user/developer about something he can't fix
image formats are loaded via qimage/qimagereader and friends, the user/developer does not choose which ones will be used so giving him a warning about sequential devices not being supported is not going to help anyone, only spam their shell/logs.

REVIEW: 123156
Acked by David Edmundson
2015-03-29 23:21:17 +02:00
3 changed files with 3 additions and 3 deletions

View File

@ -2,7 +2,7 @@ cmake_minimum_required(VERSION 2.8.12)
project(KImageFormats)
find_package(ECM 1.8.0 REQUIRED NO_MODULE)
find_package(ECM 5.10.0 REQUIRED NO_MODULE)
set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH} ${ECM_KDE_MODULE_DIR})

View File

@ -219,7 +219,7 @@ bool RASHandler::canRead(QIODevice *device)
}
if (device->isSequential()) {
qWarning("Reading ras files from sequential devices not supported");
// qWarning("Reading ras files from sequential devices not supported");
return false;
}

View File

@ -86,7 +86,7 @@ static inline bool decodeRLEData(RLEVariant variant,
stream >> count1;
if (count1 >= 128u) {
unsigned length;
unsigned length = 0;
if (variant == RLEVariant::PIC) {
if (count1 == 128u) {
// If the value is exactly 128, it means that it is more than