Commit Graph

809 Commits

Author SHA1 Message Date
a0dfa4e447 Limit max cover height
Otherwise we can end with huge cover files if the source content has abnormally tall covers. This large files could end exhausting RAM in the iOS client.
2022-08-29 20:04:00 +02:00
c37bc33161 Update properties dialog to be able to edit comics sequentially 2022-08-26 21:05:26 +02:00
769214fe5c Watch for potential empty proxy model 2022-08-21 08:59:53 +02:00
7df011e181 Add an edit for filtering series results returned by Comic Vine 2022-08-18 16:22:07 +02:00
8b4b586acc Show the automatic volume text that is going to be used in comic vine dialog
The user can chose to use it or edit it before starting the search.
2022-08-18 14:35:25 +02:00
160604040e Empty titles should be nulls in the db 2022-08-13 16:10:00 +02:00
59ff02631e Fix comic number missing from reading lists content provided through the server 2022-08-09 16:42:18 +02:00
788a3ef434 Update simplified Chinese.
Add traditional Chinese (Hong Kong, Taiwan).
2022-07-06 15:54:54 +02:00
4c54f2a07c Fix clicking on the folders treeview when it shown results from search
This was a bug introduced when support for folder navigation using the keyboard was added.
2022-03-28 22:32:52 +02:00
9e9f035f35 Use Qt::HighDpiScaleFactorRoundingPolicy::PassThrough
It will be the default in Qt6 and respecting the scale factor that the user sets is the right thing to do.
2022-03-12 11:51:29 +01:00
f27de78fe1 Fix grid cell selection border
Moving the DropShadow broke things in Qt5.15
2022-02-20 18:02:11 +01:00
72670ea6c8 Move connections to happen later
Otherwise QQuickItem(s) don't work properly in Qt6. I couldn't find the root cause.
2022-01-19 21:13:53 +01:00
f48201fb91 Initialize fields to nullptr 2022-01-19 21:12:37 +01:00
2d741140e6 Add nullptr check 2022-01-19 21:12:26 +01:00
4bb227aff2 Fix trace message 2022-01-19 21:12:00 +01:00
1b54a407b8 Move common initialization code to the parent class 2022-01-19 19:16:27 +01:00
ab927d791b Avoid code duplication 2022-01-19 18:30:38 +01:00
8d0beee195 Use parent instead of id 2022-01-19 18:29:09 +01:00
24ad06e839 Remove icon 2022-01-19 18:28:49 +01:00
d73a9a2207 Move DropShadow block 2022-01-19 18:28:38 +01:00
26b4a85928 Rename id 2022-01-19 18:27:22 +01:00
6892a28d0a Check for undefined and null values in QML
Conditional chaining is not available in Qt5.15, so this is uglier than it should be.
2022-01-19 18:24:29 +01:00
68dbd90413 Update listeners definitions 2022-01-19 18:22:04 +01:00
1a25fd0740 Update listeners definitions 2022-01-19 18:20:05 +01:00
f3e08a04d7 Add some initial values for context variables 2022-01-19 18:17:53 +01:00
27383da945 Configure the initial size of the covers 2022-01-19 18:17:04 +01:00
59ae6c5e51 Extract method 2022-01-19 18:16:13 +01:00
2ae9b83bbf Make sure that opengl is used
QQuickWidget requires opengl.
2022-01-19 18:15:36 +01:00
b841aff4a3 Wrap booleans in QVariant when updating the qml context 2022-01-19 18:14:29 +01:00
768d7ee73c Set initial dummy values for some context references 2022-01-19 18:13:20 +01:00
e80f5a9f64 Move common initialization to the parent class 2022-01-19 18:12:40 +01:00
77c96de0ea Remove unused resources 2022-01-15 15:51:59 +01:00
565bc3a5d0 Replace all uses of devicePixelRatio with devicePixelRatioF 2022-01-14 19:22:50 +01:00
a1e0340b3d Fix some warnings 2021-12-29 17:58:40 +01:00
d8f224645d Remove YACReader::SearchModifiers
They are no longer used
2021-12-29 14:58:03 +01:00
ea2c90011a Library: exit search mode before creating a folder
Creating a folder in search mode selects it and makes the UI look
half-way between Normal and Searching navigation statuses.

An alternative fix is to disable addFolderAction in search mode. But
this is more difficult to implement and inconsistent with the other
always-enabled folder and reading list actions.
2021-12-29 11:02:01 +01:00
40ca07f8f8 Extract YACReaderNavigationController::exitSearchMode() 2021-12-29 11:01:35 +01:00
61cd245037 Document ConcurrentQueue and de-inline its implementation
ConcurrentQueue is currently used only by two classes and a test, but
modifying concurrent_queue.h requires recompiling 30 source files. None
of the member functions is so lightweight as to make it worth inlining.

An alternative to `@note ConcurrentQueue is unable to execute jobs if
@p threadCount == 0.` is `assert(threadCount != 0);`. But this would
force classes that contain a ConcurrentQueue data member to always start
a thread, even if they detect at runtime that they are never going to
enqueue a job.

Add Job type alias to avoid repeating the type.

Use default member initializers instead of the member initializer list
to make it clear [to the reader of the header] that no data member is
left uninitialized.
2021-12-29 09:36:44 +01:00
228fe1284e Fix a typo in ConcurrentQueue::cancelPending function name 2021-12-29 09:36:44 +01:00
b0b0849cbc Extract DEFINES += NOMINMAX into common config.pri 2021-12-29 09:36:44 +01:00
040883a107 Fix static assert when compiling with Qt 6.2.2
QtConcurrent::run doesn't like that reference anymore
2021-12-28 17:48:35 +01:00
55f7c4e1b0 Modify the scale of the cell on mouse over
This will differentiate the mouse over accent vs the selection accent
2021-12-27 16:25:43 +01:00
88de0ae25a Add publication date to the classic comics view table 2021-12-26 20:26:16 +01:00
2cb20cd11e Remove commented code 2021-12-26 20:23:32 +01:00
62464a450c Fix method overriding 2021-12-26 20:22:35 +01:00
868c6aa269 Use the new signal to trigger YACReaderNavigationController::selectedFolder 2021-12-26 17:33:04 +01:00
e882ad272b Qt.labs.animation is not used yet 2021-11-07 09:31:23 +01:00
2d533949f4 Remove duplicate variables from YACReaderLibrary.pro 2021-11-02 11:02:32 +01:00
6aeed9ae90 Include some missing headers 2021-11-02 11:02:32 +01:00
1c3fd4d16f Do not pass MSVC arguments to mingw/gcc 2021-11-02 11:02:32 +01:00