Commit Graph

1982 Commits

Author SHA1 Message Date
Luis Ángel San Martín
4608c9bb03
Merge pull request #6 from selmf/9.5.0_bugfixes
9.5.0 bugfixes
2018-05-31 18:14:41 +02:00
Luis Ángel San Martín
1a91206a2d
Merge branch 'develop' into 9.5.0_bugfixes 2018-05-31 18:12:52 +02:00
Luis Ángel San Martín
229afbc9a9 Fix crash caused by accessing the UI thread from a background thread.
ComicVineDialog was calling close from background, plus accepted is emmited from a background thread, so it needs a QueuedConnection.
2018-05-31 18:09:41 +02:00
Luis Ángel San Martín
26c2226032 Change endpoints for getting comic info and opening a comic. 2018-05-30 19:23:39 +02:00
Luis Ángel San Martín
0100da5480 Make comicdownloadinfocontroller_v2 provide all the needed information. 2018-05-30 19:02:52 +02:00
Luis Ángel San Martín
dba264c31f Remove old commented code. 2018-05-29 17:12:34 +02:00
Luis Ángel San Martín
79db01cffc Do not close the connection in librariescontroller_v2 2018-05-29 17:12:22 +02:00
Luis Ángel San Martín
550795e418 Do not close the connection in covercontroller_v2 2018-05-29 17:12:09 +02:00
Luis Ángel San Martín
9cc4f65fc8 Use older api currentSecsSinceEpoch was introduced in Qt 5.8 2018-05-28 21:18:11 +02:00
Felix Kauselmann
0cc6b3bcf7 SendComic: Connect finished signal to deleteLater slot BEFORE the finished
signal is emitted so it is actually processed and we don't get dangling pointers.

Use modern signal slot syntax so that the compiler and source check tools can
verify we actually fixed the problem.
2018-05-26 12:43:03 +02:00
Felix Kauselmann
f7e2547531 Options dialog: Add default case to FlowType switch case to prevent undefined behaviour (just in case) 2018-05-26 12:11:30 +02:00
Felix Kauselmann
1ccb40624c Remove potential memleak in folder model code 2018-05-26 11:32:59 +02:00
Felix Kauselmann
ca3bc94f25 Fix potential memleak caused by unused QAction pointer in SortVolumeComics 2018-05-26 11:09:28 +02:00
Felix Kauselmann
9851884021 Backport two nullpointer reference fixes from QtWebApp 1.7.4 2018-05-26 10:30:14 +02:00
Luis Ángel San Martín
1c4eb4d1c6 Fix comicRating possition after context menu workaround 2018-05-25 19:31:32 +02:00
Luis Ángel San Martín
1cd33197cc Set hasBeenOpened as true if currentPage > 1
I have seen comics opened with hasBeenOpened to false.
2018-05-25 19:28:20 +02:00
Luis Ángel San Martín
d909598732 Add missing include.
This fixes compilation windows debug.
2018-05-25 19:26:17 +02:00
Luis Ángel San Martín
786c28bba0 Add workaround for rating context menu crashing in macos
For now we will have two different versions of the rating component.
2018-05-24 19:02:01 +02:00
Luis Ángel San Martín
59604218f4 Update gitignore. 2018-05-24 19:00:54 +02:00
Luis Ángel San Martín
6faea2b5a7 Disabled minimize to system tray for now.
App icon needs some work to look ok in Windows 10 system tray and macos is not ready yet to fully support this.
2018-05-23 17:24:04 +02:00
Luis Ángel San Martín
a8655b1037 All lists should load the coverSizeRatio 2018-05-22 18:58:33 +02:00
Luis Ángel San Martín
450997762e Current comic view only makes sense for folders and reading lists. 2018-05-22 18:45:12 +02:00
Luis Ángel San Martín
4be84c6845 Set TraceLevel for logging only in debug builds. 2018-05-22 18:16:55 +02:00
Luis Ángel San Martín
66d1bd1046 Merge branch 'server_2.0' into develop 2018-05-22 18:10:24 +02:00
Luis Ángel San Martín
1ea10bc86b
Merge pull request #2 from selmf/qml_logger
Add a simple qml error logger to YACReaderLibrary
2018-05-22 17:54:52 +02:00
Luis Ángel San Martín
317f2b839f Remove setting last time opened.
The value should come from the client.
2018-05-21 23:14:51 +02:00
Luis Ángel San Martín
1b63dc01db Remove comment. 2018-05-21 23:14:12 +02:00
Luis Ángel San Martín
66aa2c60c6 Fix comparison 2018-05-21 23:14:02 +02:00
Luis Ángel San Martín
8ea201ece9 Use usigned long long to fix compiler error 2018-05-21 23:13:47 +02:00
Luis Ángel San Martín
e77d613002 Update last time opened when updating reading progress from ios client. 2018-05-21 22:13:07 +02:00
Luis Ángel San Martín
38e3b40e8f Process last time opened in sync controller 2018-05-21 22:10:53 +02:00
Luis Ángel San Martín
d6c563e881 If a comic doesn't have library and id info, then try to update the info in all the libraries. 2018-05-21 19:52:29 +02:00
Luis Ángel San Martín
6cfd09a8b8 Add method for updating reading comic information given a hash. 2018-05-21 19:51:30 +02:00
Luis Ángel San Martín
0e4ffb15a6 Fix update from remote client.
current page has to be set before checking for read.
2018-05-21 19:50:28 +02:00
Luis Ángel San Martín
8d60659a4d updated gitignore 2018-05-21 18:54:10 +02:00
Felix Kauselmann
15e5618454 Add a simple qml error logger to YACReaderLibrary 2018-05-21 15:16:20 +02:00
Luis Ángel San Martín
5c876e6785 Make YACReader send info for the next comic.
Now we can set the next comic as reading.
2018-05-20 17:43:28 +02:00
Luis Ángel San Martín
50c9238376 Only try to set the next comic as read if there is a next comic. 2018-05-20 17:42:49 +02:00
Luis Ángel San Martín
c97bc6ef88 Fix determining if we are in double page or not. 2018-05-20 17:39:08 +02:00
Luis Ángel San Martín
c93e86af12 Fix loading some missing fields from database 2018-05-20 15:33:11 +02:00
Luis Ángel San Martín
c9f703b6f7 Revert "Fixed wrong index asigned to current page from the viewer"
This reverts commit 26fdb5a303.
2018-05-20 15:19:48 +02:00
Luis Ángel San Martín
e405f14256 Set next comic as reading from update comic controller. 2018-05-20 14:49:32 +02:00
Luis Ángel San Martín
1503fe5383 Add method for marking a comic as reading without opening it first.
Usefull when closing the a comic in the last page to mark the next one and the next being readed.
2018-05-20 14:49:07 +02:00
Luis Ángel San Martín
45e44fa54f Only set a comic as reading if it has been opened beyod the cover. 2018-05-20 14:48:08 +02:00
Luis Ángel San Martín
82cfdfdf30 YACReader should be dummy about has been opened.
It should only send back information, hasBeenOpened will be set in YACReaderLibrary depending on various factors.
2018-05-20 14:43:19 +02:00
Luis Ángel San Martín
23823725ac Fix how we consider a comic as being read.
Basically is this: it has been opened and not set as READ.
2018-05-20 14:41:55 +02:00
Luis Ángel San Martín
26fdb5a303 Fixed wrong index asigned to current page from the viewer 2018-05-20 14:40:07 +02:00
Luis Ángel San Martín
d3bb598a7d Add controllers to provide comics information from reading lists and labels 2018-05-01 11:54:00 +02:00
Luis Ángel San Martín
0e45767e67 Check for comic opening failures before trying to serve a page. 2018-04-28 18:00:40 +02:00
Luis Ángel San Martín
618f6575b2 Fix error code in page controller 2018-04-28 17:57:06 +02:00