Commit Graph

2426 Commits

Author SHA1 Message Date
117b02fc7f Merge pull request #192 from vedgy/fix-info-comics-view-crashes
Library: fix InfoComicsView crashes
2021-02-01 18:38:50 +01:00
f88af80379 Library: fix InfoComicsView crashes
InfoComicsView constructor is the only function that connects to
FlowView's currentCoverChanged signal. Neither of the slots connected to
this signal handles the argument value index==-1. So when FlowView emits
this signal with index==-1, YACReaderLibrary crashes. Returning early
from either ComicsView::updateInfoForIndex() or
InfoComicsView::setCurrentIndex() when index==-1 is not sufficient - the
crash happens in the other slot then. Let us skip emitting the signal in
FlowView if index==-1 rather than return early from both slots.

Steps to reproduce 1:
1. Launch YACReaderLibrary version that matches the version of the
default library database. Alternatively, select a compatible library
after starting the application.
2. If InfoComicsView is not active, switch to it.
3. (optional) Switch to another comics view out of InfoComicsView.
4. Quit YACReaderLibrary. The application crashes during exit - after
the "YACReaderLibrary closed with exit code : 0" message is printed.

Steps to reproduce 2:
1. Launch a YACReaderLibrary version newer than the version of the
default library database.
2. Click the "No" button in the "Update needed" dialog that pops up.
3. Change between comics views until InfoComicsView becomes active. If
this view was active at the beginning, switch through all the views to
get back to it. At this point YACReaderLibrary crashes.
2021-02-01 11:27:18 +02:00
350234b099 Merge pull request #187 from YACReader/feature/fix-server-start-up-sequence
Fix launch sequence to avoid http port collisions
2021-01-28 21:04:49 +01:00
f4b2b3d8e3 Update comments 2021-01-28 19:56:35 +01:00
64478ca63f Typo 2021-01-28 19:54:10 +01:00
d96d01d963 Fix launch sequence to avoid http port collisions 2021-01-25 15:48:15 +01:00
f183fc1dd2 Fallback to a text close button if we can't load the svg image
If the svg plugin is missing the user can't see where the close button is
2021-01-22 16:35:58 +01:00
3a6fb91327 Install libqt5svg5-dev package in linux 2021-01-22 11:22:05 +01:00
74840f9914 Enable SVG explicitly 2021-01-22 10:48:13 +01:00
b80d85a49e Merge pull request #186 from YACReader/feature/whatsnew
Add what's new dialog
2021-01-21 23:28:08 +01:00
5c48fe5783 format 2021-01-21 22:31:56 +01:00
58fdf0af23 Add what's new dialog 2021-01-21 21:39:22 +01:00
3f6c44ce7a Fix SQL update query for setting manga in all the comics in a folder 2021-01-17 14:05:14 +01:00
710e9d9026 Merge pull request #176 from smalewski/develop
Fixes move action shortcuts not working
2021-01-17 11:45:32 +01:00
679bd1812f Update CHANGELOG 2021-01-17 11:44:38 +01:00
dee557c518 Use a constant reference for passing QKeySequence to moveAction 2021-01-17 11:11:25 +01:00
08ce8c3c65 Fixed move action shortcuts 2021-01-17 11:06:45 +01:00
c73f28cca1 KeySequence passed by reference 2021-01-17 11:06:45 +01:00
fccf9ab0af Fixed shortcuts for move actions 2021-01-17 11:06:45 +01:00
77bfd58c35 Merge pull request #185 from YACReader/feature/improve_manga_support
feature: improve manga support
2021-01-17 10:13:44 +01:00
20c772797b Fix typo 2021-01-16 18:59:53 +01:00
a911a4fc53 Update action names in macos menus 2021-01-16 18:45:47 +01:00
bb1996fb2d Update CHANGELOG 2021-01-16 18:33:13 +01:00
6461a4014e Add actions for setting folders as manga/normal 2021-01-16 18:31:48 +01:00
d402999991 Set all new imported comics and folders as manga if the parent folder is manga 2021-01-16 18:31:13 +01:00
60de69635b Get/set new manga field from/to the db 2021-01-16 18:30:25 +01:00
f7fa4adbd0 Add manga field to folders too
This way we can tell the app that a folder contains mangas so the user doesn't have to constantly set comics as manga when new issues are added. And it should be easier to set all the content in a folder as manga from the folder tree.
2021-01-16 18:29:22 +01:00
2a3f7668ba Rename method 2021-01-16 18:27:16 +01:00
a077434c78 Update CHANGELOG 2021-01-16 15:04:20 +01:00
d07de8fb2e Rename prev/next actions to reflect its positional behaviour 2021-01-16 14:59:37 +01:00
c7cf012d51 Remove commented code 2021-01-16 14:34:28 +01:00
611d4c5e26 Add support for detecting manga issues in YACReader
When an issues is open from YACReaderLibrary we can check if it is a manga an update the UI to enable manga reading.

This also fixes going previous/next from the ui/shortcuts
2021-01-16 14:29:00 +01:00
9643274b39 Enable manga in the search engine 2021-01-16 14:26:37 +01:00
bc82078ec9 Add new manga field to the edit comic dialog 2021-01-16 14:26:07 +01:00
97c7723b17 Add support for setting issues as manga/normal in the comics view 2021-01-16 14:25:47 +01:00
52953633e5 Send manga field through the server 2021-01-16 14:24:14 +01:00
3ab05c6777 Add a new boolean field for tagging comics as manga 2021-01-16 14:23:59 +01:00
8c6e8cdf36 Merge pull request #36 from iain-benson/feature/extended_search
Feature/extended search
2021-01-14 21:39:10 +01:00
7e72c8b691 Update CHANGELOG 2021-01-14 21:38:30 +01:00
76a307d0d8 Remove comments 2021-01-14 19:11:25 +01:00
6bb64c5467 Import non-gui global header 2021-01-14 18:42:51 +01:00
24c0a783de Remove reference to lexertl's license 2021-01-14 18:42:21 +01:00
82eb5c0a8b Add fallback for qt < 5.15 2021-01-14 15:51:20 +01:00
f03ad848cb Add support for true and false literals to be used with bool fields
The lexer itself should be responsible for parsing those values but it will require a bigger refactoring.
2021-01-14 15:32:20 +01:00
f803b54f2e Add support for boolean folder fields 2021-01-14 12:25:24 +01:00
dde60b78ea YACReaderLibrary compiles using c++11 just fine
It is probably worth to bump this to c++14 and ideally use c++17, but it will be done in a separate branch.
2021-01-14 11:38:45 +01:00
c3b0780e03 Remove unused constant 2021-01-14 11:37:37 +01:00
5343d24f26 Run folder search filtering in the background
It uses the same approach used by the comics search filter
2021-01-14 11:37:17 +01:00
047fd24609 Make the search line edit bigger 2021-01-14 09:17:49 +01:00
ccc382df7d Use ComicQueryResultProcesor 2021-01-14 09:17:18 +01:00