Commit Graph

22 Commits

Author SHA1 Message Date
4b3042def4 Fix object leaks in database code
Qt's database and query model requires that both the queries and the database
objects are out of scope before a database connection can safely be removed.

Solution: Properly encapsulate databases and queries in "{ }" and use a string
to cache the connection name for out-of-scope removal.
2020-08-25 17:34:46 +02:00
b9acd13120 Fix code format errors due to changes in default coding style. (#150) 2020-07-24 21:17:49 +02:00
346bcdaf75 Clang format fix. 2019-09-25 17:38:59 +02:00
cfb4e31af9 Fix for story arcs not being parsed from comicvine. 2019-09-25 17:38:59 +02:00
f29724e404 Annotate overridden methods 2019-06-01 16:04:48 +02:00
268bebbddd Use nullptr instead of 0 2019-06-01 16:04:48 +02:00
bb334cfd50 Use auto to avoid duplicating the type name 2019-06-01 16:04:48 +02:00
e3ec56aa43 Format code using clang-format 2019-05-30 19:46:37 +02:00
eeb303a5c1 Avoid parsing non supported dates from comic vine 2019-04-28 09:30:15 +02:00
44db4397e8 Avoid parsing null values from comic vine 2019-04-28 09:28:50 +02:00
8c8521a8dc Library: reorder initialization of ResponseParser 2019-04-01 11:25:16 +02:00
ebcb52bf16 Library: bugfix a 'switch case' that had no 'break' 2019-04-01 11:25:16 +02:00
0453bf126a Library: unused method parameter, so comment out the name 2019-04-01 11:25:16 +02:00
ab96056b0e Normalize line endings
Normalize the line endings for a bunch of files previously not covered 
by .gitattributes.
2018-08-07 11:09:02 +02:00
d5a11fb16b Add .gitattributes rules for text and binary handling 2018-07-30 15:04:04 +02:00
8921b016a5 Avoid null values for issues' title coming from Comic Vine 2018-05-31 18:31:32 +02:00
1a91206a2d Merge branch 'develop' into 9.5.0_bugfixes 2018-05-31 18:12:52 +02:00
229afbc9a9 Fix crash caused by accessing the UI thread from a background thread.
ComicVineDialog was calling close from background, plus accepted is emmited from a background thread, so it needs a QueuedConnection.
2018-05-31 18:09:41 +02:00
ca3bc94f25 Fix potential memleak caused by unused QAction pointer in SortVolumeComics 2018-05-26 11:09:28 +02:00
52c76d5482 Create unique database connections per thread and remove them using the database connection name from the QSqlDatabase instance being used. 2018-04-24 20:53:24 +02:00
310b9e602b Trim comic vine api key to avoid problems with white spaces. 2018-02-26 14:51:38 +01:00
fd3d54449e Fix unarr detection on Linux systems that use qmake without pkg-config support 2018-01-12 20:03:29 +01:00