From fc57378a85469e9dd51701b0cde5a157f2130e15 Mon Sep 17 00:00:00 2001
From: Igor Kushnir <igorkuo@gmail.com>
Date: Thu, 11 Feb 2021 17:28:39 +0200
Subject: [PATCH] Remove unused sizeHint() from GridComicsView and
 ComicsViewTransition

QWidget::sizeHint() is const-qualified, so Clang warns that non-const
sizeHint() member functions merely hide the virtual function of the base
class.

664dac34010c946db4477065abd077a7f7145bcd and
9f53ae6efcfb63c90308f86d4d30230c8750e66c introduced these member
functions in 2014 without const qualifiers. QWidget::sizeHint() was
const-qualified even in Qt 3. Since these member functions have never
had any effect, they should be removed rather than const-qualified to
preserve the long-standing behaviors of the two classes.

Add a TODO for a similar but less straightforward issue with
PropertiesDialog::sizeHint().
---
 YACReaderLibrary/comics_view_transition.cpp | 5 -----
 YACReaderLibrary/comics_view_transition.h   | 1 -
 YACReaderLibrary/grid_comics_view.cpp       | 5 -----
 YACReaderLibrary/grid_comics_view.h         | 1 -
 YACReaderLibrary/properties_dialog.h        | 3 +++
 5 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/YACReaderLibrary/comics_view_transition.cpp b/YACReaderLibrary/comics_view_transition.cpp
index c22bbc8a..447e86cc 100644
--- a/YACReaderLibrary/comics_view_transition.cpp
+++ b/YACReaderLibrary/comics_view_transition.cpp
@@ -20,11 +20,6 @@ ComicsViewTransition::ComicsViewTransition(QWidget *parent)
 #endif
 }
 
-QSize ComicsViewTransition::sizeHint()
-{
-    return QSize(450, 350);
-}
-
 void ComicsViewTransition::paintEvent(QPaintEvent *)
 {
     QPainter painter(this);
diff --git a/YACReaderLibrary/comics_view_transition.h b/YACReaderLibrary/comics_view_transition.h
index 7f2cc7b0..78a08c3e 100644
--- a/YACReaderLibrary/comics_view_transition.h
+++ b/YACReaderLibrary/comics_view_transition.h
@@ -8,7 +8,6 @@ class ComicsViewTransition : public QWidget
     Q_OBJECT
 public:
     explicit ComicsViewTransition(QWidget *parent = nullptr);
-    QSize sizeHint();
 
 protected:
     void paintEvent(QPaintEvent *) override;
diff --git a/YACReaderLibrary/grid_comics_view.cpp b/YACReaderLibrary/grid_comics_view.cpp
index feb24ae2..f442bece 100644
--- a/YACReaderLibrary/grid_comics_view.cpp
+++ b/YACReaderLibrary/grid_comics_view.cpp
@@ -469,11 +469,6 @@ void GridComicsView::resetScroll()
     QMetaObject::invokeMethod(scrollView, "scrollToOrigin");
 }
 
-QSize GridComicsView::sizeHint()
-{
-    return QSize(1280, 768);
-}
-
 QByteArray GridComicsView::getMimeDataFromSelection()
 {
     QByteArray data;
diff --git a/YACReaderLibrary/grid_comics_view.h b/YACReaderLibrary/grid_comics_view.h
index 1d7ca65e..8b39f1d3 100644
--- a/YACReaderLibrary/grid_comics_view.h
+++ b/YACReaderLibrary/grid_comics_view.h
@@ -31,7 +31,6 @@ public:
     void toNormal() override;
     void updateConfig(QSettings *settings) override;
     void enableFilterMode(bool enabled) override;
-    QSize sizeHint();
     QByteArray getMimeDataFromSelection();
     void updateCurrentComicView() override;
     void focusComicsNavigation(Qt::FocusReason reason) override;
diff --git a/YACReaderLibrary/properties_dialog.h b/YACReaderLibrary/properties_dialog.h
index ad32320f..56505dcf 100644
--- a/YACReaderLibrary/properties_dialog.h
+++ b/YACReaderLibrary/properties_dialog.h
@@ -122,6 +122,9 @@ public:
     PropertiesDialog(QWidget *parent = nullptr);
     QString databasePath;
     QString basePath;
+    // TODO: this non-const member function hides rather than overrides
+    // QWidget::sizeHint(). But the function cannot be simply removed as it is used
+    // in our constructor. Will have to investigate and decide how to fix this.
     QSize sizeHint();
     void paintEvent(QPaintEvent *event) override;