mirror/yacreader
1
0
Fork 0
mirror of https://github.com/YACReader/yacreader synced 2025-06-04 01:28:55 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use better http status code to notify clientes about what is going on while loading comics.

Browse Source
This commit is contained in:
Luis Ángel San Martín 2018-04-26 18:27:42 +02:00
parent 30211233af
commit e4b4f96369
1 changed files with 62 additions and 57 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
YACReaderLibrary/server/controllers/v2/pagecontroller_v2.cpp
View File

@ -21,8 +21,8 @@ void PageControllerV2::service(HttpRequest& request, HttpResponse& response)
YACReaderHttpSession *ySession = Static::yacreaderSessionStore->getYACReaderSessionHttpSession(token); YACReaderHttpSession *ySession = Static::yacreaderSessionStore->getYACReaderSessionHttpSession(token);
if (ySession == nullptr) { if (ySession == nullptr) {
response.setStatus(404,"not found"); response.setStatus(424,"no session for this comic");
response.write("404 not found",true); response.write("424 no session for this comic",true);
return; return;
} }
@ -56,6 +56,10 @@ void PageControllerV2::service(HttpRequest& request, HttpResponse& response)
if(currentComicId != 0 && !QPointer<Comic>(comicFile).isNull()) if(currentComicId != 0 && !QPointer<Comic>(comicFile).isNull())
{ {
if (comicFile->numPages() == 0) {
response.setStatus(412,"opening file");
response.write("412 opening file",true);
} else {
if(comicId == currentComicId && page < comicFile->numPages()) if(comicId == currentComicId && page < comicFile->numPages())
{ {
if(comicFile->pageIsLoaded(page)) if(comicFile->pageIsLoaded(page))
@ -65,9 +69,9 @@ void PageControllerV2::service(HttpRequest& request, HttpResponse& response)
response.setHeader("Transfer-Encoding","chunked"); response.setHeader("Transfer-Encoding","chunked");
QByteArray pageData = comicFile->getRawPage(page); QByteArray pageData = comicFile->getRawPage(page);
QDataStream data(pageData); QDataStream data(pageData);
char buffer[4096]; char buffer[100000];
while (!data.atEnd()) { while (!data.atEnd()) {
int len = data.readRawData(buffer,4096); int len = data.readRawData(buffer,100000);
response.write(QByteArray(buffer,len)); response.write(QByteArray(buffer,len));
} }
//response.write(pageData,true); //response.write(pageData,true);
@ -76,8 +80,8 @@ void PageControllerV2::service(HttpRequest& request, HttpResponse& response)
else else
{ {
//qDebug("PageController: La página NO estaba cargada 404 -> %s ",path.data()); //qDebug("PageController: La página NO estaba cargada 404 -> %s ",path.data());
response.setStatus(404,"not found"); //TODO qué mensaje enviar response.setStatus(412,"loading page"); //TODO qué mensaje enviar
response.write("404 not found",true); response.write("412 loading page",true);
} }
} }
else else
@ -90,8 +94,9 @@ void PageControllerV2::service(HttpRequest& request, HttpResponse& response)
else else
ySession->dismissCurrentComic(); ySession->dismissCurrentComic();
} }
response.setStatus(404,"not found"); //TODO qué mensaje enviar response.setStatus(412,"not found"); //TODO qué mensaje enviar
response.write("404 not found",true); response.write("412 not found",true);
}
} }
} }
else else