From c1810b9e5459938cb54f829c43f046c8b2449ad4 Mon Sep 17 00:00:00 2001 From: Igor Kushnir Date: Fri, 24 May 2019 14:43:40 +0300 Subject: [PATCH] Library: do not needlessly retrieve all comics from the DB The siblings variable is unused. So the ComicModel::getAllComics() call is redundant unless there is some unobvious side effect (I hope not). --- YACReaderLibrary/library_window.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/YACReaderLibrary/library_window.cpp b/YACReaderLibrary/library_window.cpp index 182894c2..8dc5892b 100644 --- a/YACReaderLibrary/library_window.cpp +++ b/YACReaderLibrary/library_window.cpp @@ -1798,8 +1798,6 @@ void LibraryWindow::checkEmptyFolder() void LibraryWindow::openComic(const ComicDB &comic) { if(!importedCovers) { - QList siblings = comicsModel->getAllComics(); - //TODO generate IDS for libraries... quint64 libraryId = libraries.getId(selectedLibrary->currentText()); bool yacreaderFound = false;