mirror/yacreader
1
0
Fork 0
mirror of https://github.com/YACReader/yacreader synced 2026-04-12 15:49:53 -04:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Add TODO to document bug in recolorSvgXML

Browse Source
This commit is contained in:
luisangelsm
2026-02-28 18:20:13 +01:00
parent 61a0b590ed
commit 7e7c6a979c
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
common/themes/icon_utils.cpp
View File

@ -66,6 +66,9 @@ QString recolorSvgXML(QString &svg,
const QString &placeHolder, const QString &placeHolder,
const QColor &color) const QColor &color)
{ {
// TODO: svg colors can work without ;, we need to update all the svg files to inlude ;
// Include the trailing ';' so e.g. "#ff0;" never accidentally matches
// inside a previously-substituted value like "#ff0000;".
return svg.replace(placeHolder, color.name(QColor::HexRgb), Qt::CaseInsensitive); return svg.replace(placeHolder, color.name(QColor::HexRgb), Qt::CaseInsensitive);
} }