From 689e31891f75065a5dc7eaa91fcbb3e2ac88e9d5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Luis=20=C3=81ngel=20San=20Mart=C3=ADn?=
 <luisangelsm@gmail.com>
Date: Mon, 24 Oct 2022 19:00:04 +0200
Subject: [PATCH] Extract method

---
 .../comic_vine/comic_vine_dialog.cpp             | 14 ++------------
 YACReaderLibrary/db_helper.cpp                   | 16 ++++++++++++++++
 YACReaderLibrary/db_helper.h                     |  1 +
 3 files changed, 19 insertions(+), 12 deletions(-)

diff --git a/YACReaderLibrary/comic_vine/comic_vine_dialog.cpp b/YACReaderLibrary/comic_vine/comic_vine_dialog.cpp
index 52ffe712..bf26fe58 100644
--- a/YACReaderLibrary/comic_vine/comic_vine_dialog.cpp
+++ b/YACReaderLibrary/comic_vine/comic_vine_dialog.cpp
@@ -466,18 +466,8 @@ void ComicVineDialog::getComicsInfo(QList<QPair<ComicDB, QString>> matchingInfo,
 
         setLoadingMessage(tr("Retrieving tags for : %1").arg(p.first.getFileName()));
     }
-    QString connectionName = "";
-    {
-        QSqlDatabase db = DataBaseManagement::loadDatabase(databasePath);
-        db.open();
-        db.transaction();
-        foreach (ComicDB comic, comics) {
-            DBHelper::update(&(comic.info), db);
-        }
-        db.commit();
-        connectionName = db.connectionName();
-    }
-    QSqlDatabase::removeDatabase(connectionName);
+
+    DBHelper::updateComicsInfo(comics, databasePath);
 
     emit accepted();
 }
diff --git a/YACReaderLibrary/db_helper.cpp b/YACReaderLibrary/db_helper.cpp
index 897bf5bd..7d2bb8f1 100644
--- a/YACReaderLibrary/db_helper.cpp
+++ b/YACReaderLibrary/db_helper.cpp
@@ -1175,6 +1175,22 @@ void DBHelper::reasignOrderToComicsInReadingList(qulonglong readingListId, QList
     db.commit();
 }
 
+void DBHelper::updateComicsInfo(QList<ComicDB> &comics, const QString &databasePath)
+{
+    QString connectionName = "";
+    {
+        QSqlDatabase db = DataBaseManagement::loadDatabase(databasePath);
+        db.open();
+        db.transaction();
+        foreach (ComicDB comic, comics) {
+            DBHelper::update(&(comic.info), db);
+        }
+        db.commit();
+        connectionName = db.connectionName();
+    }
+    QSqlDatabase::removeDatabase(connectionName);
+}
+
 // inserts
 qulonglong DBHelper::insert(Folder *folder, QSqlDatabase &db)
 {
diff --git a/YACReaderLibrary/db_helper.h b/YACReaderLibrary/db_helper.h
index b3a541fb..8c84e098 100644
--- a/YACReaderLibrary/db_helper.h
+++ b/YACReaderLibrary/db_helper.h
@@ -82,6 +82,7 @@ public:
     static void reasignOrderToComicsInFavorites(QList<qulonglong> comicIds, QSqlDatabase &db);
     static void reasignOrderToComicsInLabel(qulonglong labelId, QList<qulonglong> comicIds, QSqlDatabase &db);
     static void reasignOrderToComicsInReadingList(qulonglong readingListId, QList<qulonglong> comicIds, QSqlDatabase &db);
+    static void updateComicsInfo(QList<ComicDB> &comics, const QString &databasePath);
 
     static QList<LibraryItem *> getFoldersFromParent(qulonglong parentId, QSqlDatabase &db, bool sort = true);
     static QList<ComicDB> getSortedComicsFromParent(qulonglong parentId, QSqlDatabase &db);