From 595ceecb62ada84a2200de573a5e39432b9de179 Mon Sep 17 00:00:00 2001 From: Felix Kauselmann <2039670+selmf@users.noreply.github.com> Date: Tue, 22 Nov 2016 18:23:40 +0100 Subject: [PATCH] Add cleanup function to mac pdf image buffer --- YACReaderLibrary/library_creator.cpp | 3 --- common/comic.cpp | 1 - common/pdf_comic.mm | 2 +- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/YACReaderLibrary/library_creator.cpp b/YACReaderLibrary/library_creator.cpp index d6ce5863..cac5569a 100644 --- a/YACReaderLibrary/library_creator.cpp +++ b/YACReaderLibrary/library_creator.cpp @@ -627,9 +627,6 @@ void ThumbnailCreator::create() { #if defined Q_OS_MAC || defined USE_PDFIUM QImage p = pdfComic->getPage(_coverPage-1); //TODO check if the page is valid - #ifdef USE_PDFKIT - pdfComic->releaseLastPageData(); - #endif #else QImage p = pdfComic->page(_coverPage-1)->renderToImage(72,72); #endif // diff --git a/common/comic.cpp b/common/comic.cpp index 4ec210d3..6dd93ac0 100644 --- a/common/comic.cpp +++ b/common/comic.cpp @@ -861,7 +861,6 @@ void PDFComic::renderPage(int page) QImage img = pdfComic->getPage(page); if(!img.isNull()) { - pdfComic->releaseLastPageData(); #elif defined USE_PDFIUM QImage img = pdfComic->getPage(page); if(!img.isNull()) diff --git a/common/pdf_comic.mm b/common/pdf_comic.mm index 3eda1c07..b34e5f2d 100644 --- a/common/pdf_comic.mm +++ b/common/pdf_comic.mm @@ -108,7 +108,7 @@ QImage MacOSXPDFComic::getPage(const int pageNum) const uchar *bytes = (const uchar *)CFDataGetBytePtr(dataRef); - qtImage = QImage(bytes, pageRect.size.width, pageRect.size.height, QImage::Format_ARGB32); + qtImage = QImage(bytes, pageRect.size.width, pageRect.size.height, QImage::Format_ARGB32, &releaseLastPageData()); CGImageRelease(image); //CFRelease(dataRef);