mirror/yacreader
1
0
Fork 0
mirror of https://github.com/YACReader/yacreader synced 2026-04-12 15:49:53 -04:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix default background color being stuck when changing themes
Some checks failed
Build / Initialization (push) Has been cancelled
Details
Build / Code Format Validation (push) Has been cancelled
Details
Build / Linux (Qt6) (push) Has been cancelled
Details
Build / Linux (Qt6 + 7zip) (push) Has been cancelled
Details
Build / macOS (Qt6 Universal) (push) Has been cancelled
Details
Build / Windows x64 (Qt6) (push) Has been cancelled
Details
Build / Windows ARM64 (Qt6) (push) Has been cancelled
Details
Build / Docker amd64 Image (push) Has been cancelled
Details
Build / Docker arm64 Image (push) Has been cancelled
Details
Build / Publish Dev Builds (push) Has been cancelled
Details
Build / Publish Release (push) Has been cancelled
Details
Build / Publish YACReader10 Pre-release Builds (push) Has been cancelled
Details

Browse Source 
The color is only persisted if the user sets a color explicitly.
This commit is contained in:
luisangelsm
2026-03-30 21:55:37 +02:00
parent 11c305888f
commit 4bcdb3c7da
2 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
YACReader/options_dialog.cpp
View File

@ -279,6 +279,10 @@ OptionsDialog::OptionsDialog(QWidget *parent)
void OptionsDialog::applyTheme(const Theme &theme)
{
pathFindButton->setIcon(theme.dialogIcons.findFolderIcon);
if (backgroundColorFollowsTheme) {
updateColor(theme.viewer.defaultBackgroundColor);
}
}
void OptionsDialog::findFolder()
@ -292,6 +296,11 @@ void OptionsDialog::findFolder()
void OptionsDialog::showColorDialog()
{
auto color = QColorDialog::getColor(currentColor, this);
if (!color.isValid()) {
return;
}
backgroundColorFollowsTheme = false;
updateColor(color);
}
@ -303,7 +312,7 @@ void OptionsDialog::saveOptions()
Configuration::getConfiguration().setShowTimeInInformation(showTimeInInformationLabel->isChecked());
if (currentColor != theme.viewer.defaultBackgroundColor) {
if (!backgroundColorFollowsTheme) {
settings->setValue(BACKGROUND_COLOR, currentColor);
} else {
settings->remove(BACKGROUND_COLOR);
@ -356,7 +365,10 @@ void OptionsDialog::restoreOptions(QSettings *settings)
showTimeInInformationLabel->setChecked(Configuration::getConfiguration().getShowTimeInInformation());
updateColor(settings->value(BACKGROUND_COLOR, theme.viewer.defaultBackgroundColor).value<QColor>());
backgroundColorFollowsTheme = !settings->contains(BACKGROUND_COLOR);
updateColor(backgroundColorFollowsTheme
? theme.viewer.defaultBackgroundColor
: settings->value(BACKGROUND_COLOR).value<QColor>());
// fitToWidthRatioS->setSliderPosition(settings->value(FIT_TO_WIDTH_RATIO).toFloat()*100);
quickNavi->setChecked(settings->value(QUICK_NAVI_MODE).toBool());
@ -476,6 +488,7 @@ void OptionsDialog::setFilters(int brightness, int contrast, int gamma)
void OptionsDialog::clearBackgroundColor()
{
backgroundColorFollowsTheme = true;
settings->remove(BACKGROUND_COLOR);
updateColor(theme.viewer.defaultBackgroundColor);

1
YACReader/options_dialog.h
View File

@ -63,6 +63,7 @@ private:
YACReaderSpinSliderWidget *gammaS;
QColor currentColor;
bool backgroundColorFollowsTheme = true;
QComboBox *scalingMethodCombo;