mirror/yacreader
1
0
Fork 0
mirror of https://github.com/YACReader/yacreader synced 2025-05-28 03:10:27 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix possible memleaks occuring when passing nonexistent dirs to console library creator. (#132)

Browse Source
This commit is contained in:
Felix Kauselmann 2020-07-02 20:28:53 +02:00 committed by GitHub
parent 868843df37
commit 41ccef1060
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
YACReaderLibraryServer/console_ui_library_creator.cpp
View File

@ -12,21 +12,21 @@ ConsoleUILibraryCreator::ConsoleUILibraryCreator(QObject *parent)
void ConsoleUILibraryCreator::createLibrary(const QString &name, const QString &path) void ConsoleUILibraryCreator::createLibrary(const QString &name, const QString &path)
{ {
QEventLoop eventLoop;
LibraryCreator *libraryCreator = new LibraryCreator();
QDir pathDir(path); QDir pathDir(path);
if (!pathDir.exists()) { if (!pathDir.exists()) {
std::cout << "Directory not found." << std::endl; std::cout << "Directory not found." << std::endl;
return; return;
} }
QEventLoop eventLoop;
LibraryCreator *libraryCreator = new LibraryCreator();
QString cleanPath = QDir::cleanPath(pathDir.absolutePath()); QString cleanPath = QDir::cleanPath(pathDir.absolutePath());
YACReaderLibraries yacreaderLibraries; YACReaderLibraries yacreaderLibraries;
yacreaderLibraries.load(); yacreaderLibraries.load();
if (yacreaderLibraries.contains(name)) { if (yacreaderLibraries.contains(name)) {
std::cout << "A Library named \"" << name.toUtf8().constData() << "\" already exists in database." << std::endl; std::cout << "A Library named \"" << name.toUtf8().constData() << "\" already exists in database." << std::endl;
delete libraryCreator;
return; return;
} }
@ -49,14 +49,14 @@ void ConsoleUILibraryCreator::createLibrary(const QString &name, const QString &
void ConsoleUILibraryCreator::updateLibrary(const QString &path) void ConsoleUILibraryCreator::updateLibrary(const QString &path)
{ {
QEventLoop eventLoop;
LibraryCreator *libraryCreator = new LibraryCreator();
QDir pathDir(path); QDir pathDir(path);
if (!pathDir.exists()) { if (!pathDir.exists()) {
std::cout << "Directory not found." << std::endl; std::cout << "Directory not found." << std::endl;
return; return;
} }
QEventLoop eventLoop;
LibraryCreator *libraryCreator = new LibraryCreator();
QString cleanPath = QDir::cleanPath(pathDir.absolutePath()); QString cleanPath = QDir::cleanPath(pathDir.absolutePath());
libraryCreator->updateLibrary(cleanPath, QDir::cleanPath(pathDir.absolutePath() + "/.yacreaderlibrary")); libraryCreator->updateLibrary(cleanPath, QDir::cleanPath(pathDir.absolutePath() + "/.yacreaderlibrary"));