add convenience method YACReader::addSeparator(QWidget *) for adding QAction separator to a widget

YACReader/main_window_viewer.cpp

@@ -547,9 +547,8 @@ void MainWindowViewer::createToolBars()
 	viewer->addAction(saveImageAction);
 	viewer->addAction(openPreviousComicAction);
 	viewer->addAction(openNextComicAction);
-	QAction * separator = new QAction("",this);
+    YACReader::addSperator(viewer);
-	separator->setSeparator(true);
+
-	viewer->addAction(separator);
 	viewer->addAction(prevAction);
 	viewer->addAction(nextAction);
 	viewer->addAction(goToPage);
@@ -558,34 +557,25 @@ void MainWindowViewer::createToolBars()
 	viewer->addAction(adjustToFullSizeAction);
 	viewer->addAction(leftRotationAction);
 	viewer->addAction(rightRotationAction);
-		viewer->addAction(doublePageAction);
+    YACReader::addSperator(viewer);
-	separator = new QAction("",this);
+
-	separator->setSeparator(true);
-	viewer->addAction(separator);
 	viewer->addAction(showMagnifyingGlass);
-	separator = new QAction("",this);
+    YACReader::addSperator(viewer);
-	separator->setSeparator(true);
-	viewer->addAction(separator);
 
 	viewer->addAction(setBookmark);
 	viewer->addAction(showBookmarks);
-	separator = new QAction("",this);
+    YACReader::addSperator(viewer);
-	separator->setSeparator(true);
-	viewer->addAction(separator);
 
 	viewer->addAction(showDictionaryAction);
 	viewer->addAction(showFlowAction);
 	viewer->addAction(showInfo);
-	separator = new QAction("",this);
+    YACReader::addSperator(viewer);
-	separator->setSeparator(true);
-	viewer->addAction(separator);
 
 	viewer->addAction(showShorcutsAction);
 	viewer->addAction(optionsAction);
 	viewer->addAction(helpAboutAction);
-	separator = new QAction("",this);
+    YACReader::addSperator(viewer);
-	separator->setSeparator(true);
+
-	viewer->addAction(separator);
 	viewer->addAction(closeAction);
 
 	viewer->setContextMenuPolicy(Qt::ActionsContextMenu);

YACReaderLibrary/library_window.cpp

@@ -500,9 +500,6 @@ void LibraryWindow::createActions()
 	getInfoAction->setIcon(QIcon(":/images/getInfo.png"));
 	//-------------------------------------------------------------------------
 
-	separatorAction = new QAction(this);
-	separatorAction->setSeparator(true);
-	//-------------------------------------------------------------------------
 	//disable actions
 	disableAllActions();
 }
@@ -644,53 +641,40 @@ void LibraryWindow::createToolBars()
 void LibraryWindow::createMenus()
 {
 	comicView->addAction(openContainingFolderComicAction);
-	{ comicView->addAction(separatorAction); }
+    YACReader::addSperator(comicView);
+
 	comicView->addAction(resetComicRatingAction);
-	{ comicView->addAction(separatorAction); }
+    YACReader::addSperator(comicView);
+
 	comicView->addAction(editSelectedComicsAction);
 	comicView->addAction(getInfoAction);
-	//comicView->addAction(asignOrderActions);
+    comicView->addAction(asignOrderActions);
-	{ comicView->addAction(separatorAction); }
+    YACReader::addSperator(comicView);
+
 	comicView->addAction(setAsReadAction);
 	comicView->addAction(setAsNonReadAction);
-	{ comicView->addAction(separatorAction); }
+    YACReader::addSperator(comicView);
+
 	comicView->addAction(deleteComicsAction);
 
 	foldersView->addAction(openContainingFolderAction);
+    YACReader::addSperator(foldersView);
 
-    {
-        QAction *act = new QAction(this);
-        act->setSeparator(true);
-        foldersView->addAction(act);
-    }
     foldersView->addAction(setFolderAsNotCompletedAction);
     foldersView->addAction(setFolderAsCompletedAction);
-    {
+    YACReader::addSperator(foldersView);
-        QAction *act = new QAction(this);
+
-        act->setSeparator(true);
-        foldersView->addAction(act);
-    }
     foldersView->addAction(setFolderAsFinishedAction);
     foldersView->addAction(setFolderAsNotFinishedAction);
 
 	selectedLibrary->addAction(updateLibraryAction); 
 	selectedLibrary->addAction(renameLibraryAction);
 	selectedLibrary->addAction(removeLibraryAction);
-
+    YACReader::addSperator(selectedLibrary);
-	{
-		QAction *act = new QAction(this);
-		act->setSeparator(true);
-		selectedLibrary->addAction(act);
-	}
 
 	selectedLibrary->addAction(exportComicsInfo);
 	selectedLibrary->addAction(importComicsInfo);
-
+    YACReader::addSperator(selectedLibrary);
-	{
-		QAction *act = new QAction(this);
-		act->setSeparator(true);
-		selectedLibrary->addAction(act);
-	}
 
 	selectedLibrary->addAction(exportLibraryAction);
 	selectedLibrary->addAction(importLibraryAction);

YACReaderLibrary/library_window.h

@@ -161,8 +161,6 @@ private:
 	QAction * deleteComicsAction;
 	QAction * hideComicViewAction;
 
-    QAction * separatorAction; //dummy action
-
 #ifdef Q_OS_MAC
 	QToolBar * libraryToolBar;
 #else

common/yacreader_global.cpp

@@ -1,4 +1,5 @@
 #include "yacreader_global.h"
+#include <QAction>
 
 using namespace YACReader;
 
@@ -11,3 +12,10 @@ QString YACReader::getSettingsPath()
 #endif
 
 }
+
+void YACReader::addSperator(QWidget *w)
+{
+    QAction * separator = new QAction(w);
+    separator->setSeparator(true);
+    w->addAction(separator);
+}

common/yacreader_global.h

@@ -7,6 +7,7 @@
 	#include <QDesktopServices>
 #endif
 
+#include <QWidget>
 
 #define VERSION "7.1.0"
 
@@ -94,8 +95,7 @@ namespace YACReader
  };
 
 QString getSettingsPath();
-
+void addSperator(QWidget * w);
 }
-
 #endif