mirror/yacreader
1
0
Fork 0
mirror of https://github.com/YACReader/yacreader synced 2025-06-04 01:28:55 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

SendComic: Connect finished signal to deleteLater slot BEFORE the finished

Browse Source 
signal is emitted so it is actually processed and we don't get dangling pointers.

Use modern signal slot syntax so that the compiler and source check tools can
verify we actually fixed the problem.
This commit is contained in:
Felix Kauselmann 2018-05-26 12:20:53 +02:00
parent f7e2547531
commit 0cc6b3bcf7
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
YACReader/main_window_viewer.cpp
View File

@ -1682,6 +1682,7 @@ void MainWindowViewer::decreasePageZoomLevel()
void MainWindowViewer::sendComic() void MainWindowViewer::sendComic()
{ {
YACReaderLocalClient * client = new YACReaderLocalClient; YACReaderLocalClient * client = new YACReaderLocalClient;
connect(client, &YACReaderLocalClient::finished, client, &YACReaderLocalClient::deleteLater);
currentComicDB.info.lastTimeOpened = QDateTime::currentSecsSinceEpoch(); currentComicDB.info.lastTimeOpened = QDateTime::currentSecsSinceEpoch();
viewer->updateComic(currentComicDB); viewer->updateComic(currentComicDB);
@ -1692,15 +1693,12 @@ void MainWindowViewer::sendComic()
ComicDB & nextComic = siblingComics[currentIndex+1]; ComicDB & nextComic = siblingComics[currentIndex+1];
nextComic.info.hasBeenOpened = true; nextComic.info.hasBeenOpened = true;
int retries = 1; int retries = 1;
while(!client->sendComicInfo(libraryId,currentComicDB,nextComic.id) && retries!=0) while(!client->sendComicInfo(libraryId, currentComicDB, nextComic.id) && retries!=0)
retries--; retries--;
connect(client,SIGNAL(finished()),client,SLOT(deleteLater()));
} }
} else { } else {
int retries = 1; int retries = 1;
while(!client->sendComicInfo(libraryId,currentComicDB) && retries!=0) while(!client->sendComicInfo(libraryId, currentComicDB) && retries!=0)
retries--; retries--;
connect(client,SIGNAL(finished()),client,SLOT(deleteLater()));
} }
//delete client;
} }