manuaudioandUrs Fleisch c275891a77 DSDIFF: do not convert an out of range length to int ...

Same shape as the DSF change: sampleCount comes from a chunk size in the
file and sampleRate is read from it, so

    static_cast<int>(static_cast<double>(d->sampleCount) * 1000.0
                     / d->sampleRate + 0.5)

can be handed a value int cannot represent, which is undefined.

In the PR I said I had not demonstrated this one, because chunkFits
bounds the sample count by the file length so a few mutated bytes will
not do it. Constructing the file it does need - a 700 kB DSD chunk with
a sample rate of 1 - reaches it:

  taglib/dsdiff/dsdiffproperties.cpp:61:24: runtime error: 2.8e+09 is
  outside the range of representable values of type 'int'

Two reports before the change, none after. tests/data/empty10ms.dff is
unchanged at lengthMs=10 bitrate=5644 rate=2822400 ch=2.

Assisted-By: Claude Code (Claude Opus 5)

2026-08-15 17:52:56 +02:00

..

dsdiffdiintag.cpp

Fix issues reported by CppCheck

2023-12-07 05:00:00 +01:00

dsdiffdiintag.h

Fix MSVC warning needs to have dll-interface (#1185)

2023-12-11 06:35:08 +01:00

dsdifffile.cpp

Prevent DSDIFF chunk size wrap (#1388)

2026-08-02 08:14:43 +02:00

dsdifffile.h

Compile time configuration of supported formats (#1262)

2025-02-02 12:24:26 +01:00

dsdiffproperties.cpp

DSDIFF: do not convert an out of range length to int

2026-08-15 17:52:56 +02:00

dsdiffproperties.h

Inspection: Code redundancies

2024-01-21 20:46:27 +01:00