Thomas BergwinklandGitHub 5530420d08 Fix ID3v2 frame data length check for per-frame unsynchronised ID3v2.4 frames (#1385) ...

Frame::fieldData() (taglib/mpeg/id3v2/id3v2frame.cpp) discarded any
ID3v2.4 frame whose declared size (from the header) no longer matched
its actual buffer size after per-frame unsynchronisation was decoded by
FrameFactory::prepareFrameHeader(), silently emptying frames like
TIT2/TPE1/TALB. Clamp the declared length to what's actually available
instead of discarding the frame, only bailing out if the frame's data
offset itself doesn't fit.

Adds testUnsynchDecodeID3v24Frame() to tests/test_id3v2.cpp, covering a
frame with its own per-frame Unsynchronisation flag (as opposed to the
tag-wide flag already covered by testUnsynchDecode()), using new fixture
tests/data/unsynch24.id3.

2026-08-01 07:53:53 +02:00

..

data

Fix ID3v2 frame data length check for per-frame unsynchronised ID3v2.4 frames (#1385)

2026-08-01 07:53:53 +02:00

CMakeLists.txt

Add tests for FileRef content-based detection via ByteVectorStream (#1318)

2026-04-04 07:43:56 +02:00

main.cpp

Inspection: Code redundancies

2024-01-21 20:46:27 +01:00

plainfile.h

Consistently use quote form when including our own headers

2023-07-22 07:09:58 +02:00

test_aiff.cpp

unused includes (#1133)

2023-09-16 08:22:36 +02:00

test_ape.cpp

unused includes (#1133)

2023-09-16 08:22:36 +02:00

test_apetag.cpp

Inspection: Type can be replaced with auto

2024-01-21 20:46:27 +01:00

test_asf.cpp

Inspection: Variable can be moved to inner scope

2024-01-21 20:46:27 +01:00

test_bytevector.cpp

Fix conversion compiler warnings

2025-06-25 22:08:09 +02:00

test_bytevectorlist.cpp

Use static_cast instead of C-style casts

2023-07-22 07:09:58 +02:00

test_bytevectorstream.cpp

Consistently use quote form when including our own headers

2023-07-22 07:09:58 +02:00

test_complexproperties.cpp

Compile time configuration of supported formats (#1262)

2025-02-02 12:24:26 +01:00

test_dsdiff.cpp

Inspection: C-style cast is used instead of a C++ cast

2024-01-21 20:46:27 +01:00

test_dsf.cpp

DSF: Support frame factory, ID3v2.3, allow trailing garbage

2023-09-26 16:23:03 +02:00

test_file.cpp

unused includes (#1133)

2023-09-16 08:22:36 +02:00

test_fileref_detect.cpp

Move MPEG check to end of content-based detection (#1319)

2026-04-04 08:01:41 +02:00

test_fileref.cpp

C bindings, fileref, fix warnings

2026-01-24 14:59:10 +01:00

test_flac.cpp

[FLAC] Track iXML/BEXT block presence with explicit flags

2026-05-17 16:38:07 +02:00

test_flacpicture.cpp

Inspection: Possibly unused #include directive

2024-01-21 20:46:27 +01:00

test_flacunknownmetadatablock.cpp

Inspection: Possibly unused #include directive

2024-01-21 20:46:27 +01:00

test_id3v1.cpp

unused includes (#1133)

2023-09-16 08:22:36 +02:00

test_id3v2.cpp

Fix ID3v2 frame data length check for per-frame unsynchronised ID3v2.4 frames (#1385)

2026-08-01 07:53:53 +02:00

test_id3v2framefactory.cpp

Compile time configuration of supported formats (#1262)

2025-02-02 12:24:26 +01:00

test_info.cpp

unused includes (#1133)

2023-09-16 08:22:36 +02:00

test_it.cpp

Fix issues reported by Clang Static Analyzer

2023-12-07 05:00:00 +01:00

test_list.cpp

Detach list when setAutoDelete() is called

2023-12-02 08:03:14 +01:00

test_map.cpp

Inspection: Code redundancies

2024-01-21 20:46:27 +01:00

test_matroska.cpp

[Matroska] Fix unknown size elements (#1377)

2026-07-11 09:02:39 +02:00

test_mod.cpp

Fix issues reported by CppCheck

2023-12-07 05:00:00 +01:00

test_mp4.cpp

Fix overflow for large Apple Music cnID values (#1373)

2026-06-26 07:12:16 +02:00

test_mp4coverart.cpp

unused includes (#1133)

2023-09-16 08:22:36 +02:00

test_mp4item.cpp

Provide equal operator for MP4::Item

2024-03-25 20:13:55 +01:00

test_mp4stem.cpp

MP4: Add support for NI STEM (#1299)

2026-01-25 13:33:54 +01:00

test_mpc.cpp

Fix MPC tests

2023-12-18 17:29:39 +01:00

test_mpeg.cpp

Compile time configuration of supported formats (#1262)

2025-02-02 12:24:26 +01:00

test_ogg.cpp

Inspection: Possibly unused #include directive

2024-01-21 20:46:27 +01:00

test_oggflac.cpp

Inspection: Possibly unused #include directive

2024-01-21 20:46:27 +01:00

test_opus.cpp

Opus: Read output gain (#1320)

2026-03-31 11:14:44 -05:00

test_propertymap.cpp

Compile time configuration of supported formats (#1262)

2025-02-02 12:24:26 +01:00

test_riff.cpp

Inspection: Member function can be made const

2024-01-21 20:46:27 +01:00

test_s3m.cpp

Fix issues reported by CppCheck

2023-12-07 05:00:00 +01:00

test_shorten.cpp

Add Shorten (SHN) support (#1257)

2024-12-30 07:23:11 -06:00

test_sizes.cpp

Matroska: Avoid inlined header methods, only install public headers

2026-01-24 14:59:10 +01:00

test_speex.cpp

Consistently use quote form when including our own headers

2023-07-22 07:09:58 +02:00

test_string.cpp

Fix segfaults with String and ByteVector nullptr arguments (#1247) (#1248)

2024-11-02 06:39:21 +01:00

test_synchdata.cpp

unused includes (#1133)

2023-09-16 08:22:36 +02:00

test_tag_c.cpp

Fix Unicode property keys in C bindings

2025-07-04 09:43:34 +02:00

test_trueaudio.cpp

unused includes (#1133)

2023-09-16 08:22:36 +02:00

test_variant.cpp

Variant type as container for complex properties

2023-10-14 09:01:59 +02:00

test_versionnumber.cpp

Add simple runtime version check API (#970)

2023-10-06 14:15:30 +02:00

test_wav.cpp

Clamp oversized RIFF chunk to available bytes instead of rejecting it (#1329)

2026-04-04 12:47:49 +02:00

test_wavpack.cpp

unused includes (#1133)

2023-09-16 08:22:36 +02:00

test_xiphcomment.cpp

Inspection: Code redundancies

2024-01-21 20:46:27 +01:00

test_xm.cpp

Fix issues reported by CppCheck

2023-12-07 05:00:00 +01:00

utils.h

Build fix for Haiku's fcntl.h which can't be found in sys/fcntl.h

2026-05-07 18:32:19 +02:00