Commit Graph

652 Commits

Author SHA1 Message Date
Lukáš Lalinský
94a402395b Fix off-by-one error in MP4::Tag when looking for free padding to use
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@961160 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-04-29 15:12:19 +00:00
Jeff Mitchell
f1a16bcf0f Style and safety fixes backported from taglib-extras
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@961000 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-04-29 12:55:33 +00:00
Jeff Mitchell
40bdaedb71 This commit adds support for building taglib-extras against taglib during kdesupport build time. If kdesupport is not what is being built, the normal system taglib is used.
This adds forward includes to taglib; these may be very useful to other projects as well, since taglib's includes are rather spread out.  The README file in the include folder has instructions for regenerating them.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@952369 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-04-11 17:13:24 +00:00
Lukáš Lalinský
33b939c76f Don't build ASF/MP4 FileRef tests if WITH_ASF/WITH_MP4 are undefined
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@945359 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-27 10:45:00 +00:00
Lukáš Lalinský
1eace99153 Detach before appending a character
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@944552 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-25 17:52:23 +00:00
Andreas Hartmetz
98d2808c17 this modified version has the advantage that it compiles
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@942892 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-22 20:48:27 +00:00
Scott Wheeler
fad967ae0b Less of The Big Ugly in the middle of the classes.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@942880 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-22 19:27:38 +00:00
Andrew Coles
56e8766126 Added GCC pragma to suppress non-virtual dtor warning which is being preserved
to maintain BIC.



git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@942876 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-22 19:06:05 +00:00
Jeff Mitchell
36a398a156 Finish making .asf readable, thanks Lukas
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@937985 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-10 22:33:13 +00:00
Jeff Mitchell
f1fd227fce Several of us have seen .asf WMA files in the wild.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@937972 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-10 22:02:20 +00:00
David Faure
c918150b72 Generate config.h in builddir again, and fix compilation when compiling taglib alone
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@937935 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-10 20:27:59 +00:00
Jeff Mitchell
3ec42c7b84 Re-add building things depending on config.h by having it generate in the source tree instead of the build tree, so that when cmake uses a non-source build dir (as it's supposed to) it can actually find the file. I think this is messy, as AFAIK cmake shouldn't be modifying the contents of the source tree...any cmake gurus out there, feel free to let me know if there's a better way.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@937552 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-09 22:20:50 +00:00
Jeff Mitchell
f024f9ab1b This is surely an oversight; fix documentation
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@937541 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-09 21:53:46 +00:00
Scott Wheeler
66b3a1a184 Patch from Josef Radinger fixing typo in debug message.
BUG:30212
CCMAIL:taglib-devel@kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@911772 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-01-16 05:16:48 +00:00
Scott Wheeler
4fbd7c5d93 revert last
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@909079 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-01-10 23:15:33 +00:00
Scott Wheeler
3a390a11d0 Also counts as being empty.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@909060 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-01-10 22:21:45 +00:00
Scott Wheeler
16a7efcd1c remove debug line from mac os framework build file
CCMAIL:taglib-devel@kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@907136 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-01-07 14:14:14 +00:00
Michael Jansen
fc80167a4f Fix build by copying strigis FindCppUnit.cmake to taglib. Build failed because CPPUNIT_LIBRARIES didn't
contain cppunits dependencies reported by cppunit-config.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@899928 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-12-21 21:46:41 +00:00
Michael Jansen
df3eb22060 Suppress warning about this check missing. if someone has a lower cmake version please check
and decrease the required version if successfull.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@899927 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-12-21 21:46:37 +00:00
Scott Wheeler
27e3643d19 Should fix the build.
CCMAIL:tbscope@gmail.com


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@892977 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-12-05 16:43:38 +00:00
Scott Wheeler
977ec6d41f warnings--
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@892694 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-12-05 00:37:39 +00:00
Scott Wheeler
e989d7ad1d fix warnings
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@892447 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-12-04 12:37:36 +00:00
Alexander Neundorf
e2c76396dd -INSTALL_DIR_NAME doesn't have to be set in the toplevel CMakeLists.txt, since it is already set as target property
-remove some unnecessary code
-use BIN_INSTALL_DIR for the RUNTIME destination

Alex




git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@891512 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-12-02 12:06:49 +00:00
Jeff Mitchell
5c0eb1d698 config.h doesn't exist, at least in my checkout, so explicitly defining HAVE_CONFIG_H was breaking build. I'm guessing this was a mistake, and should either be taken out, or
something needs to be fixed.

CCMAIL: lalinsky@gmail.com


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@883891 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-11-13 19:23:56 +00:00
Jeff Mitchell
1bcb9a6cc7 Add default case switch to fix compiler warnings when ASF or MP4 are not defined.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@883884 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-11-13 19:19:39 +00:00
Lukáš Lalinský
5df6ef092b Add my old WMA and MP4 code. It is disabled by default, must be explicitly enabled to be compiled.
Scott: If you think this is really a bad idea, please revert.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@883108 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-11-12 08:17:11 +00:00
Scott Wheeler
fa31fa29d7 typo
BUG:170036


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@854564 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-08-29 19:59:26 +00:00
Scott Wheeler
13fddc3974 Don't try to access the string list if the item type is a locator.
Allan, does this look correct?  (It at least fixes the crash...)

BUG:169810
CCMAIL:kde@carewolf.com


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@852712 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-08-26 12:19:47 +00:00
Scott Wheeler
d2a1cfa32d detach when using non-const operator[]
BUG:169389


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@850657 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-08-21 22:56:44 +00:00
Scott Wheeler
8434d19928 remove exec bit
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@824940 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-26 22:11:11 +00:00
Scott Wheeler
9947f45b31 Add support for private frames.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@824701 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-26 15:06:20 +00:00
Scott Wheeler
07a6c86a31 If the genre string is empty don't treat it as a number.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@823961 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-24 14:08:03 +00:00
Andy Goossens
bd90f1b9d4 SVN_SILENT: fix typo
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@822327 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-19 20:44:39 +00:00
Scott Wheeler
50fe14f4b7 add files here
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@822217 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-19 14:19:31 +00:00
Scott Wheeler
75579dc0dd Provisional .wav support. Tag writing will probably be disabled by default...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@822160 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-19 11:15:39 +00:00
Scott Wheeler
1d86a684b2 wrong copyright
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@821783 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-18 13:21:35 +00:00
Scott Wheeler
be99222f29 Add a warning here so that it's clear that this constructor is not to be used for setting the
object's data.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@821128 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-16 14:21:03 +00:00
Lukáš Lalinský
9ce4c72995 Fix reading of POPM rating -- it's unsigned char, not just char
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@811387 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-22 20:40:14 +00:00
Lukáš Lalinský
f6994ec26c Support for POPM ID3 frame
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@811137 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-22 12:06:45 +00:00
Benjamin Reed
51ca869f65 fix install_name RPATH stuff on OSX
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@810378 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-20 15:17:15 +00:00
Adriaan de Groot
55c788b608 Previous was me being stupid and too-quick on the commit button. Need unistd as well for read, write.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@810229 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-20 09:29:09 +00:00
Adriaan de Groot
3fe0895f62 Need plain <fcntl.h> for open and its flags, not necessarily sys/fcntl.h
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@810223 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-20 09:20:19 +00:00
Adriaan de Groot
388d0f353d ldexp is a c99-ism, which is not available in strict C++; use math.h as well to pull it in and hope for the best.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@808578 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-16 22:59:07 +00:00
Scott Wheeler
aec136f119 SVN_SILENT this isn't needed anymore
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@808293 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-16 09:47:19 +00:00
Scott Wheeler
08b6514420 Get all of the basic AIFF properties working.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@808275 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-16 08:50:17 +00:00
Scott Wheeler
c52f3a4974 Add a skeleton (unimplemented) AIFF properties class.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@808255 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-16 07:09:20 +00:00
Scott Wheeler
918366adcf Uff. Tabs-be-gone!
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@808250 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-16 07:05:55 +00:00
Scott Wheeler
5175ed952b Add AIFF here too.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@808247 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-16 06:47:29 +00:00
Scott Wheeler
ea839c286a update cmake files
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@808246 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-16 06:46:03 +00:00
Scott Wheeler
123aa8a775 And now make it work for non-existing RIFF chunks.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@808241 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-16 06:28:35 +00:00