Commit Graph

2401 Commits

Author SHA1 Message Date
Scott Wheeler
f181d1d18b SVN_SILENT accidentally inserted tabs
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@538782 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-05-08 20:49:01 +00:00
Scott Wheeler
3f3026b349 Add a function to set the default ID3v2 encoding in the C API.
BUG:126192


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@538781 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-05-08 20:45:42 +00:00
Scott Wheeler
02cf970e0d Patch from John Stirling to fix bitmasks for header fields.
BUG:70649


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@538764 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-05-08 20:08:33 +00:00
Scott Wheeler
fca59f432e docs typo
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@532016 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-04-20 20:31:25 +00:00
Scott Wheeler
985630d59a SVN_SILENT
Forgot to add docs.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@515072 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-03-02 15:13:54 +00:00
Scott Wheeler
3a24d31b43 Two things:
- Fix the channel mode, copyright and original flags, as noticed by
   Bjoern Petersen.
 - Check in the "findByDescription()" function that I've had sitting
   around for a while.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@515068 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-03-02 15:02:27 +00:00
Scott Wheeler
c35d249195 Add a wide string export fuction.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@508477 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-02-11 21:18:03 +00:00
Scott Wheeler
361ce1635a Alright -- most of this code is just more cleanups, and the bugfix part of it
is relatively small.  Basically it took a while for me to be convinced that the
ID3v2 location was always going to be before the FLAC data stream pointer.  I've
added a check to make sure that it stays that way, but I don't expect us to
actually hit that code.

BUG:120578


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503614 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-01-29 17:47:38 +00:00
Scott Wheeler
142ddfadc9 A prelude to bugfixing. A few more cleanups.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503592 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-01-29 16:59:40 +00:00
Scott Wheeler
286d474dae Cleanups -- no functional changes.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503573 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-01-29 16:06:07 +00:00
Scott Wheeler
99fbe7ff25 Fix up the stuff here for appending values to an APE::Item and round out the API a bit.
Based on Michael's patch...

BUG:120256


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503255 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-01-28 15:18:31 +00:00
Scott Wheeler
4841a5c39c If a frame has both compression and encryption, since we currently
don't support encrypted frames, don't try to decompress it.  Decryption
is supposed to be applied before decompression, so currently the decompression
isn't possible.

BUG:112919


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503234 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-01-28 14:00:48 +00:00
Scott Wheeler
59b9831868 Switch this to "rb" and "rb+" since Windows seems to barf on it without the "b"
and it doesn't make a difference at all on UNIX.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503213 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-01-28 13:40:05 +00:00
Scott Wheeler
1aa0550c58 Another method that didn't actually have an implementation around. Also
picked some default values for some of the d-pointer members.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@482863 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-11-24 10:27:45 +00:00
Scott Wheeler
18d80d1ea0 Actually implement this constructor...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@482540 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-11-23 10:36:06 +00:00
Scott Wheeler
2d06d23ec6 Missing class name on the method declaration. I'm sure this caused some
fun symbol conflicts...


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@482539 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-11-23 10:27:33 +00:00
Scott Wheeler
f9c5ecaf53 SVN_SILENT a couple of missing docs
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@471683 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-10-18 12:33:48 +00:00
Scott Wheeler
5bb7dbe457 Silly second declaration of the variable here that triggers an infinite
loop in some cases (I'm surprised that it doesn't happen in more...this
code has been around for a while.).

BUG:113437


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@464483 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-09-27 14:34:32 +00:00
Scott Wheeler
603068695c A couple of things pointed out by a colleage -- fix ByteVector::size()
and make the return type semantics consistant for methods that modify
the object (specifically, return a reference instead of void).


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@460002 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-09-12 16:52:07 +00:00
Scott Wheeler
5d64692084 Just a couple of docs updates.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@457702 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-09-06 11:39:26 +00:00
Scott Wheeler
78c4c18e37 Fix the documentation for this method.
CCMAIL:Umesh Shankar <ushankar@cs.berkeley.edu>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@457127 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-09-04 20:06:27 +00:00
Scott Wheeler
fa61e63ac8 Leave the year field blank if it's set to zero (i.e. cleared).
BUG:109920


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@444448 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-08-10 08:33:28 +00:00
Scott Wheeler
b16c8587ab Forgot that this doesn't work for those not using
my hacked up build environment for TagLib.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@439118 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-27 07:29:41 +00:00
Scott Wheeler
b84fdcfa04 Last docs updates and a small function signature change. I'm pretty sure that's it for 1.4.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@439059 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-27 00:25:40 +00:00
Scott Wheeler
585bf5afca note other bindings
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438757 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-26 00:37:39 +00:00
Scott Wheeler
3de9ba2e9f Bug in UTF-8 rendering. Small change, but well, without the "break;" it was doing
the UTF-8 rendering and the UTF16-LE rendering to the same string, which was, well,
ungood.

(Sorry Dan, that's bad news for those files -- but this bug was only introduced 4
days ago, so it just hadn't been caught yet.)

BUG:109604


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438731 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-25 21:34:18 +00:00
Scott Wheeler
f7467bd1f9 Don't actually install the tdebug.h header.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438704 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-25 19:51:52 +00:00
Scott Wheeler
eb592f0933 Don't include tdebug.h in any installed header. I'll remove it from installation
shortly.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438692 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-25 19:26:00 +00:00
Scott Wheeler
052a1d2720 Add a list of the default file extensions that TagLib knows about, as requested
by Stefan.  Also did a few additional updates on the API docs.

CCMAIL:Stefan Gehn <mETz81@web.de>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438212 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-24 16:25:33 +00:00
Scott Wheeler
54b442d584 SVN_SILENT another place to update the version
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438078 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-24 08:03:37 +00:00
Scott Wheeler
111b0dc6eb Make sure that buffer allocations for file reads aren't completely bogus.
Specifically make sure that we don't actually allocate a buffer for a read that
extends beyond the end of the file.

BUG:101401


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438035 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-23 23:49:29 +00:00
Scott Wheeler
59fd610999 Finally took Tommi's suggestion here and introduced a version of the ByteVectorList::split()
that takes a maximum number of values.  This should probably be used more widely in
places where the max is known ahead of time for this to be a more useful fix than nailing
just this special case.  Anyway, fixes the bug.

BUG:103622


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438030 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-23 23:11:20 +00:00
Scott Wheeler
073dee2e41 This is a better way of doing this too... Now I have to remember to
update the configure.in.in in the root...


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438007 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-23 21:46:39 +00:00
Scott Wheeler
ea2ac9fe64 Add pkg-config file.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438006 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-23 21:43:09 +00:00
Scott Wheeler
02f9b248a7 Bump to 1.4
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438002 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-23 20:58:43 +00:00
Scott Wheeler
ddd8c2f4c9 SVN_SILENT missing docs
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437534 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-22 09:03:15 +00:00
Scott Wheeler
02925797d2 Go ahead and increment the libtool version in preparation for 1.4.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437529 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-22 08:33:45 +00:00
Scott Wheeler
016a2c7b03 Add UTF16LE support. Patch mostly by Umesh Shankar.
BUG:106815


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437399 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-21 18:45:12 +00:00
Scott Wheeler
366a4bfe3f Hmm, that last one wasn't really quite ready. Now we actually check our list
of FileTypeResolvers.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437391 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-21 18:10:10 +00:00
Scott Wheeler
ec86c487e8 Add a mechanism for extending the file type resolution in JuK using FileRefs.
This is generally much better thought out than the current method of creating
FileRefs using the native mime system and also allows for extension to additional
file formats.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437382 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-21 17:45:23 +00:00
Scott Wheeler
87824b1737 Continuing going through my pile-o-patches:
Make it possible to save files using the save() with a tag mask
without stripping the tags that do not fit the mask.  I still need
to do a little testing on this to make sure that the offsets are
still computed correctly.

BUG:96460


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437380 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-21 17:33:36 +00:00
Scott Wheeler
ca839d884f If there is no value set for DESCRIPTION, also check COMMENT.
BUG:98714


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437379 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-21 17:30:03 +00:00
Scott Wheeler
a2972c8ae0 Add accessors for the image description.
BUG:94258


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437378 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-21 17:27:37 +00:00
Scott Wheeler
c756813a21 Fix up the RVA2 handling. I'm still not thrilled with the API, but this
should be functional enough to hold over to the next binary
incompatible change and has a minimum of differences to the previous
API.

I did a slightly nasty hack so that the API docs will see just methods
with an optional argument, but those are actually two separate methods
(for BC).

Brian, please feel free to take a look at this prior to 1.4 going out.

BUG:107025



git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437115 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-21 00:10:57 +00:00
Scott Wheeler
e321ae7774 Fix from Felix Berger to get RVA2 frames a little closer
to working.  The more complicated fix for #107025 will
follow shortly.

BUG:95545


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437091 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-20 22:23:34 +00:00
Thiago Macieira
19a0504dfd Adding and updating svn:ignore
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@435313 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-16 14:39:38 +00:00
Scott Wheeler
35a8c9a38b Misspelling.
BUG:107847


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@434245 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-13 12:22:34 +00:00
Scott Wheeler
1857e61a9d Instead of returning 0 on finding a deprecated frame type, create an
UnknownFrame and set the flag to discard it on write.

As a special bonus this meant implementing the discard-on-tag-alter
flag.

BUG:100515


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415248 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-05-17 23:57:23 +00:00
Scott Wheeler
6ceb7a8151 Patch from Umesh Shankar to make sure that the frameID is current.
CCMAIL:Umesh Shankar <ushankar@cs.berkeley.edu>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415233 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-05-17 22:38:01 +00:00
Scott Wheeler
10d8a4deac Check to make sure that there's content before trying to return it.
Almost the same as a patch from Clemens Fuchslocher 

CCMAIL:clemens@allesdurcheinander.de


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415211 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-05-17 21:27:51 +00:00