Commit Graph

227 Commits

Author SHA1 Message Date
9b7463225a Add a check to not crash on corrupted files
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1005918 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-08-02 15:17:36 +00:00
8636eb749a Handle RIFF chunk padding and ignore trailing garbage
This is based on patches by Marc Halbruegge, but those only deal with
read-only cases. The code now also correctly adds padding to RIFF
chunks, and calculates offsets in chunkData taking the padding into
account.

BUG:171957
BUG:175781


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1003745 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-28 18:29:39 +00:00
834d9d6b23 Partial support for 64-bit atoms
We still can't handle actual 64-bit atoms, but we can handle 32-bit sizes
stored in 64 bits.

CCBUG:198730


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1001897 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-24 13:08:51 +00:00
097ae0d785 Use flac padding.
Updated patch from Toby Dickenson

BUG:107659


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@995518 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-12 21:53:18 +00:00
7f0f90b4ea Make docs consistant with behavior.
BUG:178174


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@995471 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-12 19:54:46 +00:00
f7fc585665 Don't save ID3v2.2 frames.
Patch by Marc Halbruegge
BUG:176373


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994842 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-11 14:43:58 +00:00
0f11c5ab0c Support for ID3v2.2 PIC frames
Patch by Marc Halbruegge
BUG:167786


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994836 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-11 14:27:17 +00:00
39e6891c92 Fix off-by-one error in ByteVectorList::split
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994815 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-11 13:24:21 +00:00
5e1eb18df9 Try to read track also from TRACKNUM and year from YEAR.
Patch by David Bishop
BUG:144396


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994811 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-11 13:17:06 +00:00
59e35efc1b TCON parsing fixes
* Don't join multiple 2.4 TCON fields together
 * Don't add duplicate fields for 2.3 genres where the refinement matches the ID3v1 genre

Patch by Michael Smith
BUG:188578


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994805 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-11 12:55:36 +00:00
c92a02b0d7 One more check for invalid frame in AttachedPictureFrame::parseFields
Patch by Mook
BUG:168382


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994361 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-10 14:43:15 +00:00
b70e3b2304 Use floting point length to calculate bitrate from the Xing header information
Patch by Mook
BUG:172556


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994337 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-10 14:34:04 +00:00
be640ed19f Build on Haiku
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@990628 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-02 20:54:32 +00:00
b19a4cf81c .oga files were not processed. Fix this. The problem was that even if the extension was defined in defaultFileExtensions(), it was not defined in create() so the file was never processed. As a
nice side effect, it also fixes the Amarok bug that caused .oga files not to be picked up by the collection scanner.

BUG:178602


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@983337 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-06-18 02:15:19 +00:00
901a427d1f Fix typo
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@982404 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-06-15 19:40:33 +00:00
fd20da2ef8 Fix a stupid crash inside mp4file.cpp (variable not initialized)
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@978719 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-06-07 23:05:11 +00:00
0974882ecd Simplify extension checking in FileRef
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@961189 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-04-29 16:00:39 +00:00
a9bce47f96 Add String:rfind
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@961188 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-04-29 15:57:05 +00:00
321997c399 Make FileRef handle the .mp4 extension, too
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@961181 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-04-29 15:46:23 +00:00
94a402395b Fix off-by-one error in MP4::Tag when looking for free padding to use
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@961160 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-04-29 15:12:19 +00:00
f1a16bcf0f Style and safety fixes backported from taglib-extras
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@961000 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-04-29 12:55:33 +00:00
1eace99153 Detach before appending a character
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@944552 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-25 17:52:23 +00:00
98d2808c17 this modified version has the advantage that it compiles
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@942892 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-22 20:48:27 +00:00
fad967ae0b Less of The Big Ugly in the middle of the classes.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@942880 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-22 19:27:38 +00:00
56e8766126 Added GCC pragma to suppress non-virtual dtor warning which is being preserved
to maintain BIC.



git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@942876 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-22 19:06:05 +00:00
36a398a156 Finish making .asf readable, thanks Lukas
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@937985 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-10 22:33:13 +00:00
f1fd227fce Several of us have seen .asf WMA files in the wild.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@937972 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-10 22:02:20 +00:00
66b3a1a184 Patch from Josef Radinger fixing typo in debug message.
BUG:30212
CCMAIL:taglib-devel@kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@911772 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-01-16 05:16:48 +00:00
4fbd7c5d93 revert last
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@909079 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-01-10 23:15:33 +00:00
3a390a11d0 Also counts as being empty.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@909060 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-01-10 22:21:45 +00:00
16a7efcd1c remove debug line from mac os framework build file
CCMAIL:taglib-devel@kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@907136 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-01-07 14:14:14 +00:00
27e3643d19 Should fix the build.
CCMAIL:tbscope@gmail.com


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@892977 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-12-05 16:43:38 +00:00
977ec6d41f warnings--
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@892694 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-12-05 00:37:39 +00:00
e989d7ad1d fix warnings
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@892447 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-12-04 12:37:36 +00:00
e2c76396dd -INSTALL_DIR_NAME doesn't have to be set in the toplevel CMakeLists.txt, since it is already set as target property
-remove some unnecessary code
-use BIN_INSTALL_DIR for the RUNTIME destination

Alex




git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@891512 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-12-02 12:06:49 +00:00
5df6ef092b Add my old WMA and MP4 code. It is disabled by default, must be explicitly enabled to be compiled.
Scott: If you think this is really a bad idea, please revert.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@883108 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-11-12 08:17:11 +00:00
fa31fa29d7 typo
BUG:170036


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@854564 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-08-29 19:59:26 +00:00
13fddc3974 Don't try to access the string list if the item type is a locator.
Allan, does this look correct?  (It at least fixes the crash...)

BUG:169810
CCMAIL:kde@carewolf.com


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@852712 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-08-26 12:19:47 +00:00
d2a1cfa32d detach when using non-const operator[]
BUG:169389


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@850657 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-08-21 22:56:44 +00:00
8434d19928 remove exec bit
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@824940 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-26 22:11:11 +00:00
9947f45b31 Add support for private frames.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@824701 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-26 15:06:20 +00:00
07a6c86a31 If the genre string is empty don't treat it as a number.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@823961 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-24 14:08:03 +00:00
bd90f1b9d4 SVN_SILENT: fix typo
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@822327 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-19 20:44:39 +00:00
50fe14f4b7 add files here
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@822217 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-19 14:19:31 +00:00
75579dc0dd Provisional .wav support. Tag writing will probably be disabled by default...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@822160 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-19 11:15:39 +00:00
1d86a684b2 wrong copyright
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@821783 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-18 13:21:35 +00:00
be99222f29 Add a warning here so that it's clear that this constructor is not to be used for setting the
object's data.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@821128 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-16 14:21:03 +00:00
9ce4c72995 Fix reading of POPM rating -- it's unsigned char, not just char
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@811387 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-22 20:40:14 +00:00
f6994ec26c Support for POPM ID3 frame
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@811137 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-22 12:06:45 +00:00
388d0f353d ldexp is a c99-ism, which is not available in strict C++; use math.h as well to pull it in and hope for the best.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@808578 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-16 22:59:07 +00:00