Lukáš Lalinský
8878c9158c
Upgrade IPLS (2.3) to TIPL (2.4)
2011-04-05 17:08:25 +02:00
Lukáš Lalinský
3715b96477
Protect against incorrect ID3v2 version parameter
2011-04-05 15:36:23 +02:00
Lukáš Lalinský
aa57db3a39
Convert frames TIPL and TMCL (2.4) to IPLS (2.3)
2011-04-05 15:16:17 +02:00
Lukáš Lalinský
d3df66f196
Convert TDRC to TYER+TDAT+TIME
2011-03-16 22:54:58 +01:00
Lukáš Lalinský
e8d0551c9a
Simple ID3v2.4 => ID3v2.3 frame migration
2011-03-16 17:14:36 +01:00
Lukáš Lalinský
061b381ea8
Make sure we don't write UTF8 or UTF16BE to ID3v2.3 tags
2011-03-15 21:57:49 +01:00
Lukáš Lalinský
1802237c75
Support for writing structuraly correct ID3v2.3 tags
...
We don't use the tag footer, extended header or unsynchronization, so we
only need to change the frame size format.
Note that this doesn't write correct ID3v2.3 tags, just tags that have
the correct structure. The content is sill incorrect, unless you add
the right frames manually to the tag instance.
2011-03-15 20:50:47 +01:00
Lukáš Lalinský
2f9838a440
*poof*
...
I've warned people about removing autoconf/automake support for a long time,
so let's make it happen for 1.7. CMake is now the only supported build system.
I'll update build docs in a following commit.
CCMAIL:taglib-devel@kde.org
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1220235 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2011-02-13 11:50:25 +00:00
Lukáš Lalinský
299e3f0ad6
Define a macro to properly construct std::bitset
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1216679 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2011-01-24 07:32:31 +00:00
Lukáš Lalinský
df86f45dad
Back to unsigned long, it breaks compilation on Solaris
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1216598 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2011-01-24 06:02:15 +00:00
Lukáš Lalinský
b051df0062
Fix compilation on MSVC 2010 with the C++0x version of std::bitset
...
Hopefuly it doesn't break anything on older compilers...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1216365 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2011-01-22 21:07:16 +00:00
Lukáš Lalinský
393e9c5572
Fix FSF address
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1212872 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2011-01-08 11:20:09 +00:00
Lukáš Lalinský
6f68c30db3
Fix memory leak in AttachedPictureFrameV22
...
BUG:257007
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1212871 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2011-01-08 11:14:47 +00:00
Lukáš Lalinský
0f979667be
Don't unnecessarily include whole <iostream>
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1153989 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2010-07-24 13:17:01 +00:00
Lukáš Lalinský
9dcdecc810
Fix parsing of regular 32-bit integers in SynchData::toUInt()
...
BUG:231075
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1115275 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2010-04-15 20:22:21 +00:00
Lukáš Lalinský
19b2341411
Fix upgrading of ID3v2.3 genre with number 0 (Blues)
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1114089 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2010-04-12 18:27:59 +00:00
Scott Wheeler
c823c21eb2
Forward declarations don't need exports.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1111035 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2010-04-04 17:33:01 +00:00
Lukáš Lalinský
e76466097b
Don't upgrade ID3v2.2 TDA frame when upgrading to TRCD
...
We already do this for TDAT. Using both parts, the year and the date,
would be better we the code currently doesn't have enough context to
do that.
BUG:228968
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1110552 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2010-04-03 16:58:03 +00:00
Scott Wheeler
4202ce3ec9
Update .pro file
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1100537 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2010-03-07 19:03:35 +00:00
Scott Wheeler
5df7692aa1
pedantry++
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1057066 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-12-01 12:01:43 +00:00
Peter van Hardenberg
85df71ea2e
When decoding syncsafe integers, assume non-syncsafe integers are written by buggy software and treat them as normal integers.
...
From Songbird bug 12964, original author Mike Smith (msmith@songbirdnest.com )
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1056922 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-12-01 09:11:21 +00:00
Scott Wheeler
2039c725f4
Missing "not" in docs.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1042978 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-10-31 11:32:31 +00:00
Lukáš Lalinský
ea9dbfd7ae
Add missing exports for a few public ID3v1 functions
...
Patch by Modestas Vainius
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1038114 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-10-20 16:45:10 +00:00
Lukáš Lalinský
18c621cdc2
Always use #include "XXX" in TagLib's code
...
Patch by Stephen F. Booth, thanks!
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1033289 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-10-09 21:03:59 +00:00
Lukáš Lalinský
cf83551c93
Define MAKE_TAGLIB_LIB from the automake build system
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1019659 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-09-04 09:07:27 +00:00
Lukáš Lalinský
0adea10728
Fix compilation warnings
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1019655 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-09-04 08:50:24 +00:00
Lukáš Lalinský
f7fc585665
Don't save ID3v2.2 frames.
...
Patch by Marc Halbruegge
BUG:176373
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994842 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-11 14:43:58 +00:00
Lukáš Lalinský
0f11c5ab0c
Support for ID3v2.2 PIC frames
...
Patch by Marc Halbruegge
BUG:167786
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994836 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-11 14:27:17 +00:00
Lukáš Lalinský
59e35efc1b
TCON parsing fixes
...
* Don't join multiple 2.4 TCON fields together
* Don't add duplicate fields for 2.3 genres where the refinement matches the ID3v1 genre
Patch by Michael Smith
BUG:188578
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994805 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-11 12:55:36 +00:00
Lukáš Lalinský
c92a02b0d7
One more check for invalid frame in AttachedPictureFrame::parseFields
...
Patch by Mook
BUG:168382
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994361 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-10 14:43:15 +00:00
Lukáš Lalinský
b70e3b2304
Use floting point length to calculate bitrate from the Xing header information
...
Patch by Mook
BUG:172556
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994337 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-10 14:34:04 +00:00
Scott Wheeler
fad967ae0b
Less of The Big Ugly in the middle of the classes.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@942880 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-22 19:27:38 +00:00
Andrew Coles
56e8766126
Added GCC pragma to suppress non-virtual dtor warning which is being preserved
...
to maintain BIC.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@942876 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-22 19:06:05 +00:00
Scott Wheeler
66b3a1a184
Patch from Josef Radinger fixing typo in debug message.
...
BUG:30212
CCMAIL:taglib-devel@kde.org
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@911772 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-01-16 05:16:48 +00:00
Scott Wheeler
27e3643d19
Should fix the build.
...
CCMAIL:tbscope@gmail.com
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@892977 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-12-05 16:43:38 +00:00
Scott Wheeler
977ec6d41f
warnings--
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@892694 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-12-05 00:37:39 +00:00
Scott Wheeler
fa31fa29d7
typo
...
BUG:170036
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@854564 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-08-29 19:59:26 +00:00
Scott Wheeler
8434d19928
remove exec bit
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@824940 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-26 22:11:11 +00:00
Scott Wheeler
9947f45b31
Add support for private frames.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@824701 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-26 15:06:20 +00:00
Scott Wheeler
07a6c86a31
If the genre string is empty don't treat it as a number.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@823961 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-24 14:08:03 +00:00
Andy Goossens
bd90f1b9d4
SVN_SILENT: fix typo
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@822327 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-19 20:44:39 +00:00
Scott Wheeler
be99222f29
Add a warning here so that it's clear that this constructor is not to be used for setting the
...
object's data.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@821128 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-06-16 14:21:03 +00:00
Lukáš Lalinský
9ce4c72995
Fix reading of POPM rating -- it's unsigned char, not just char
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@811387 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-22 20:40:14 +00:00
Lukáš Lalinský
f6994ec26c
Support for POPM ID3 frame
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@811137 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-22 12:06:45 +00:00
Scott Wheeler
d4527a0141
Do a dynamic_cast on these instead of a static since in the case of a non-supported
...
frame flag the frame will still be added to the list, but using the UnknownFrame type
rather than the canonical type. At the moment, on systems with a build in zlib, this
should only happen for the (very rare) encrypted frames.
BUG:161721
CCMAIL:taglib-devel@kde.org
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@805637 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-09 00:16:30 +00:00
Lukáš Lalinský
705fa9d79b
Fix compilation on MSVC/Windows
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@777124 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-02-19 19:52:04 +00:00
Scott Wheeler
8cfcb4823f
Fix the APE positioning code. This obviously never worked properly...
...
BUG:112904
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@774316 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-02-12 23:45:42 +00:00
Scott Wheeler
8ed12b31d3
more API review
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@774207 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-02-12 18:49:18 +00:00
Scott Wheeler
7a9fcd2079
Add the 2.2 and 2.3 standards for convenience.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@774079 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-02-12 13:26:45 +00:00
Scott Wheeler
fe1a5cda85
doc review
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@773921 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-02-12 04:57:37 +00:00