Commit Graph

44 Commits

Author SHA1 Message Date
Lukáš Lalinský
5e1eb18df9 Try to read track also from TRACKNUM and year from YEAR.
Patch by David Bishop
BUG:144396


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994811 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-11 13:17:06 +00:00
Lukáš Lalinský
59e35efc1b TCON parsing fixes
* Don't join multiple 2.4 TCON fields together
 * Don't add duplicate fields for 2.3 genres where the refinement matches the ID3v1 genre

Patch by Michael Smith
BUG:188578


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@994805 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-07-11 12:55:36 +00:00
Lukáš Lalinský
a9bce47f96 Add String:rfind
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@961188 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-04-29 15:57:05 +00:00
Lukáš Lalinský
94a402395b Fix off-by-one error in MP4::Tag when looking for free padding to use
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@961160 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-04-29 15:12:19 +00:00
Lukáš Lalinský
33b939c76f Don't build ASF/MP4 FileRef tests if WITH_ASF/WITH_MP4 are undefined
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@945359 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-27 10:45:00 +00:00
Lukáš Lalinský
1eace99153 Detach before appending a character
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@944552 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2009-03-25 17:52:23 +00:00
Alexander Neundorf
e2c76396dd -INSTALL_DIR_NAME doesn't have to be set in the toplevel CMakeLists.txt, since it is already set as target property
-remove some unnecessary code
-use BIN_INSTALL_DIR for the RUNTIME destination

Alex




git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@891512 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-12-02 12:06:49 +00:00
Lukáš Lalinský
5df6ef092b Add my old WMA and MP4 code. It is disabled by default, must be explicitly enabled to be compiled.
Scott: If you think this is really a bad idea, please revert.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@883108 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-11-12 08:17:11 +00:00
Lukáš Lalinský
9ce4c72995 Fix reading of POPM rating -- it's unsigned char, not just char
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@811387 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-22 20:40:14 +00:00
Lukáš Lalinský
f6994ec26c Support for POPM ID3 frame
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@811137 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-22 12:06:45 +00:00
Adriaan de Groot
55c788b608 Previous was me being stupid and too-quick on the commit button. Need unistd as well for read, write.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@810229 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-20 09:29:09 +00:00
Adriaan de Groot
3fe0895f62 Need plain <fcntl.h> for open and its flags, not necessarily sys/fcntl.h
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@810223 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-05-20 09:20:19 +00:00
Andreas Hartmetz
bbfcc84dec add missing include; fixes compilation with tests
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@794194 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-04-06 21:22:49 +00:00
Scott Wheeler
12a884e122 Messed with things until the algorithm is correct. rfind now passes all unit tests.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@773913 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-02-12 03:20:30 +00:00
Scott Wheeler
ee557e29d5 switch to the not-in-place variety of this function
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@773878 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-02-11 22:50:46 +00:00
Lukáš Lalinský
b8435c1ad5 Tweaks to preparing UTF-16 strings with BOM
- '\xFF\xFE' and '\xFE\xFF' are valid, but empty, UTF-16 strings -- don't print a warning
 - print a warning on strings that don't start with a valid BOM

BUG:156076


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@764385 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-21 16:40:07 +00:00
Lukáš Lalinský
49bcce586a Add a test case for reading APIC frames with descriptions in UTF-16 including BOM
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@764373 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-21 15:46:12 +00:00
Lukáš Lalinský
c4a21adb8e Add a hack to read ID2v2.4 frames with v2.3-like sizes, written by iTunes.
The code is inside a '#ifndef NO_ITUNES_HACKS' block, so I hope it's ok to add it.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@743534 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-12-01 09:15:23 +00:00
Lukáš Lalinský
fed2c020fe Fix TTA audio properties reading.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@740388 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-23 06:54:22 +00:00
Lukáš Lalinský
46fbd11d8f Use correct frame sizes when calculating length of MPEG 2 or 2.5 streams.
CCBUG:130185


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@740177 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-22 18:55:47 +00:00
Lukáš Lalinský
e06495a7e3 Support for URL link framesSupport for URL link frames, patch by Urs Fleisch.
BUG:151079
CCMAIL:ufleisch@users.sourceforge.net


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@740080 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-22 13:48:01 +00:00
Lukáš Lalinský
51a5ae46b1 Revert r735160 and r735161, and set BUILD_TESTS to OFF if CppUnit is not found.
CCMAIL:michael.pyne@kdemail.net


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@740071 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-22 13:17:15 +00:00
Michael Pyne
438927762c This also breaks compilation of kdesupport. CppUnit won't be found since I commented
out the configure check is fixed.  Once the configure check is fixed this can be
commented back in.

CCMAIL:lalinsky@gmail.com


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735161 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-11 03:30:44 +00:00
Lukáš Lalinský
049f77f0d9 TrueAudio support.
This is last of the three formats implemented for libtunepimp, now used also by various players.

BUG:114982


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735116 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 22:55:14 +00:00
Lukáš Lalinský
2462905fe0 Fix ID3v2::UniqueFileIdentifier frame parsing.
According to the spec, the identifier contains arbitrary binary data (which
includes \0). That means splitting it on \0 and checking if we have only
two parts is wrong, because it rejects valid frames.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735109 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 22:20:33 +00:00
Lukáš Lalinský
41bc6f0686 Fix off-by-one error in ByteVector::find.
In case where the pattern has the same length as the bytevector, it should
degrade to A == B, not just return "not found" (e.g. A.find(A) should
return 0, not -1).


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735107 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 22:16:56 +00:00
Lukáš Lalinský
b44cee48f4 Add methods RelativeVolumeFrame::identification and RelativeVolumeFrame::setIdentification.
BUG:150481


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735098 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 21:32:32 +00:00
Lukáš Lalinský
673b77c3ac - Fixed crash in AttachedPictureFrame and GeneralEncapsulatedObjectFrame
caused by using uninitialized pointer. (BUG:151078)
- Make Frame::readStringField to actually read the string field.
- Fixed parsing of APIC frames -- there is one-byte type between mime type
  and description. The code worked only thanks to the previous bug.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735035 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 18:03:25 +00:00
Lukáš Lalinský
db0be6b8c6 Add a CppUnit-based test suite (only very few things is covered for now, but it's a start).
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@734995 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 16:46:04 +00:00
Dirk Mueller
26751ba95b the usual daily unbreak compilation
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@670244 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-05-31 20:51:55 +00:00
Brad Hards
4edbc93494 Change the taglib build system to use relative include paths.
This allows you to build taglib either as part of kdesupport
(i.e. with a source directory of kdesupport/) or by itself
(i.e. with a source directory of kdesupport/taglib/).


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@593544 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-10-08 06:28:19 +00:00
Laurent Montel
619b1eaf54 Add tests directory into build
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@592361 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-10-04 15:12:47 +00:00
Scott Wheeler
f162c5f5f9 And now get everything building again...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@588037 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-09-24 18:10:30 +00:00
Scott Wheeler
9a2f90be89 Re-add automake/autoconf stuff. I'm tempted to delete the CMake stuff while I'm
at it, but I'll leave it for now...


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@587989 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-09-24 16:17:47 +00:00
Laurent Montel
0b428130f3 Now taglib compiles with cmake
Remove old build system


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@587949 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-09-24 14:45:33 +00:00
Laurent Montel
0a3ae0b2f5 Fix it
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@586717 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-09-20 12:58:37 +00:00
Laurent Montel
e3cf99c87a Add cmake support
All compile need to test now


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@586714 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-09-20 12:52:28 +00:00
Scott Wheeler
603068695c A couple of things pointed out by a colleage -- fix ByteVector::size()
and make the return type semantics consistant for methods that modify
the object (specifically, return a reference instead of void).


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@460002 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-09-12 16:52:07 +00:00
Scott Wheeler
ec86c487e8 Add a mechanism for extending the file type resolution in JuK using FileRefs.
This is generally much better thought out than the current method of creating
FileRefs using the native mime system and also allows for extension to additional
file formats.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437382 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-21 17:45:23 +00:00
Scott Wheeler
237ea76ef6 Make this check current with the bytevector code.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306700 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-27 01:09:48 +00:00
Scott Wheeler
cfbc564bb6 Add a check for the toInt() stuff.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306691 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-26 23:05:36 +00:00
Scott Wheeler
d21fa22260 Add a couple of testcases that point out UTF16 bugs.
CCMAIL:Ilya Konstantinov <future@shiny.co.il>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@288628 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-02-17 02:56:10 +00:00
Scott Wheeler
bfd0be4c7d Fixed problem with TagLib reading 1 byte fields in ID3v2 tags.
CCMAIL:Stefan Gehn <sgehn@gmx.net>
CCMAIL:Keith Brady <keith@funnelboy.org>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@288618 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-02-17 02:11:05 +00:00
Scott Wheeler
7fe6647435 This commit was manufactured by cvs2svn to accommodate
a server-side copy/move.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@288617 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-02-17 02:11:05 +00:00