mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2026-08-27 12:47:01 -04:00
Code Issues Packages Projects Releases Wiki Activity
1,467 Commits 5 Branches 37 Tags
3bea9f6bee9f1d989e0f754d6ff9fa27d682285c
Commit Graph
256 Commits
Author SHA1 Message Date
Scott Wheeler 3bea9f6bee Don't use tempnam on UNIX 
This silences the huge stream of warnings when building the tests.

I think I didn't break the Windows version in the process (though
it may make sense to use the built in Windows functions there
instead), but I don't have a Windows build environment here, so
I can't test.
 2015-05-20 11:45:32 +02:00
Tsuda Kageyu 2268efb49e Add a test for strings that contains surrogate pairs. 2015-05-19 09:01:47 +09:00
Scott Wheeler bd3c4dc1b2 Merge pull request #515 from TsudaKageyu/empty-id3v2-frame 
Skip empty ID3v2 frames when saving an ID3v2 tag.
 2015-05-18 21:36:37 +02:00
Scott Wheeler bba562b557 Add accessors to manipulate MP4 tags without modifying the internal structure 
This brings the MP4 API in line closer to other tag formats and makes it
possible to access the tag data from const functions.

"ItemListMap" has been renamed to "ItemMap" (with the old version
deprecated).  It seems that the "ListMap" notion was copied probably
from Allan's ApeTag implementation, which incorrectly copied the term
from the XiphTag.  Notably, in XiphTag, because a field can have multiple
values, the "ListMap" is a map of lists.  Calling things a "ListMap" where
there can be only one value doesn't fit.

Closes #255
 2015-05-18 21:18:33 +02:00
Scott Wheeler 451d23ca37 Add isEmpty() to MP4 
Closes #457
 2015-05-18 20:30:19 +02:00
Scott Wheeler d248f77ab9 Show something useful for ChapterFrame::toString() 
Closes #517
 2015-05-18 19:51:18 +02:00
Scott Wheeler 7316cd331d Remove the null termination stuff from the ToC frames too 2015-05-18 18:17:10 +02:00
Scott Wheeler 3a977c55c4 We've moved away from including the null byte in the returned value 
This does change previous behavior, but the previous behavior was
particularly stupid and inconsistent with everything else in TagLib.

It should be possible to mitigate this by putting the same safety
guards in the TableOfContents
 2015-05-18 17:29:52 +02:00
Scott Wheeler a094ce7dd2 Don't underflow if there are no embedded frames 
Closes #513
 2015-05-18 17:11:18 +02:00
Scott Wheeler ffb543acbb Split chapter data and embedded frame data 
This will allow us to test parsing them separately
 2015-05-18 16:45:57 +02:00
Scott Wheeler fc24b3d22b Don't require users to include a padding byte explicitly 
This makes it where the natural construction can be used of something
like:

new ChapterFrame("ID", ... )

Closes #514
 2015-05-18 16:41:30 +02:00
Scott Wheeler a9e064c58e Also test second constructor 2015-05-18 16:30:37 +02:00
Tsuda Kageyu 8da0013482 Add a test to check if an empty ID3v2 frame is really skipped. 2015-05-18 19:03:20 +09:00
Tsuda Kageyu a924ca0db7 Expand the internal buffer of ByteVector only if really needed. 
Add tests for all execution paths of ByteVector::resize().
 2015-05-14 11:20:35 +09:00
Tsuda Kageyu ff8443f33a Fix the wrong padding of ByteVector::resize(). 
The expanded area will be filled with garbage instead of correct padding in some corner cases.
 2015-05-02 02:43:08 +09:00
Tsuda Kageyu 00e3504264 A little robuster tests for ByteVector iterators after detaching. 2015-04-29 17:15:13 +09:00
Tsuda Kageyu ab047f6054 Fix ByteVector to return correct iterators after detached. 2015-04-29 10:28:08 +09:00
Stephen F. Booth 066b5aa57e Merge pull request #492 from TsudaKageyu/duplicate-id3v2-aiff-wav 
Check AIFF/WAV files for duplicate tags.
 2015-03-25 08:16:41 -04:00
Tsuda Kageyu 4c4be0a263 Add a dummy byte to an empty ID3v2 frame to stick to the ID3v2 spec. 2015-03-22 22:14:21 +09:00
Tsuda Kageyu 68c0b0591b Fix a bug that Tag::setProperties() clears the date instead of the track number. 2015-03-20 13:33:13 +09:00
Tsuda Kageyu b69973bcf2 Fix infinite loops when parsing MP4 files. 2015-02-18 11:33:10 +09:00
Tsuda Kageyu 30eac7569f Check AIFF/WAV files for duplicate tags. 
AIFF/WAV files can have duplicate tags and it leads to memory leak.
 2015-02-18 11:31:55 +09:00
Tsuda Kageyu 0839a23902 Separate the tests for fuzzed APE files. 2015-02-17 12:36:57 +09:00
Tsuda Kageyu e463d14f2e Check for EOF to fix a segfault while parsing fuzzed MPC files. 2015-02-17 01:22:39 +09:00
Tsuda Kageyu 829ae2112a Check the packet size to fix a segfault error while parsing fuzzed MPC files. 2015-02-17 01:22:39 +09:00
Tsuda Kageyu 65664e6855 Check for EOF to fix an infinite loop while parsing fuzzed MPC files. 2015-02-17 01:22:39 +09:00
Tsuda Kageyu 2193d6dd84 Fix an out-of-bounds access and consequent errors while parsing fuzzed MPC files. 
Consequent errors may vary: segfault, zerodiv and so forth.
 2015-02-17 01:22:38 +09:00
Tsuda Kageyu 2b5ee8deb9 Fix saving ID3v2/INFO tags of WAV files. 
The old tag won't be removed when the new tag is empty.
 2015-01-30 14:51:28 +09:00
Tsuda Kageyu 9d91610fc0 Fix a wrong parameter for zlib. 
z_stream.avail_in has to be the length of the input buffer.
It will fail when frameDataLength is smaller than the actual compressed data size.
 2015-01-06 18:45:42 +09:00
Tsuda Kageyu c6a63a3a2f Implement missing AIFF::File::hasID3v2Tag(). 2015-01-05 18:20:31 +09:00
Tsuda Kageyu ed253d3691 Add some tests for huge memory allocation due to bad ID3v2 frame header flags. 
The tests covers #466 and #486.
Also fixes a compilation error on some compilers.
 2015-01-05 09:34:30 +09:00
Lukáš Lalinský 31982660c8 Merge pull request #485 from TsudaKageyu/oga-segfault 
Fix a segfault when reading faulty Ogg/FLAC files.
 2015-01-01 19:48:23 +01:00
Tsuda Kageyu 7adea3df22 Separate tests for fuzzed WAV files. 2015-01-01 23:18:43 +09:00
Tsuda Kageyu 5ebb2ece80 Fix a segfault when reading faulty Ogg/FLAC files. 2015-01-01 19:59:30 +09:00
Tsuda Kageyu 0d2e01df61 Fix a segfault when parsing WAV properties. 2014-12-31 01:46:30 +09:00
Tsuda Kageyu 695fb5ec16 Add a test for fuzzed WAV files. 2014-12-31 01:44:25 +09:00
Tsuda Kageyu 977fb2aeb0 Fix compilation errors on Clang. 2014-12-31 00:41:22 +09:00
Tsuda Kageyu 3b8c7d4e3a Add support for AIFF-C files. 2014-12-30 23:53:40 +09:00
Lukáš Lalinský be33389884 Merge pull request #476 from TsudaKageyu/fuzzed-ape 
Some fixes for fuzzed APE files.
 2014-12-29 09:47:10 +01:00
Lukáš Lalinský 59ae61de6e Merge pull request #456 from TsudaKageyu/id3v2-padding 
ID3v2 padding won't increase beyond 1% of the file size.
 2014-12-29 09:26:55 +01:00
Tsuda Kageyu 16ac2cd240 Added some tests for fuzzed APE files. 2014-12-23 21:02:00 +09:00
Lukáš Lalinský f30f5ccce5 Merge pull request #441 from xhochy/tests-fix-vectorsize 
Fix ByteVector sizes in some test cases
 2014-12-08 09:36:28 -08:00
Tsuda Kageyu d80c4c96c3 ID3v2 padding won't increase beyond 1% of the file size. 2014-10-23 12:38:38 +09:00
Tsuda Kageyu 269e78f1a0 Add a test for duplicate ID3v2 tags. 2014-10-21 00:16:43 +09:00
Scott Wheeler bd7419f0bd Rebuild TRDC from v2.3 fields 
This fixes an issue that was reported to me via email with the recording
date being thrown away from v2.3 tags.
 2014-09-25 23:07:09 +02:00
Scott Wheeler 71c1ce375f Don't leak 2014-09-25 20:46:47 +02:00
Scott Wheeler 0051351ebb TableOfContents and ChapterFrame can be added to v2.3 or v2.4 tags 2014-09-25 20:01:00 +02:00
Scott Wheeler 82315276db Take ownership of embedded frames, as documented 
Previously embedded frames that were created automatically were
never deleted.

Fixes #440
 2014-09-18 16:23:28 +02:00
Uwe L. Korn ee283789b7 Fix ByteVector sizes in some test cases 2014-09-14 20:08:31 +01:00
Uwe L. Korn 205569c8d2 Fix various memleaks in the tests 2014-09-14 18:03:27 +01:00