Tsuda Kageyu
da14f67e2c
MP4: Do rounding when calculating the bit rate.
2015-06-18 17:00:10 +09:00
Tsuda Kageyu
9226fa76b3
MP4: AudioProperties improvements
...
Add lengthInSeconds(), lengthInMilliseconds() properties. (#503 )
Add some tests for audio properties.
Add some supplementary comments.
Move parsing code to read() for consistency with other classes.
2015-06-18 17:00:10 +09:00
Tsuda Kageyu
ff36648e92
ASF: AudioProperties improvements
...
Add lengthInSeconds(), lengthInMilliseconds() properties. (#503 )
Add bitsPerSample() property. (#360 )
Add some tests for audio properties.
Add some supplementary comments.
2015-06-18 16:33:56 +09:00
Scott Wheeler
447a4739c5
Merge pull request #611 from TsudaKageyu/fix-bufsize
...
Fix mismatched file I/O buffer sizes.
2015-06-18 08:22:59 +02:00
Tsuda Kageyu
f15fe869a5
Add a test for APE files with an ID3v2 tag.
2015-06-18 14:41:37 +09:00
Tsuda Kageyu
125d887b85
APE: Use the audio stream length in calculating the bit rate.
2015-06-18 14:41:37 +09:00
Tsuda Kageyu
9a8e41b9d6
APE: AudioProperties improvements
...
Add lengthInSeconds(), lengthInMilliseconds() properties. (#503 )
Enable to read bit depth from older version files. (#360 )
Remove some data members which are not needed to carry.
Add some tests for audio properties.
Add some supplementary comments.
2015-06-18 14:41:37 +09:00
Tsuda Kageyu
68ef160dbc
Fix mismatched file I/O buffer sizes.
2015-06-18 11:23:31 +09:00
Scott Wheeler
6d71bdf8b7
Merge pull request #607 from TsudaKageyu/unused-function
...
Remove some unused private function prototypes.
2015-06-15 21:15:08 +02:00
Tsuda Kageyu
b37eaace15
Removed an unused data member from MPE::File.
...
It seems to be related to scan().
2015-06-12 14:07:52 +09:00
Tsuda Kageyu
c1c70edb76
Remove some unused private function prototypes.
2015-06-12 11:50:38 +09:00
Tsuda Kageyu
75159d5d8a
Silence a GCC warning about ignoring a return value in test.
2015-06-10 03:44:30 +09:00
Stephen F. Booth
46862bf537
Merge pull request #594 from TsudaKageyu/typos-in-comment
...
Fix some typos in comments.
2015-06-08 22:19:27 -04:00
Tsuda Kageyu
2b260fd2e8
Fix some typos in comments.
2015-06-09 10:33:32 +09:00
Scott Wheeler
b1a35a8b31
Add const to docs
2015-06-03 01:21:12 +02:00
Stephen F. Booth
88ef556d4e
Merge pull request #591 from TsudaKageyu/wmemcpy
...
Use wmemcpy() rather than memcpy() and sizeof(wchar_t).
2015-06-02 08:19:33 -04:00
Tsuda Kageyu
0c0f123a08
Use wmemcpy() rather than memcpy() and sizeof(wchar_t).
2015-06-01 13:52:55 +09:00
Festus Hagen
48311cca14
Undo comment stacking.
2015-05-31 22:12:18 -04:00
Michael Helmling
db90f4b358
Prefix #ifndef with TAGLIB_ in tpropertymap.h
2015-05-29 19:53:42 +02:00
Festus Hagen
b5d65edab7
Silence uint ambiguity errors in tests.
2015-05-27 14:07:53 -04:00
Scott Wheeler
a06d55ae6f
Merge pull request #577 from TsudaKageyu/frameoffset
...
Fix MPEG::File::firstFrameOffset() and lastFrameOffset(). (#190 )
2015-05-26 17:53:24 +02:00
Stephen F. Booth
c5f2e9342d
Merge pull request #578 from TsudaKageyu/test-temp
...
A lot of zero-sized temporary files are left after a test session on …
2015-05-25 08:41:37 -04:00
Tsuda Kageyu
2d778d5a0a
A lot of zero-sized temporary files are left after a test session on Windows.
2015-05-25 15:51:19 +09:00
Stephen F. Booth
0aa75b2e8d
Merge pull request #574 from TsudaKageyu/skip-dup-chunks
...
Skip duplicate chunks when reading AIFF/WAV files.
2015-05-24 14:38:50 -04:00
Tsuda Kageyu
618a939c56
Fix MPEG::File::firstFrameOffset() and lastFrameOffset(). ( #190 )
2015-05-25 02:41:27 +09:00
Tsuda Kageyu
2337fbcfc6
Stop calculating the offset in RIFF::File::chunkData().
2015-05-25 00:43:36 +09:00
Tsuda Kageyu
9da20a8a52
Skip duplicate chunks when reading AIFF/WAV files.
...
Similar to #492 .
There is no good reason to use the last chunk rather than the first one.
2015-05-25 00:40:13 +09:00
Stephen F. Booth
4129b919c1
Merge pull request #572 from TsudaKageyu/map-erase2
...
Map::erase() can take a key directly so no need to call find() before…
2015-05-23 08:21:58 -04:00
Tsuda Kageyu
6d6f544010
Map::erase() can take a key directly so no need to call find() beforehand.
2015-05-23 18:12:01 +09:00
Stephen F. Booth
93da3ba6d9
Merge pull request #571 from TsudaKageyu/fuzzed-wv
...
Avoid an infinite loop when reading fuzzed WavPack files. (#482 )
2015-05-22 07:44:41 -04:00
Stephen F. Booth
e064b88049
Merge pull request #570 from TsudaKageyu/audioprop-typo
...
Fix a typo in comment.
2015-05-22 07:41:46 -04:00
Tsuda Kageyu
3094540a4b
Avoid an infinite loop when reading fuzzed WavPack files. ( #482 )
2015-05-22 14:15:10 +09:00
Tsuda Kageyu
8e21dcc3d4
Fix a typo in comment.
2015-05-22 12:06:01 +09:00
Stephen F. Booth
0ea22348cb
Merge pull request #569 from TsudaKageyu/map-erase
...
std::map::erase() can take a key directly and has no-throw guarantee.
2015-05-21 22:46:15 -04:00
Stephen F. Booth
48ca54de1f
Merge pull request #484 from TsudaKageyu/fix-rfind
...
Fix File::rfind() for small files.
2015-05-21 22:44:10 -04:00
Tsuda Kageyu
54de66f275
std::map::erase() can take a key directly and has no-throw guarantee.
2015-05-22 01:26:56 +09:00
Lukáš Lalinský
d4b0ba2a7a
TagLib::XM::Properties is a public class that should be exported
2015-05-20 15:18:01 -07:00
Festus Hagen
abc5743222
Removed missed unnecessary BUILD_TESTS check.
2015-05-20 15:34:05 -04:00
Scott Wheeler
525396d9c2
Merge pull request #550 from TsudaKageyu/fix-test
...
Fix test code to work on some environments.
2015-05-20 19:24:52 +02:00
Tsuda Kageyu
bb9679b51a
Fix test code to work on some environments.
...
const char * is more preferable than string for ifstream constructor.
2015-05-21 02:03:06 +09:00
Festus Hagen
e44cba56b5
Don't look for CppUnit unless BUILD_TESTS, general cleanup.
2015-05-20 11:11:55 -04:00
Scott Wheeler
e4cf012522
Bring the API more in line with the rest of TagLib
...
Like in #255 , this also makes it possible to read values from the
tag in a const function.
2015-05-20 14:26:53 +02:00
Scott Wheeler
a37d423ea8
Merge pull request #549 from TsudaKageyu/win32-test
...
Modify the test code to work on MSVC/Windows.
2015-05-20 13:50:49 +02:00
Tsuda Kageyu
88a4cf34b8
Modify the test code to work on MSVC/Windows.
2015-05-20 20:19:20 +09:00
Scott Wheeler
81261dd128
This should also work Windows and has less duplicated code
2015-05-20 11:53:32 +02:00
Scott Wheeler
3bea9f6bee
Don't use tempnam on UNIX
...
This silences the huge stream of warnings when building the tests.
I think I didn't break the Windows version in the process (though
it may make sense to use the built in Windows functions there
instead), but I don't have a Windows build environment here, so
I can't test.
2015-05-20 11:45:32 +02:00
Scott Wheeler
9cc2d7cfee
Merge pull request #546 from TsudaKageyu/test-surrogate-pair
...
Add a test for strings that contains surrogate pairs.
2015-05-19 19:57:47 +02:00
Scott Wheeler
fe1bf015bb
Merge pull request #548 from TsudaKageyu/render-twice
...
No need to call ID3v2::Frame::render() twice when saving an ID3v2 tag.
2015-05-19 11:28:50 +02:00
Tsuda Kageyu
287078566f
No need to call ID3v2::Frame::render() twice when saving an ID3v2 tag.
2015-05-19 17:39:37 +09:00
Scott Wheeler
60966518e2
Quote path names including user-provided variables
...
This should make these work even if the value contains spaces
Closes #344
2015-05-19 10:15:15 +02:00
