Commit Graph

670 Commits

Author SHA1 Message Date
Scott Wheeler
7ad144536d Hmm. Actually assign the flag here. Thanks to Dirk for catching this.
BUG:130754


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@579077 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-08-31 00:51:22 +00:00
Scott Wheeler
ea12745d12 Make sure that these flags are set to the values that are actually used.
BUG:132191


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@578697 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-08-29 23:19:21 +00:00
Scott Wheeler
f8d1b7bb4f Update the TCON (genre) frame as we create it so that we don't keep ID3v2.3
formatted data sitting around waiting to be written to 2.4 tags.

BUG:132018


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@578687 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-08-29 23:06:14 +00:00
Scott Wheeler
784f71409b Add a warning note to File::save()
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@573841 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-08-17 10:31:52 +00:00
Scott Wheeler
8e52873513 Make sure that there's always a description and content even if they're empty.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@572797 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-08-13 23:49:27 +00:00
Scott Wheeler
2f1645947a This if doesn't need to be there. The encoding byte should be there even if there
is no string content.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@572787 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-08-13 23:10:43 +00:00
Scott Wheeler
071c691a9a Make removeField() actually remove the map content, not just
empty the list.  Also added an erase method to Map that works on keys
rather than itterators.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@572681 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-08-13 15:25:48 +00:00
Scott Wheeler
953b8a119a Add a simple function for checking for membership in the fieldListMap.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@572680 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-08-13 15:19:36 +00:00
Scott Wheeler
71a392fe81 The non-const functions here should call detach.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@572630 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-08-13 12:29:26 +00:00
Stephan Kulow
545c9ebeb7 ignoring
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@570113 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-08-05 18:04:04 +00:00
Scott Wheeler
23bd433cde Default to ID3v2.4 in the header (fixes the bug just reported on the list)
CCMAIL:taglib-devel@kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@554946 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-06-25 20:27:17 +00:00
Scott Wheeler
3856f38655 Don't overrun the buffer if the first byte is 0xff
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@553365 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-06-20 20:41:30 +00:00
Scott Wheeler
a6aeaef64e oops
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@552202 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-06-16 23:26:25 +00:00
Scott Wheeler
6a66c36a0c Here's another easy one that helps out on ginormus strings.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@552198 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-06-16 22:50:09 +00:00
Scott Wheeler
e83f93b2c0 A couple more optimizations for splitting vectors. One of them makes search
faster in the simple case (no need for Boyer-Moore for a one-character search)
and append a null vector rather than instantiating a new one when we find empty
fields.

This gets the reading time down to 6 seconds here for the reported bug, which
still isn't great, but it's starting to get close to acceptable.  I'll see if I
can get it a little tighter...

BUG:122183


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@552196 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-06-16 22:38:20 +00:00
Scott Wheeler
eb1b7c8255 This is much, much faster on large byte vectors and gets the current bug down
to where it can read the tag in around 18 seconds unstead of 30 minutes.

I'm going to see if I can find the other hot paths now...

CCBUG:122183


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@552178 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-06-16 20:36:36 +00:00
Scott Wheeler
ebf56779f4 Allan's commit was in the wrong branch -- don't corrupt files on
write...


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@549613 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-06-09 09:48:28 +00:00
Scott Wheeler
88aa8c125d This comes from strdup, so it should be freed rather than deleted.
Patch from Jon Burgess.

BUG:127260


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@549379 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-06-08 12:22:18 +00:00
Allan Sandfeld Jensen
ef34e50406 Initialize tag to avoid possible crashes
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@540838 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-05-14 19:18:47 +00:00
Scott Wheeler
f181d1d18b SVN_SILENT accidentally inserted tabs
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@538782 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-05-08 20:49:01 +00:00
Scott Wheeler
3f3026b349 Add a function to set the default ID3v2 encoding in the C API.
BUG:126192


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@538781 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-05-08 20:45:42 +00:00
Scott Wheeler
02cf970e0d Patch from John Stirling to fix bitmasks for header fields.
BUG:70649


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@538764 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-05-08 20:08:33 +00:00
Scott Wheeler
fca59f432e docs typo
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@532016 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-04-20 20:31:25 +00:00
Scott Wheeler
985630d59a SVN_SILENT
Forgot to add docs.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@515072 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-03-02 15:13:54 +00:00
Scott Wheeler
3a24d31b43 Two things:
- Fix the channel mode, copyright and original flags, as noticed by
   Bjoern Petersen.
 - Check in the "findByDescription()" function that I've had sitting
   around for a while.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@515068 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-03-02 15:02:27 +00:00
Scott Wheeler
c35d249195 Add a wide string export fuction.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@508477 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-02-11 21:18:03 +00:00
Scott Wheeler
361ce1635a Alright -- most of this code is just more cleanups, and the bugfix part of it
is relatively small.  Basically it took a while for me to be convinced that the
ID3v2 location was always going to be before the FLAC data stream pointer.  I've
added a check to make sure that it stays that way, but I don't expect us to
actually hit that code.

BUG:120578


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503614 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-01-29 17:47:38 +00:00
Scott Wheeler
142ddfadc9 A prelude to bugfixing. A few more cleanups.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503592 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-01-29 16:59:40 +00:00
Scott Wheeler
286d474dae Cleanups -- no functional changes.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503573 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-01-29 16:06:07 +00:00
Scott Wheeler
99fbe7ff25 Fix up the stuff here for appending values to an APE::Item and round out the API a bit.
Based on Michael's patch...

BUG:120256


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503255 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-01-28 15:18:31 +00:00
Scott Wheeler
4841a5c39c If a frame has both compression and encryption, since we currently
don't support encrypted frames, don't try to decompress it.  Decryption
is supposed to be applied before decompression, so currently the decompression
isn't possible.

BUG:112919


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503234 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-01-28 14:00:48 +00:00
Scott Wheeler
59b9831868 Switch this to "rb" and "rb+" since Windows seems to barf on it without the "b"
and it doesn't make a difference at all on UNIX.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503213 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-01-28 13:40:05 +00:00
Scott Wheeler
1aa0550c58 Another method that didn't actually have an implementation around. Also
picked some default values for some of the d-pointer members.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@482863 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-11-24 10:27:45 +00:00
Scott Wheeler
18d80d1ea0 Actually implement this constructor...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@482540 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-11-23 10:36:06 +00:00
Scott Wheeler
2d06d23ec6 Missing class name on the method declaration. I'm sure this caused some
fun symbol conflicts...


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@482539 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-11-23 10:27:33 +00:00
Scott Wheeler
f9c5ecaf53 SVN_SILENT a couple of missing docs
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@471683 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-10-18 12:33:48 +00:00
Scott Wheeler
5bb7dbe457 Silly second declaration of the variable here that triggers an infinite
loop in some cases (I'm surprised that it doesn't happen in more...this
code has been around for a while.).

BUG:113437


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@464483 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-09-27 14:34:32 +00:00
Scott Wheeler
603068695c A couple of things pointed out by a colleage -- fix ByteVector::size()
and make the return type semantics consistant for methods that modify
the object (specifically, return a reference instead of void).


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@460002 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-09-12 16:52:07 +00:00
Scott Wheeler
5d64692084 Just a couple of docs updates.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@457702 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-09-06 11:39:26 +00:00
Scott Wheeler
78c4c18e37 Fix the documentation for this method.
CCMAIL:Umesh Shankar <ushankar@cs.berkeley.edu>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@457127 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-09-04 20:06:27 +00:00
Scott Wheeler
fa61e63ac8 Leave the year field blank if it's set to zero (i.e. cleared).
BUG:109920


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@444448 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-08-10 08:33:28 +00:00
Scott Wheeler
b16c8587ab Forgot that this doesn't work for those not using
my hacked up build environment for TagLib.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@439118 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-27 07:29:41 +00:00
Scott Wheeler
b84fdcfa04 Last docs updates and a small function signature change. I'm pretty sure that's it for 1.4.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@439059 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-27 00:25:40 +00:00
Scott Wheeler
585bf5afca note other bindings
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438757 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-26 00:37:39 +00:00
Scott Wheeler
3de9ba2e9f Bug in UTF-8 rendering. Small change, but well, without the "break;" it was doing
the UTF-8 rendering and the UTF16-LE rendering to the same string, which was, well,
ungood.

(Sorry Dan, that's bad news for those files -- but this bug was only introduced 4
days ago, so it just hadn't been caught yet.)

BUG:109604


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438731 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-25 21:34:18 +00:00
Scott Wheeler
f7467bd1f9 Don't actually install the tdebug.h header.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438704 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-25 19:51:52 +00:00
Scott Wheeler
eb592f0933 Don't include tdebug.h in any installed header. I'll remove it from installation
shortly.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438692 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-25 19:26:00 +00:00
Scott Wheeler
052a1d2720 Add a list of the default file extensions that TagLib knows about, as requested
by Stefan.  Also did a few additional updates on the API docs.

CCMAIL:Stefan Gehn <mETz81@web.de>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438212 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-24 16:25:33 +00:00
Scott Wheeler
54b442d584 SVN_SILENT another place to update the version
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438078 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-24 08:03:37 +00:00
Scott Wheeler
111b0dc6eb Make sure that buffer allocations for file reads aren't completely bogus.
Specifically make sure that we don't actually allocate a buffer for a read that
extends beyond the end of the file.

BUG:101401


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438035 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-23 23:49:29 +00:00