From f40290dcaf6966f4f9328e355e02ef852ccfea3a Mon Sep 17 00:00:00 2001 From: Rosen Penev Date: Sat, 26 Nov 2022 22:26:31 -0800 Subject: [PATCH] clang-tidy: don't assign in if Found with bugprone-assignment-in-if-condition Signed-off-by: Rosen Penev --- taglib/mpeg/id3v2/id3v2tag.cpp | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/taglib/mpeg/id3v2/id3v2tag.cpp b/taglib/mpeg/id3v2/id3v2tag.cpp index 156c6d5e..f80a1b1a 100644 --- a/taglib/mpeg/id3v2/id3v2tag.cpp +++ b/taglib/mpeg/id3v2/id3v2tag.cpp @@ -186,9 +186,13 @@ String ID3v2::Tag::genre() const // the behavior the same as released versions it is being left with " ". const FrameList &tconFrames = d->frameListMap["TCON"]; - TextIdentificationFrame *f; - if(tconFrames.isEmpty() || - !(f = dynamic_cast(tconFrames.front()))) + if(tconFrames.isEmpty()) + { + return String(); + } + + TextIdentificationFrame *f = dynamic_cast(tconFrames.front()); + if(!f) { return String(); }