From f2b56a55118163e3807273c81b76a77157cf6b81 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luk=C3=A1=C5=A1=20Lalinsk=C3=BD?= Date: Mon, 12 Nov 2012 16:37:06 +0100 Subject: [PATCH] Remove no longer needed save methods in MPEG::File --- taglib/mpeg/mpegfile.cpp | 10 ---------- taglib/mpeg/mpegfile.h | 26 +------------------------- 2 files changed, 1 insertion(+), 35 deletions(-) diff --git a/taglib/mpeg/mpegfile.cpp b/taglib/mpeg/mpegfile.cpp index 038c1c8b..d2dce48a 100644 --- a/taglib/mpeg/mpegfile.cpp +++ b/taglib/mpeg/mpegfile.cpp @@ -178,16 +178,6 @@ bool MPEG::File::save() return save(AllTags); } -bool MPEG::File::save(int tags) -{ - return save(tags, true); -} - -bool MPEG::File::save(int tags, bool stripOthers) -{ - return save(tags, stripOthers, 4); -} - bool MPEG::File::save(int tags, bool stripOthers, int id3v2Version) { if(tags == NoTags && stripOthers) diff --git a/taglib/mpeg/mpegfile.h b/taglib/mpeg/mpegfile.h index b0d4a6db..f6dc8d56 100644 --- a/taglib/mpeg/mpegfile.h +++ b/taglib/mpeg/mpegfile.h @@ -172,29 +172,6 @@ namespace TagLib { */ virtual bool save(); - /*! - * Save the file. This will attempt to save all of the tag types that are - * specified by OR-ing together TagTypes values. The save() method above - * uses AllTags. This returns true if saving was successful. - * - * This strips all tags not included in the mask, but does not modify them - * in memory, so later calls to save() which make use of these tags will - * remain valid. This also strips empty tags. - */ - bool save(int tags); - - /*! - * Save the file. This will attempt to save all of the tag types that are - * specified by OR-ing together TagTypes values. The save() method above - * uses AllTags. This returns true if saving was successful. - * - * If \a stripOthers is true this strips all tags not included in the mask, - * but does not modify them in memory, so later calls to save() which make - * use of these tags will remain valid. This also strips empty tags. - */ - // BIC: combine with the above method - bool save(int tags, bool stripOthers); - /*! * Save the file. This will attempt to save all of the tag types that are * specified by OR-ing together TagTypes values. The save() method above @@ -207,8 +184,7 @@ namespace TagLib { * The \a id3v2Version parameter specifies the version of the saved * ID3v2 tag. It can be either 4 or 3. */ - // BIC: combine with the above method - bool save(int tags, bool stripOthers, int id3v2Version); + bool save(int tags, bool stripOthers = true, int id3v2Version = 4); /*! * Returns a pointer to the ID3v2 tag of the file.