From f1a16bcf0f9d20154b2733a8736a30bdbcb0aace Mon Sep 17 00:00:00 2001
From: Jeff Mitchell <mitchell@kde.org>
Date: Wed, 29 Apr 2009 12:55:33 +0000
Subject: [PATCH] Style and safety fixes backported from taglib-extras
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@961000 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
---
taglib/mp4/mp4tag.cpp | 7 ++++++-
taglib/mp4/mp4tag.h | 1 +
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/taglib/mp4/mp4tag.cpp b/taglib/mp4/mp4tag.cpp
index 229c4755..47a5b79d 100644
--- a/taglib/mp4/mp4tag.cpp
+++ b/taglib/mp4/mp4tag.cpp
@@ -79,6 +79,11 @@ MP4::Tag::Tag(File *file, MP4::Atoms *atoms)
}
}
+MP4::Tag::~Tag()
+{
+ delete d;
+}
+
ByteVectorList
MP4::Tag::parseData(MP4::Atom *atom, TagLib::File *file, int expectedFlags, bool freeForm)
{
@@ -167,7 +172,7 @@ MP4::Tag::parseFreeForm(MP4::Atom *atom, TagLib::File *file)
for(unsigned int i = 2; i < data.size(); i++) {
value.append(String(data[i], String::UTF8));
}
- String name = "----:" + data[0] + ":" + data[1];
+ String name = "----:" + data[0] + ':' + data[1];
d->items.insert(name, value);
}
}
diff --git a/taglib/mp4/mp4tag.h b/taglib/mp4/mp4tag.h
index 4671d16c..41b76657 100644
--- a/taglib/mp4/mp4tag.h
+++ b/taglib/mp4/mp4tag.h
@@ -45,6 +45,7 @@ namespace TagLib {
{
public:
Tag(TagLib::File *file, Atoms *atoms);
+ ~Tag();
bool save();
String title() const;