mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2026-06-14 02:09:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

default some more (#1135)

Browse Source 
* remove defaulted constructor

It gets implicitly generated.

Signed-off-by: Rosen Penev <rosenp@gmail.com>

* default some more

swap is not needed here as shared_ptr is copyable.

Signed-off-by: Rosen Penev <rosenp@gmail.com>

---------

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev
2023-09-15 23:25:04 -07:00
committed by GitHub
parent 97a74ca3d8
commit cf5ad66922
11 changed files with 17 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
taglib/fileref.cpp
View File

@@ -341,7 +341,7 @@ FileRef::FileRef(File *file) :
d->file = file;
}
FileRef::FileRef(const FileRef &ref) = default;
FileRef::FileRef(const FileRef &) = default;
FileRef::~FileRef() = default;
@@ -427,11 +427,7 @@ bool FileRef::isNull() const
return (!d->file || !d->file->isValid());
}
FileRef &FileRef::operator=(const FileRef &ref)
{
FileRef(ref).swap(*this);
return *this;
}
FileRef &FileRef::operator=(const FileRef &) = default;
void FileRef::swap(FileRef &ref)
{