From c4163a26e805bdec9a79b899bc0277d5501cb450 Mon Sep 17 00:00:00 2001 From: Birunthan Mohnathas Date: Mon, 12 Mar 2012 18:56:08 +0200 Subject: [PATCH] Fixed memory leak of FrameFactory singleton. --- taglib/mpeg/id3v2/id3v2framefactory.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/taglib/mpeg/id3v2/id3v2framefactory.cpp b/taglib/mpeg/id3v2/id3v2framefactory.cpp index b6bc34a5..da9c8018 100644 --- a/taglib/mpeg/id3v2/id3v2framefactory.cpp +++ b/taglib/mpeg/id3v2/id3v2framefactory.cpp @@ -73,9 +73,8 @@ FrameFactory *FrameFactory::factory = 0; FrameFactory *FrameFactory::instance() { - if(!factory) - factory = new FrameFactory; - return factory; + static FrameFactory factory; + return &factory; } Frame *FrameFactory::createFrame(const ByteVector &data, bool synchSafeInts) const