clang-tidy: Use default function declarations

run-clang-tidy -header-filter='.*' -checks='-*,modernize-use-equals-default' -fix

taglib/asf/asffile.cpp

@@ -103,7 +103,7 @@ class ASF::File::FilePrivate::BaseObject
 {
 public:
   ByteVector data;
-  virtual ~BaseObject() {}
+  virtual ~BaseObject() = default;
   virtual ByteVector guid() const = 0;
   virtual void parse(ASF::File *file, unsigned int size);
   virtual ByteVector render(ASF::File *file);

taglib/audioproperties.cpp

@@ -36,10 +36,7 @@ class AudioProperties::AudioPropertiesPrivate
 // public methods
 ////////////////////////////////////////////////////////////////////////////////
 
-AudioProperties::~AudioProperties()
-{
-
-}
+AudioProperties::~AudioProperties() = default;
 
 int AudioProperties::length() const
 {

taglib/fileref.cpp

@@ -516,10 +516,6 @@ void FileRef::parse(IOStream *stream, bool readAudioProperties,
   d->file = detectByContent(stream, readAudioProperties, audioPropertiesStyle);
 }
 
-FileRef::FileTypeResolver::~FileTypeResolver()
-{
-}
+FileRef::FileTypeResolver::~FileTypeResolver() = default;
 
-FileRef::StreamTypeResolver::~StreamTypeResolver()
-{
-}
+FileRef::StreamTypeResolver::~StreamTypeResolver() = default;

taglib/flac/flacmetadatablock.cpp

@@ -32,8 +32,7 @@ using namespace TagLib;
 class FLAC::MetadataBlock::MetadataBlockPrivate
 {
 public:
-  MetadataBlockPrivate() {}
-
+  MetadataBlockPrivate() = default;
 };
 
 FLAC::MetadataBlock::MetadataBlock()
@@ -41,7 +40,4 @@ FLAC::MetadataBlock::MetadataBlock()
 {
 }
 
-FLAC::MetadataBlock::~MetadataBlock()
-{
-}
-
+FLAC::MetadataBlock::~MetadataBlock() = default;

taglib/mod/modtag.cpp

@@ -34,9 +34,7 @@ using namespace Mod;
 class Mod::Tag::TagPrivate
 {
 public:
-  TagPrivate()
-  {
-  }
+  TagPrivate() = default;
 
   String title;
   String comment;

taglib/mp4/mp4atom.cpp

@@ -129,9 +129,7 @@ MP4::Atom::Atom(File *file)
   file->seek(offset + length);
 }
 
-MP4::Atom::~Atom()
-{
-}
+MP4::Atom::~Atom() = default;
 
 MP4::Atom *
 MP4::Atom::find(const char *name1, const char *name2, const char *name3, const char *name4)
@@ -193,8 +191,7 @@ MP4::Atoms::Atoms(File *file)
 }
 
 MP4::Atoms::~Atoms()
-{
-}
+= default;
 
 MP4::Atom *
 MP4::Atoms::find(const char *name1, const char *name2, const char *name3, const char *name4)

taglib/mpeg/id3v1/id3v1tag.cpp

@@ -63,13 +63,9 @@ public:
 // StringHandler implementation
 ////////////////////////////////////////////////////////////////////////////////
 
-StringHandler::StringHandler()
-{
-}
+StringHandler::StringHandler() = default;
 
-StringHandler::~StringHandler()
-{
-}
+StringHandler::~StringHandler() = default;
 
 String ID3v1::StringHandler::parse(const ByteVector &data) const
 {

taglib/mpeg/id3v2/id3v2footer.cpp

@@ -38,9 +38,7 @@ Footer::Footer() :
 {
 }
 
-Footer::~Footer()
-{
-}
+Footer::~Footer() = default;
 
 unsigned int Footer::size()
 {

taglib/mpeg/id3v2/id3v2tag.cpp

@@ -102,13 +102,9 @@ public:
 // StringHandler implementation
 ////////////////////////////////////////////////////////////////////////////////
 
-Latin1StringHandler::Latin1StringHandler()
-{
-}
+Latin1StringHandler::Latin1StringHandler() = default;
 
-Latin1StringHandler::~Latin1StringHandler()
-{
-}
+Latin1StringHandler::~Latin1StringHandler() = default;
 
 String Latin1StringHandler::parse(const ByteVector &data) const
 {

taglib/riff/wav/infotag.cpp

@@ -48,13 +48,9 @@ public:
 // StringHandler implementation
 ////////////////////////////////////////////////////////////////////////////////
 
-StringHandler::StringHandler()
-{
-}
+StringHandler::StringHandler() = default;
 
-StringHandler::~StringHandler()
-{
-}
+StringHandler::~StringHandler() = default;
 
 String RIFF::Info::StringHandler::parse(const ByteVector &data) const
 {

taglib/tag.cpp

@@ -34,15 +34,9 @@ class Tag::TagPrivate
 
 };
 
-Tag::Tag()
-{
+Tag::Tag() = default;
 
-}
-
-Tag::~Tag()
-{
-
-}
+Tag::~Tag() = default;
 
 bool Tag::isEmpty() const
 {

taglib/toolkit/tbytevectorlist.cpp

@@ -64,20 +64,14 @@ ByteVectorList ByteVectorList::split(const ByteVector &v, const ByteVector &patt
 // public members
 ////////////////////////////////////////////////////////////////////////////////
 
-ByteVectorList::ByteVectorList()
-{
-
-}
+ByteVectorList::ByteVectorList() = default;
 
 ByteVectorList::ByteVectorList(const ByteVectorList &l) : List<ByteVector>(l)
 {
 
 }
 
-ByteVectorList::~ByteVectorList()
-{
-
-}
+ByteVectorList::~ByteVectorList() = default;
 
 ByteVector ByteVectorList::toByteVector(const ByteVector &separator) const
 {

taglib/toolkit/tdebuglistener.cpp

@@ -56,7 +56,7 @@ namespace
 
       std::cerr << msg;
 
-#endif 
+#endif
     }
   };
 
@@ -67,13 +67,9 @@ namespace TagLib
 {
   DebugListener *debugListener = &defaultListener;
 
-  DebugListener::DebugListener()
-  {
-  }
+  DebugListener::DebugListener() = default;
 
-  DebugListener::~DebugListener()
-  {
-  }
+  DebugListener::~DebugListener() = default;
 
   void setDebugListener(DebugListener *listener)
   {

taglib/toolkit/tiostream.cpp

@@ -85,13 +85,9 @@ String FileName::toString() const
 // public members
 ////////////////////////////////////////////////////////////////////////////////
 
-IOStream::IOStream()
-{
-}
+IOStream::IOStream() = default;
 
-IOStream::~IOStream()
-{
-}
+IOStream::~IOStream() = default;
 
 void IOStream::clear()
 {

taglib/toolkit/tpropertymap.cpp

@@ -28,13 +28,9 @@
 using namespace TagLib;
 
 
-PropertyMap::PropertyMap()
-{
-}
+PropertyMap::PropertyMap() = default;
 
-PropertyMap::PropertyMap(const PropertyMap &m) : SimplePropertyMap(m), unsupported(m.unsupported)
-{
-}
+PropertyMap::PropertyMap(const PropertyMap &m) = default;
 
 PropertyMap::PropertyMap(const SimplePropertyMap &m)
 {
@@ -47,9 +43,7 @@ PropertyMap::PropertyMap(const SimplePropertyMap &m)
   }
 }
 
-PropertyMap::~PropertyMap()
-{
-}
+PropertyMap::~PropertyMap() = default;
 
 bool PropertyMap::insert(const String &key, const StringList &values)
 {

taglib/toolkit/tstring.cpp

@@ -140,8 +140,7 @@ namespace TagLib {
 class String::StringPrivate : public RefCounter
 {
 public:
-  StringPrivate()
-    {}
+  StringPrivate() = default;
 
   /*!
    * Stores string in UTF-16. The byte order depends on the CPU endian.

taglib/toolkit/tstringlist.cpp

@@ -55,10 +55,7 @@ StringList StringList::split(const String &s, const String &pattern)
 // public members
 ////////////////////////////////////////////////////////////////////////////////
 
-StringList::StringList()
-{
-
-}
+StringList::StringList() = default;
 
 StringList::StringList(const StringList &l) : List<String>(l)
 {
@@ -78,9 +75,7 @@ StringList::StringList(const ByteVectorList &bl, String::Type t)
 }
 
 StringList::~StringList()
-{
-
-}
+= default;
 
 String StringList::toString(const String &separator) const
 {

taglib/xm/xmfile.cpp

@@ -70,9 +70,7 @@ namespace
 class Reader
 {
 public:
-  virtual ~Reader()
-  {
-  }
+  virtual ~Reader() = default;
 
   /*!
    * Reads associated values from \a file, but never reads more