diff --git a/taglib/toolkit/tpicturetype.cpp b/taglib/toolkit/tpicturetype.cpp index 33442b1d..a223952e 100644 --- a/taglib/toolkit/tpicturetype.cpp +++ b/taglib/toolkit/tpicturetype.cpp @@ -65,7 +65,7 @@ String Utils::pictureTypeToString(int type) return ""; } -int Utils::pictureTypeFromString(String str) +int Utils::pictureTypeFromString(const String& str) { for(int i = 0; i < static_cast(std::size(typeStrs)); ++i) { if(str == typeStrs[i]) { diff --git a/taglib/toolkit/tpicturetype.h b/taglib/toolkit/tpicturetype.h index a9cadf19..f16fa833 100644 --- a/taglib/toolkit/tpicturetype.h +++ b/taglib/toolkit/tpicturetype.h @@ -93,7 +93,7 @@ enum name { \ static TagLib::String typeToString(name type) { \ return TagLib::Utils::pictureTypeToString(type); \ } \ -static name typeFromString(TagLib::String str) { \ +static name typeFromString(const TagLib::String &str) { \ return static_cast( \ TagLib::Utils::pictureTypeFromString(str)); \ } @@ -112,7 +112,7 @@ namespace TagLib { /*! * Get picture type from string representation. */ - int TAGLIB_EXPORT pictureTypeFromString(String str); + int TAGLIB_EXPORT pictureTypeFromString(const String& str); } // namespace Utils } // namespace TagLib