From abbf8808720fb916ccee948ffebb8a266ff65cd9 Mon Sep 17 00:00:00 2001 From: Rosen Penev Date: Sat, 26 Nov 2022 22:40:37 -0800 Subject: [PATCH] clang-tidy: use member initializer Found with cppcoreguidelines-prefer-member-initializer Signed-off-by: Rosen Penev --- taglib/flac/flacmetadatablock.cpp | 2 +- taglib/mp4/mp4atom.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/taglib/flac/flacmetadatablock.cpp b/taglib/flac/flacmetadatablock.cpp index 17ab05f3..8b795f22 100644 --- a/taglib/flac/flacmetadatablock.cpp +++ b/taglib/flac/flacmetadatablock.cpp @@ -37,8 +37,8 @@ public: }; FLAC::MetadataBlock::MetadataBlock() + : d(0) { - d = 0; } FLAC::MetadataBlock::~MetadataBlock() diff --git a/taglib/mp4/mp4atom.cpp b/taglib/mp4/mp4atom.cpp index 140ed12b..c4f4ff5d 100644 --- a/taglib/mp4/mp4atom.cpp +++ b/taglib/mp4/mp4atom.cpp @@ -38,10 +38,10 @@ const char *const MP4::Atom::containers[11] = { }; MP4::Atom::Atom(File *file) + : offset(file->tell()) { children.setAutoDelete(true); - offset = file->tell(); ByteVector header = file->readBlock(8); if(header.size() != 8) { // The atom header must be 8 bytes long, otherwise there is either