From a79cb4deb98a642f01861a7ae1b209a037d6127a Mon Sep 17 00:00:00 2001
From: Scott Wheeler <wheeler@kde.org>
Date: Mon, 4 Feb 2008 03:28:39 +0000
Subject: [PATCH] Less code, less ifdefs, should compile on Solaris.  I knocked
 out Win 9x support on the way since it simplified things, and, well, I don't
 care about supporting Windows releases that have been outdated for 7 years.

BUG:157099


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@770581 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
---
 taglib/toolkit/tfile.cpp | 119 +++++++++++++++------------------------
 taglib/toolkit/tfile.h   |  14 ++---
 2 files changed, 51 insertions(+), 82 deletions(-)

diff --git a/taglib/toolkit/tfile.cpp b/taglib/toolkit/tfile.cpp
index 49105334..d670f539 100644
--- a/taglib/toolkit/tfile.cpp
+++ b/taglib/toolkit/tfile.cpp
@@ -30,14 +30,16 @@
 #include <stdio.h>
 #include <string.h>
 #include <sys/stat.h>
+
 #ifdef _WIN32
 # include <wchar.h>
 # include <windows.h>
 # include <io.h>
 # define ftruncate _chsize
 #else
- #include <unistd.h>
+# include <unistd.h>
 #endif
+
 #include <stdlib.h>
 
 #ifndef R_OK
@@ -49,44 +51,57 @@
 
 using namespace TagLib;
 
+#ifdef _WIN32
+
+typedef FileName FileNameHandle;
+
+#else
+
+struct FileNameHandle : public std::string
+{
+  FileNameHandle(FileName name) : std::string(name) {}
+  operator FileName () const { return c_str(); }
+};
+
+#endif
+
 class File::FilePrivate
 {
 public:
-  FilePrivate(FileName fileName) :
-    file(0),
-    name(fileName),
-    readOnly(true),
-    valid(true),
-    size(0)
-    {}
-
-  ~FilePrivate()
-  {
-#ifdef _WIN32
-    free((void *)((const char *)name));
-    free((void *)((const wchar_t *)name));
-#else
-    free((void *)name);
-#endif
-  }
-
-  void openFile(const char *file, bool printError = true);
-#ifdef _WIN32
-  void openFile(const wchar_t *file);
-#endif
+  FilePrivate(FileName fileName);
 
   FILE *file;
-  FileName name;
+
+  FileNameHandle name;
+
   bool readOnly;
   bool valid;
   ulong size;
   static const uint bufferSize = 1024;
 };
 
-void File::FilePrivate::openFile(const char *name, bool printError)
+File::FilePrivate::FilePrivate(FileName fileName) :
+  file(0),
+  name(fileName),
+  readOnly(true),
+  valid(true),
+  size(0)
 {
-  // First try with read/write mode, if that fails, fall back to read only.
-  // We can't use ::access() since that works in odd ways on some file systems.
+  // First try with read / write mode, if that fails, fall back to read only.
+
+#ifdef _WIN32
+
+  file = _wfopen(name, L"rb+");
+
+  if(file)
+    readOnly = false;
+  else
+    file = _wfopen(name, L"rb");
+
+  if(file)
+    return;
+
+#endif
 
   file = fopen(name, "rb+");
 
@@ -95,63 +110,17 @@ void File::FilePrivate::openFile(const char *name, bool printError)
   else
     file = fopen(name, "rb");
 
-  if(!file && printError)
-    debug("Could not open file " + String(name));
-}
-
-#ifdef _WIN32
-
-void File::FilePrivate::openFile(const wchar_t *name)
-{
-  // Windows NT/2000/XP/Vista
-
-  if(GetVersion() < 0x80000000) {
-    file = _wfopen(name, L"rb+");
-    if(file)
-      readOnly = false;
-    else
-      file = _wfopen(name, L"rb");
-  }
-
-  // Windows 9x/ME
-
-  else {
-    size_t length = wcslen(name) + 1;
-    char *tmpname = (char *)malloc(length);
-    if(tmpname) {
-      if(WideCharToMultiByte(CP_ACP, 0, name, -1, tmpname, length, NULL, NULL))
-        openFile(tmpname, false);
-      free(tmpname);
-    }
-  }
-
   if(!file)
-    debug("Could not open file " + String(name));
+    debug("Could not open file " + String((const char *) name));
 }
 
-#endif
-
 ////////////////////////////////////////////////////////////////////////////////
 // public members
 ////////////////////////////////////////////////////////////////////////////////
 
 File::File(FileName file)
 {
-#ifdef _WIN32
-  const char *name = (const char *)file;
-  const wchar_t *wname = (const wchar_t *)file;
-  if(wname) {
-    d = new FilePrivate(::_wcsdup(wname));
-    d->openFile(wname);
-  }
-  else {
-    d = new FilePrivate(::strdup(name));
-    d->openFile(name);
-  }
-#else
-  d = new FilePrivate(::strdup(file));
-  d->openFile(d->name);
-#endif
+  d = new FilePrivate(file);
 }
 
 File::~File()
diff --git a/taglib/toolkit/tfile.h b/taglib/toolkit/tfile.h
index 4fbdd8fb..c2f850ff 100644
--- a/taglib/toolkit/tfile.h
+++ b/taglib/toolkit/tfile.h
@@ -41,13 +41,13 @@ namespace TagLib {
   class TAGLIB_EXPORT FileName
   {
   public:
-    FileName(const wchar_t *name) : name(0), wname(name) {}
-    FileName(const char *name) : name(name), wname(0) {}
-    operator const wchar_t *() { return wname; }
-    operator const char *() { return name; }
-  protected:
-    const char *name;
-    const wchar_t *wname;
+    FileName(const wchar_t *name) : m_wname(name) {}
+    FileName(const char *name) : m_name(name) {}
+    operator const wchar_t *() const { return m_wname.c_str(); }
+    operator const char *() const { return m_name.c_str(); }
+  private:
+    std::string m_name;
+    std::wstring m_wname;
   };
 #else
   typedef const char *FileName;