mirror of
https://github.com/taglib/taglib.git
synced 2026-06-14 02:09:27 -04:00
Remove virtual destructors from POD toolkit types
This one's been haunting me for a couple decades. "Make all the things virtual!" was kind of a strategy I had for forward compatibility when I wrote this code when I was 20 or so and didn't know better.
This commit is contained in:
@@ -299,7 +299,7 @@ public:
|
||||
file(nullptr),
|
||||
stream(nullptr) {}
|
||||
|
||||
~FileRefPrivate() override {
|
||||
~FileRefPrivate() {
|
||||
delete file;
|
||||
delete stream;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user